Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable watermark stats polling by default #2603

Merged
merged 1 commit into from
Mar 22, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dockers/docker-orchagent/enable_counters.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ def enable_counters():
enable_counter_group(db, 'PORT')
enable_counter_group(db, 'QUEUE')
enable_counter_group(db, 'PFCWD')
enable_counter_group(db, 'PG_WATERMARK')
enable_counter_group(db, 'QUEUE_WATERMARK')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the corresponding FLEX_COUNTER_GROUP_TABLE is enabled, CONFIG_DB will have the entry flow into it even if the saved config may not have the entry enlisted. In the warm-reboot case, Orch::bake() can detect the entry, and will populate the entry into m_toSync. The counter poll postponement will thus lose its purpose in the warm-reboot case. @pavel-shirshov


def get_uptime():
with open('/proc/uptime') as fp:
Expand Down