Consolidate device-specific files; install as a Debian package #316

jleveque · 2017-02-22T01:31:52Z

All device-specific files now reside under /device directory in a <vendor-name>/<platform-string>/<hardware-SKU> directory structure in repo.
Device-specific files are now packaged into a Debian package and are now installed to /usr/share/sonic/device/<platform-string>/<hardware-SKU>/ directory on switch.

~~- TODO: Need to update sonic-utilities git submodule reference once sonic-net/sonic-utilities#7 is merged.~~

lguohan · 2017-02-22T03:59:53Z

there are build failures, can you check?

jleveque · 2017-02-22T05:50:27Z

Build failures are to be expected for now, as this commit also relies upon my PR @ sonic-net/sonic-utilities#7 as mentioned in my initial comment.

lguohan · 2017-02-23T00:42:12Z

can you add ingrasis/x86_64-ingrasys_s9100-r0/INGRASIS-S9100-C32 platform?

the onie_platform = x86_64-ingrasys_s9100-r0
sonic hwsku = INGRASIS-S9100-C32

b5f9fca

lguohan · 2017-02-23T00:46:09Z

can you also add Arista-7060-CX32S which is in the current tree?

f57fd0b

taoyl-ms · 2017-02-23T00:54:29Z

We also need to edit files/build_templates/sonic_debian_extension to install this deb package in oneimage, and $(DOCKER_DHCP_RELAY)_RUN_OPT in rule files for each docker to mount the correct folder into container.

lguohan · 2017-02-23T00:59:05Z

correctly, we need to install sonic-device_data.deb into the oneimage.

taoyl-ms · 2017-02-23T01:00:37Z

@lguohan Then we can't remove platform files from sonic-config-engine in this PR, or it will cause runtime break.

lguohan

need to install the package into oneimage.

jleveque · 2017-02-23T01:32:26Z

Ingrasys s9100 HW SKU currently appears to be "ingrasys-s9100" not "INGRASIS-S9100-C32." Is this changing? Also seems to have a typo.
What is the ONIE platform string for the Arista-7060-CX32S?

lguohan · 2017-02-23T10:18:43Z

you are right: INGRASYS-S9100-C32

arista_7060_cx32s

lguohan · 2017-02-23T10:20:00Z

@taoyl-ms , agree that we do not delete any existing platform data files in this PR.

lguohan · 2017-02-23T11:58:19Z

device/arista/x86_64-arista_7050_qx32/Arista-7050-QX32/bin/eeprom.py

@@ -0,0 +1,220 @@
+#!/usr/bin/env python


eeprom.py and sfputil.py should be under onie_platform directory as it is hardware platform specific and does not depends on the port breakout mode.

OK. Should we keep them in a bin/ subdir?

maybe call it plugins directory?

Sure thing. That's a better description. Resolved: 90e5031

…structure

…atform dirs

…lities Python packages

…w until sonic-device-data is thoroughly tested

…dencies

…log (sonic-net#316)

Configuration Last Updated Timestamp

…n] update submodule head linkmgrd: * 8e9e49b 2022-11-02 | [active-standby][active-active] update link prober stats updating frequency to 30s (sonic-net#152) (HEAD -> 202205) [Jing Zhang] * 1ad3f18 2022-11-01 | [Active-Active] periodically re-sync soc side admin forwarding state (sonic-net#151) [Jing Zhang] * cfcdb76 2022-11-01 | [202205] incrementing icmp buffer size (sonic-net#150) [Jing Zhang] swss: * ac7570a 2022-11-03 | [Dynamic buffer calculation][Mellanox] Enhance the logic to identify buffer pools and profiles (sonic-net#2498) (HEAD -> 202205) [Stephen Sun] swss-common: * 300fc8f 2022-10-31 | [sonic-db-cli] Fix sonic-db-cli crash when database config file not ready issue. (sonic-net#701) (HEAD -> 202205) [Hua Liu] platform-daemon: * cd1608a 2022-10-28 | [ycabled] add support for detach mode in 'active-active' topology (sonic-net#309) (HEAD -> 202205) [vdahiya12] * 2a5f0f4 2022-10-27 | Added filtering logic to send filtered fields from DB event (sonic-net#307) [mihirpat1] platform-common: * b521882 2022-10-30 | CmisApi::get_application_advertisement catch AttributeError as well (sonic-net#316) (HEAD -> 202205) [Stephen Sun] Signed-off-by: Ying Xie <ying.xie@microsoft.com>

…n] update submodule head (#12594) linkmgrd: * 8e9e49b 2022-11-02 | [active-standby][active-active] update link prober stats updating frequency to 30s (#152) (HEAD -> 202205) [Jing Zhang] * 1ad3f18 2022-11-01 | [Active-Active] periodically re-sync soc side admin forwarding state (#151) [Jing Zhang] * cfcdb76 2022-11-01 | [202205] incrementing icmp buffer size (#150) [Jing Zhang] swss: * ac7570a 2022-11-03 | [Dynamic buffer calculation][Mellanox] Enhance the logic to identify buffer pools and profiles (#2498) (HEAD -> 202205) [Stephen Sun] swss-common: * 300fc8f 2022-10-31 | [sonic-db-cli] Fix sonic-db-cli crash when database config file not ready issue. (#701) (HEAD -> 202205) [Hua Liu] platform-daemon: * cd1608a 2022-10-28 | [ycabled] add support for detach mode in 'active-active' topology (#309) (HEAD -> 202205) [vdahiya12] * 2a5f0f4 2022-10-27 | Added filtering logic to send filtered fields from DB event (#307) [mihirpat1] platform-common: * b521882 2022-10-30 | CmisApi::get_application_advertisement catch AttributeError as well (#316) (HEAD -> 202205) [Stephen Sun] Signed-off-by: Ying Xie <ying.xie@microsoft.com> Signed-off-by: Ying Xie <ying.xie@microsoft.com>

aa86083 Fix issue: rounding float value for txpower and rxpower (sonic-net#320) 2052a63 Fix issue: copper cable should not display DOM information (sonic-net#318) cf4c6af CmisApi::get_application_advertisement catch AttributeError as well (sonic-net#316) Signed-off-by: Stephen Sun <stephens@nvidia.com>

#12639) * Advance submodule sonic-utilities d5a6da31 Do not configure physical attributes on port channels in portconfig (#2456) 48ee7722 Change db_migrator major version on master branch from version 3 to 4 (#2470) f3746163 [GCU] Fix JsonPointerFilter bug (#2477) 58dbb3e6 YANG Validation for ConfigDB Updates: TACPLUS, TACPLUS_SERVER, AAA, VLAN_SUB_INTERFACE tables + decorated validated_mod_entry (#2452) 062f18a0 fix show interface neighbor expected empty issue (#2465) 569edf3b Fix display disorder problem of show mirror_session (#2447) daaf0ffc Disable "tag as local" when reboot (#2451) 6621120b Fix sudo sfputil show error-status on a multiasic platform issue (#2373) e8b1dcdf Add IP remove warnings for VRF commands (#2351) 40cc8e11 [scripts/generate_dump] add information to tech-support file (#2357) 8473517e Revert "[config reload]: On dual ToR systems, cache ARP and FDB table (#2460) Signed-off-by: Stephen Sun <stephens@nvidia.com> * Advance sonic-platform-common aa86083 Fix issue: rounding float value for txpower and rxpower (#320) 2052a63 Fix issue: copper cable should not display DOM information (#318) cf4c6af CmisApi::get_application_advertisement catch AttributeError as well (#316) Signed-off-by: Stephen Sun <stephens@nvidia.com> Signed-off-by: Stephen Sun <stephens@nvidia.com>

Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com e474335 (HEAD -> master, origin/master, origin/HEAD) [ycabled] fix minor appl_db retrieving logic for update (#319) 9b84b58 Use github code scanning instead of LGTM (#316) f784ad7 Pass grid parameter while calling set_laser_freq (#317) ed818f8 [PSU daemon] Support PSU power threshold checking (#288) 707a720 (origin/202211) [chassisd] update chassisd to write fabric and lc asics on sep erate table (#311) e8c5657 [ycabled] fix exception-handling logic for ycabled (#306) 905874d [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (#303) 510d330 Fix typo in xcvrd (#313) 9ae551f [ycabled] add support for detach mode in 'active-active' topology (#309) The above commits are added to sonic-platform-daemons

…atform-common][py-swsssdk] advance submodule head linkmgrd: * bf75a93 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#157) (HEAD -> 202205, github/202205) [Liu Shilong] utilities: * c1fa31d 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#2530) (HEAD -> 202205) [Liu Shilong] * 9990208 2022-05-19 | Add sonic-delayed.target to Application Extension .timer file generator (sonic-net#2176) [noaOrMlnx] swss: * 7b3170a 2023-01-05 | Revert "sonic-swss: Fix orchagent crash in generateQueueMapPerPort. (sonic-net#2552)" (HEAD -> 202205) [Ying Xie] * 4897e93 2023-01-05 | Revert "[bufferorch] : Support for buffer profiles for VoQ on chassis (sonic-net#2465)" (HEAD -> 202205, github/202205) [Ying Xie] * bbccc68 2023-01-04 | [vstest] Only collect stdout of orchagent_restart_check in vstest (sonic-net#2597) (HEAD -> 202205, github/202205) [bingwang-ms] * f7a7c05 2023-01-04 | Avoid aborting orchagent when setting TUNNEL attributes (sonic-net#2591) [Stephen Sun] * 84064fa 2022-12-20 | Fixed a bug causing error state of same configuration is applied twice. (sonic-net#2580) [siqbal1986] * 4851bef 2022-12-20 | Only collect stdout of orchagent_restart_check in vstest (sonic-net#2578) [bingwang-ms] * 2904d95 2022-12-05 | sonic-swss: Fix orchagent crash in generateQueueMapPerPort. (sonic-net#2552) [Sambath Kumar Balasubramanian] * ac84e41 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#2546) [Liu Shilong] * 502bd69 2022-12-20 | Fix `test_vlan.py` (sonic-net#2541) [Longxiang Lyu] * 1e37d0e 2022-12-19 | [voq][chassis]Add show fabric counters port/queue commands (sonic-net#2522) [jfeng-arista] * 17cdad3 2022-12-20 | [bufferorch] : Support for buffer profiles for VoQ on chassis (sonic-net#2465) [vmittal-msft] * 5345338 2023-01-04 | Disable `arp_evict_nocarrier` for vlan host intf (sonic-net#2590) [Longxiang Lyu] swss-common: * 9616287 2023-01-04 | Added customer monitoring tables in app db and state db (sonic-net#725) (HEAD -> 202205) [siqbal1986] * d03b95d 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#718) [Liu Shilong] * 8a276c6 2022-12-28 | Fix sonic-slave docker image environment issue. (sonic-net#728) (github/202205) [Liu Shilong] * 8fee1b4 2022-11-14 | Fix memory leak issue in ConfigDBConnector. (sonic-net#655) (sonic-net#706) [Hua Liu] sairedis: * 5387602 2022-11-30 | Use github code scanning instead of LGTM (#1160) (HEAD -> 202205) [Liu Shilong] platform-daemons: * b499412 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#316) (HEAD -> 202205, github/202205) [Liu Shilong] platform-common: * d11e983 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#328) (HEAD -> 202205) [Liu Shilong] py-swsssdk: * b654e91 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#131) (HEAD -> 202205) [Liu Shilong] Signed-off-by: Ying Xie <ying.xie@microsoft.com>

…atform-common][py-swsssdk] advance submodule head (#13260) linkmgrd: * bf75a93 2022-11-30 | Use github code scanning instead of LGTM (#157) (HEAD -> 202205, github/202205) [Liu Shilong] utilities: * c1fa31d 2022-11-30 | Use github code scanning instead of LGTM (#2530) (HEAD -> 202205) [Liu Shilong] * 9990208 2022-05-19 | Add sonic-delayed.target to Application Extension .timer file generator (#2176) [noaOrMlnx] swss: * bbccc68 2023-01-04 | [vstest] Only collect stdout of orchagent_restart_check in vstest (#2597) (HEAD -> 202205, github/202205) [bingwang-ms] * f7a7c05 2023-01-04 | Avoid aborting orchagent when setting TUNNEL attributes (#2591) [Stephen Sun] * 84064fa 2022-12-20 | Fixed a bug causing error state of same configuration is applied twice. (#2580) [siqbal1986] * 4851bef 2022-12-20 | Only collect stdout of orchagent_restart_check in vstest (#2578) [bingwang-ms] * 2904d95 2022-12-05 | sonic-swss: Fix orchagent crash in generateQueueMapPerPort. (#2552) [Sambath Kumar Balasubramanian] * ac84e41 2022-11-30 | Use github code scanning instead of LGTM (#2546) [Liu Shilong] * 502bd69 2022-12-20 | Fix `test_vlan.py` (#2541) [Longxiang Lyu] * 1e37d0e 2022-12-19 | [voq][chassis]Add show fabric counters port/queue commands (#2522) [jfeng-arista] * 17cdad3 2022-12-20 | [bufferorch] : Support for buffer profiles for VoQ on chassis (#2465) [vmittal-msft] * 5345338 2023-01-04 | Disable `arp_evict_nocarrier` for vlan host intf (#2590) [Longxiang Lyu] swss-common: * 9616287 2023-01-04 | Added customer monitoring tables in app db and state db (#725) (HEAD -> 202205) [siqbal1986] * d03b95d 2022-11-30 | Use github code scanning instead of LGTM (#718) [Liu Shilong] * 8a276c6 2022-12-28 | Fix sonic-slave docker image environment issue. (#728) (github/202205) [Liu Shilong] * 8fee1b4 2022-11-14 | Fix memory leak issue in ConfigDBConnector. (#655) (#706) [Hua Liu] sairedis: * 5387602 2022-11-30 | Use github code scanning instead of LGTM (#1160) (HEAD -> 202205) [Liu Shilong] platform-daemons: * b499412 2022-11-30 | Use github code scanning instead of LGTM (#316) (HEAD -> 202205, github/202205) [Liu Shilong] platform-common: * d11e983 2022-11-30 | Use github code scanning instead of LGTM (#328) (HEAD -> 202205) [Liu Shilong] py-swsssdk: * b654e91 2022-11-30 | Use github code scanning instead of LGTM (#131) (HEAD -> 202205) [Liu Shilong] Signed-off-by: Ying Xie <ying.xie@microsoft.com> Signed-off-by: Ying Xie <ying.xie@microsoft.com>

…11 branch (#13203) Why I did it advance sonic-platform-daemons submodule for 202211 branch a35b57d - (HEAD, origin/202211) Remove TODO comments which are no longer needed (Support centec platform #325) (3 days ago) [Junchao-Mellanox] 3a3726b - [thermalctld] fix some redundant removal of state DB tables (configurations are re-generated across reboots #315) (3 days ago) [vdahiya12] c5afac0 - Add new fields to status/dom_sensor/pm tables in STATE_DB for CMIS/C-CMIS (Combine alias_map.json with port_config.ini #304) (3 days ago) [longhuan-cisco] 1a338d4 - Create TRANSCEIVER_DOM_THRESHOLD table in state DB (Fix the reference in docker-snmp-sv2 to deprecated alias_map.json #320) (3 days ago) [mihirpat1] 7c77907 - Remove the argument that is causing the xcvrd to crash (ingrasys-s9100: Add ingrasys switch s9100 #318) (3 days ago) [Vivek] 5a70e7f - [ycabled] fix minor appl_db retrieving logic for update (dockers/docker-snmp-sv2/config.sh still references deprecated alias_map.json file #319) (3 days ago) [vdahiya12] b669533 - Use github code scanning instead of LGTM (Consolidate device-specific files; install as a Debian package #316) (3 days ago) [Liu Shilong] d3c6739 - Pass grid parameter while calling set_laser_freq ([swss]: update sonic-swss to fix buffer configuration on mlnx platform #317) (3 days ago) [mihirpat1] 778f843 - [PSU daemon] Support PSU power threshold checking (Add get_graph service to fetch minigraph automatically #288) (9 days ago) [Stephen Sun] 707a720 - [chassisd] update chassisd to write fabric and lc asics on sep erate table (ingrasys-s9100: Add ingrasys switch s9100 #311) (8 weeks ago) [arlakshm] e8c5657 - [ycabled] fix exception-handling logic for ycabled (Move sysDescription to /etc/snmp #306) (8 weeks ago) [vdahiya12] 905874d - [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (Disable BCM54616S MII isolate mode #303) (9 weeks ago) [vdahiya12] 510d330 - Fix typo in xcvrd ([platform] Add support configurations files for DCS-7060CX-32S #313) (9 weeks ago) [Junchao-Mellanox] 9ae551f - [ycabled] add support for detach mode in 'active-active' topology (minigraph.py crashed when no png is in the minigraph #309) (2 months ago) [vdahiya12] How I did it How to verify it

…14048) For sonic-platform-daemons following commits are added to the submodule dd8fbae (HEAD -> 202012, origin/202012) [ycabled] add more coverage to ycabled; add minor name change for vendor API CLI return key-values pairs (#338) 846555e [thermalctld] fix some redundant removal of state DB tables (#315) 3d92fb9 Use github code scanning instead of LGTM (#316) For sonic-utilities the following commits are added in this PR to the submodule git log --oneline 39cdb49c..202012 ec4c6ea5 (HEAD -> 202012, origin/202012) [show][muxcable] add some new commands health, reset-cause, queue_info support for muxcable (#2414) (#2704) 03ef272e [202012][vlan] Remove add field of vlanid to DHCP_RELAY table while adding vlan (#2681) e00a81ac [202012][dhcp-relay] Add support for dhcp_relay config cli (#2640) 274184e1 [vlan] Refresh dhcpv6_relay config while adding/deleting a vlan (#2660) (#2668 #### Why I did it updating the submodule of sonic-platform-daemons, sonic-utilities #### How I did it updated the submodule

…onic-net#316) - Description Catch both TypeError and AttributeError in CmisApi::get_application_advertisement because an AttributeError will be thrown when updating a dict with None. - Motivation and Context Fix issue found during automation tests - How Has This Been Tested? Manually test Added new unit test Signed-off-by: Stephen Sun <stephens@nvidia.com>

…tomatically (#15014) Why I did it src/sonic-linux-kernel * 3909870 - (HEAD -> 202211, origin/202211) Change SECURE_UPGRADE_DEV_SIGNING_CERT to SECURE_UPGRADE_SIGNING_CERT (#315) (4 days ago) [DavidZagury] * baaa137 - [202211] Add Secure Boot Kernel configuration backport (#316) (4 days ago) [DavidZagury] How I did it How to verify it

ndk 22.9.26

…lly (#20675) #### Why I did it src/sonic-gnmi ``` * e844925 - (HEAD -> master, origin/master, origin/HEAD) Add support for RebootMethod_HALT for Reboot API (#286) (28 hours ago) [Vasundhara Volam] * e5125cb - Merge pull request #316 from hdwhdw/ignore (31 hours ago) [Dawei Huang] * c702d31 - Add build artifacts to gitignore. (2 days ago) [Dawei Huang] ``` #### How I did it #### How to verify it #### Description for the changelog

…lly (sonic-net#20675) #### Why I did it src/sonic-gnmi ``` * e844925 - (HEAD -> master, origin/master, origin/HEAD) Add support for RebootMethod_HALT for Reboot API (sonic-net#286) (28 hours ago) [Vasundhara Volam] * e5125cb - Merge pull request sonic-net#316 from hdwhdw/ignore (31 hours ago) [Dawei Huang] * c702d31 - Add build artifacts to gitignore. (2 days ago) [Dawei Huang] ``` #### How I did it #### How to verify it #### Description for the changelog

jleveque requested review from lguohan, stcheng and taoyl-ms February 22, 2017 01:32

lguohan reviewed Feb 23, 2017

View reviewed changes

jleveque added 15 commits February 23, 2017 20:34

Move device-specific files from sonic-config-engine to new directory …

ba73c46

…structure

Add device-specific files from external sonic-utilities

9b75dd4

Remove ACS-S6000; Move files under Force10-S6000

a4a8eb3

Add files for Arista-7050-QX32 and Force10-S6100

f0f223c

sonic-config-engine no longer installs device-specific files

30a33b2

[All platforms]: Move sensors.conf from under HW SKU dirs to under pl…

cbcf87a

…atform dirs

[All platforms]: eeprom.py and sfputil.py now reference new SONiC uti…

06adc00

…lities Python packages

Now building sonic-utilities as SONIC_PYTHON_STDEB_DEBS

d0fc7e4

Add files for creating sonic-device-data Debian package

caa3e82

Fix full version string

c7ae52a

Fix source path

2779789

Rearrange sonic-device-data directory for clean build of Debian package

af632c0

Re-add existing platform-specific files to sonic-config-engine for no…

ef6d089

…w until sonic-device-data is thoroughly tested

Mount platform and hwsku directories in every docker

163a4e0

Install sonic-device-data in OneImage; Refactor sonic-utilities depen…

457f98c

…dencies

dzhangalibaba mentioned this pull request Dec 9, 2019

[swss-common] update submodule for sonic-swss-common #3863

Merged

dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020

Change sai log level before discovery to prevent SAI ERR spam to the …

39a5d14

…log (sonic-net#316)

sg893052 pushed a commit to sg893052/sonic-buildimage that referenced this pull request Apr 25, 2022

Merge pull request sonic-net#316 from a-barboza/master

e3e47d0

Configuration Last Updated Timestamp

yxieca mentioned this pull request Nov 3, 2022

[202205][linkmgrd][swss][swss-common][platform-daemon][platform-common] update submodule head #12594

Merged

vdahiya12 mentioned this pull request Nov 30, 2022

[sonic-platform-daemons] submodule update #12841

Merged

7 tasks

yxieca mentioned this pull request Jan 4, 2023

[202205][linkmgrd][utilities][swss][swss-common][platform-daemons][platform-common][py-swsssdk] advance submodule head #13260

Merged

StormLiangMS mentioned this pull request Jan 8, 2023

[submodule advance] advance sonic-platform-daemons submodule for 202211 branch #13203

Merged

8 tasks

mihirpat1 pushed a commit to mihirpat1/sonic-buildimage that referenced this pull request Feb 21, 2023

Use github code scanning instead of LGTM (sonic-net#316)

9b84b58

vdahiya12 mentioned this pull request Mar 1, 2023

[202012][sonic-platform-daemons][sonic-utilities] update submodule #14048

Merged

8 tasks

mlok-nokia pushed a commit to mlok-nokia/sonic-buildimage that referenced this pull request Jun 5, 2024

Merge pull request sonic-net#316 from jon-nokia/ndk-next-2205

7a3c3f2

ndk 22.9.26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Consolidate device-specific files; install as a Debian package #316

Consolidate device-specific files; install as a Debian package #316

jleveque commented Feb 22, 2017 •

edited

Loading

lguohan commented Feb 22, 2017

jleveque commented Feb 22, 2017

lguohan commented Feb 23, 2017 •

edited

Loading

lguohan commented Feb 23, 2017

taoyl-ms commented Feb 23, 2017

lguohan commented Feb 23, 2017 •

edited

Loading

taoyl-ms commented Feb 23, 2017 •

edited

Loading

lguohan left a comment

jleveque commented Feb 23, 2017

lguohan commented Feb 23, 2017

lguohan commented Feb 23, 2017

lguohan Feb 23, 2017

jleveque Feb 23, 2017

lguohan Feb 23, 2017 •

edited

Loading

jleveque Feb 23, 2017 •

edited

Loading

Consolidate device-specific files; install as a Debian package #316

Consolidate device-specific files; install as a Debian package #316

Conversation

jleveque commented Feb 22, 2017 • edited Loading

lguohan commented Feb 22, 2017

jleveque commented Feb 22, 2017

lguohan commented Feb 23, 2017 • edited Loading

lguohan commented Feb 23, 2017

taoyl-ms commented Feb 23, 2017

lguohan commented Feb 23, 2017 • edited Loading

taoyl-ms commented Feb 23, 2017 • edited Loading

lguohan left a comment

Choose a reason for hiding this comment

jleveque commented Feb 23, 2017

lguohan commented Feb 23, 2017

lguohan commented Feb 23, 2017

lguohan Feb 23, 2017

Choose a reason for hiding this comment

jleveque Feb 23, 2017

Choose a reason for hiding this comment

lguohan Feb 23, 2017 • edited Loading

Choose a reason for hiding this comment

jleveque Feb 23, 2017 • edited Loading

Choose a reason for hiding this comment

jleveque commented Feb 22, 2017 •

edited

Loading

lguohan commented Feb 23, 2017 •

edited

Loading

lguohan commented Feb 23, 2017 •

edited

Loading

taoyl-ms commented Feb 23, 2017 •

edited

Loading

lguohan Feb 23, 2017 •

edited

Loading

jleveque Feb 23, 2017 •

edited

Loading