Add SONiC CLI #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jleveque
commented
Feb 22, 2017
jleveque
commented
- Add SONiC CLI as a Python package
- Debian package is now built using Python setuptools instead of dpkg-buildpackage
- Create sonic_eeprom and sonic_sfp Python packages to cleanly house modules
- Merge changes from internal repo
…on setuptools convention
- Rename 'show' package to 'sonic-cli' - Create 'sonic-eeprom' Python package to house EEPROM-releated modules in an organized fashion - Create 'sonic-sfp' Python package to house SFP-related modules - All scripts now reference the above packages - sfputilbase.py now correctly parses 2- and 3-column port_config.ini/portmap.ini files
stcheng
suggested changes
Feb 22, 2017
scripts/decode-syseeprom
Outdated
| stderr=subprocess.STDOUT) | ||
| stdout = proc.communicate()[0] | ||
| proc.wait() | ||
| model = stdout.rstrip('\n') |
There was a problem hiding this comment.
rename model and submodel to platform and hwsku?
| @@ -66,7 +66,6 @@ filter_bucket_dict = { | |||
| 'RFCR': 1, | |||
| 'RJBR': 1, | |||
| 'RDBGC0': 2, | |||
| 'RDBGC2': 2, | |||
There was a problem hiding this comment.
This was a change I merged from our internal repo. You removed this, claiming it was an unnecessary drop counter on 5/12/2016.
scripts/portstat
Outdated
| @@ -310,7 +309,7 @@ Examples: | |||
| sys.exit(0) | |||
|
|
|||
| try: | |||
| bcmcmd_output = subprocess.Popen((['/usr/sbin/bcmcmd', | |||
| bcmcmd_output = subprocess.Popen((['/usr/bin/bcmcmd', | |||
There was a problem hiding this comment.
define the path at the top of the script?
| from sff8472 import sff8472InterfaceId | ||
| from sff8472 import sff8472Dom | ||
| from sff8436 import sff8436InterfaceId | ||
| from sff8436 import sff8436Dom |
There was a problem hiding this comment.
move sff8436/sff8472 to sonic_sfp folder?
There was a problem hiding this comment.
Already done. Since sfputilbase, sff8436 and sff8472 all reside in the same package now, they can simply reference one another using relative paths. I could make the paths absolute for clarity, if desired.
|
|
lguohan
approved these changes
Feb 23, 2017
stcheng
approved these changes
Feb 23, 2017
|
Please follow the GitHub Workflow and update the commit title and message. |
samaity
added a commit
to samaity/sonic-utilities
that referenced
this pull request
Dec 14, 2019
Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
vdahiya12
pushed a commit
to vdahiya12/sonic-utilities
that referenced
this pull request
Jul 23, 2021
platform plugins is mounted to /usr/share/sonic/platform/plugins in pmon docker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.