-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python linuxfd to image and pmon #3241
Conversation
this pr has increase the pmon docker size to 212MB. docker-platform-monitor.gz | Jul 31, 2019 12:01:59 AM | 212.43 MB current size is 126MB. docker-platform-monitor.gz | Jul 31, 2019 5:05:24 AM | 126.72 MB Can you fix this size issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
size increased a lot.
Just revised the commit, now the size increase is less than 100KB. Thanks. |
You force-pushed, so we lost the history. Please try to avoid this if possible. What did you change in the new commit? |
Noted, will avoid force pushes in the future, here is what changed in this commit compared to the last one: -Previous commit installs up-to-date pip with curl -Previous commit installs linuxfd on python2 and python3 -Previous commit apt-get purges curl and gcc -This commit additionally cleans the apt lists folder. Thanks |
I will put this PR on hold until I have verified that the change is needed for platform API. Thanks. |
…lly (#20932) #### Why I did it src/sonic-swss ``` * 3da2e676 - (HEAD -> master, origin/master, origin/HEAD) [dualtor] Fix standby neighbor inconsistency after warm reboot (#3356) (2 hours ago) [Longxiang Lyu] * 8bf38aff - [Chassis][LAG_ID] Address the same lagid been used in two different LCs issue (#3303) (2 hours ago) [Marty Y. Lok] * a9080f78 - Fixed narrowing conversion issues. (#3395) (2 hours ago) [mramezani95] * 98303af0 - [fpmsyncd] support pipeline to flush with a timer (#3241) (2 hours ago) [Yijiao Qin] * a8c358fc - [Dash] Handle FC update for existing ENI objects (#3373) (6 hours ago) [Vivek] ``` #### How I did it #### How to verify it #### Description for the changelog
- What I did
Add python linuxfd support in base image and pmon container.
To support a mix of blocking fd and polling event change detection in platform API, a timerfd is best suited to this task. Currently it would only be needed in base image but added for pmon as well since platform API functionality will most likely be used by pmon services in the future.
- How I did it
- How to verify it
linuxfd is able to be imported on device, and is able to be imported by python2 and python3 in pmon container.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)