Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cfggen] Allow sku with no alias mapping and minigraph with no png #335

Merged
merged 2 commits into from
Feb 25, 2017

Conversation

taoyl-ms
Copy link
Contributor

No description provided.

@lguohan
Copy link
Collaborator

lguohan commented Feb 24, 2017

                neighbors[endport] = {'name': startdevice, 'port': startport}

this name is not mapped to alias, it seems it is not consistent.


Refers to: src/sonic-config-engine/minigraph.py:68 in e4319eb. [](commit_id = e4319eb, deletion_comment = False)

@lguohan
Copy link
Collaborator

lguohan commented Feb 24, 2017

I do not know if it worth to do port alias mapping in the minigraph, another way to do is to do it in the template, it is like only doing this port alias mapping when needed. @jleveque , any thoughts on this?

@taoyl-ms
Copy link
Contributor Author

taoyl-ms commented Feb 24, 2017

I think it makes more sense to do port mapping in minigraph since it is a pure minigraph concept and sonic components shouldn't really care about it.
After minigraph.py finished the mapping, everything on the machine (except snmp and CLI tools) will only need to deal with sonic interfaces name, which is a neater contract.

@jleveque
Copy link
Contributor

I know we discussed making the alias mapping an extra layer, outside the minigraph, but I'm still a bit too junior on the project to know all of the potential needs for aliases throughout SONiC. I think it makes sense to be a function of sonic-config-engine nevertheless, whether it's done as part of the minigraph parsing or as another layer afterward.

@lguohan
Copy link
Collaborator

lguohan commented Feb 25, 2017

so, let's do more consistently and fix the neighbor port name as well?

@lguohan
Copy link
Collaborator

lguohan commented Feb 25, 2017

is this really about no png or only for the console, mgmt information in the device section? should we modify the title accordingly?

@taoyl-ms
Copy link
Contributor Author

It's really about no png. In the previous version if there is no png session sonic-cfggen will crash upon reading minigraph. In the new version it won't crash, but just ignore the corresponding data. (So if your template does not depend on png data it can still work with a minigraph without png)

@taoyl-ms
Copy link
Contributor Author

I'll take a look on the neighbor port part.

@taoyl-ms
Copy link
Contributor Author

@lguohan Please review commit 2.

@taoyl-ms taoyl-ms merged commit 0873422 into sonic-net:master Feb 25, 2017
lguohan added a commit to lguohan/sonic-buildimage that referenced this pull request Sep 20, 2018
swss:

* 13df5a9 2018-09-19 | [cfgmgr]: Add vrfmgrd (sonic-net#621) (HEAD, origin/master, origin/HEAD) [Marian Pritsak]
* 54a7c9a 2018-09-18 | [portsorch]: Remove m_ifindex from Port class (sonic-net#624) [Shuotian Cheng]
* e765c12 2018-09-17 | [aclorch]: Remove error message when match not found (sonic-net#618) [stepanblyschak]
* 07f4cd8 2018-09-14 | Enable vxlan test (sonic-net#620) [pavel-shirshov]
* 9fda944 2018-09-14 | Warm reboot: Add support for orchagent pre-shutdown warm-restart state check (sonic-net#562) [Jipan Yang]
* 41e61bd 2018-09-14 | Warm reboot: port state sync up (sonic-net#557) [Jipan Yang]
* bf38bec 2018-09-14 | [vxlan tunnel]: Don't create encap mapper. Currently not supported (sonic-net#613) [pavel-shirshov]
* 528295d 2018-09-14 | [mirrororch]: Remove the queue initialization for different platforms (sonic-net#614) [Shuotian Cheng]
* 5af88ab 2018-09-14 | Temporarily disable two test cases to unblock others (sonic-net#617) [Qi Luo]
* 60a9d61 2018-09-08 | Support warm-restart for neighsyncd (sonic-net#599) [zhenggen-xu]
* 387eac6 2018-09-08 | [mirrororch]: Change Mellanox GRE type to 0x8949 (sonic-net#610) [Shuotian Cheng]
* 7114352 2018-09-07 |  Store mirror session state in StateDB (sonic-net#609) [Qi Luo]
* fa2b5d9 2018-09-06 | [test]: Mark VLAN related mirror test invalid in Debian Jessie (sonic-net#608) [Shuotian Cheng]
* 6d40d85 2018-09-06 | [mirrororch]: Fix bug: return false when SAI API call fails (sonic-net#607) [Shuotian Cheng]
* cbc5a05 2018-09-05 | [mirrororch]: Enable mirror session destination to point into VLAN (sonic-net#595) [Shuotian Cheng]

swss-common:

* c6c9a9b 2018-09-19 | Add new macro STATE_FDB_TABLE_NAME (sonic-net#233) (HEAD, origin/master, origin/HEAD) [Qi Luo]
* 41b6e18 2018-09-13 | NotificationProducer.send() returns the number of clients that received the message (sonic-net#231) [Qi Luo]

sairedis:

* 5ef97ca 2018-09-11 | Fix findBridgeVlanForPortVlan for 1Q bridge (sonic-net#345) (HEAD) [Qi Luo]
* e402ff6 2018-09-11 | update SAI header (sonic-net#344) [lguohan]
* fd75e54 2018-09-11 | sairedis: add while loop to make syncd processEvent() handle as many entries as possible in one event call (sonic-net#335) [Dong Zhang]
* 50e1915 2018-08-29 | [misc]: Fix typos (sonic-net#342) [Shuotian Cheng]
* 2322375 2018-08-29 | Use syncd -u option (sonic-net#341) [Qi Luo]
* 2c2a13c 2018-08-28 | Cleanup usage (sonic-net#340) [Qi Luo]
* 7cd75c0 2018-08-26 | [saimeta]: Fix typo: > then -> >; don't exists -> doesn't exist (sonic-net#339) [Shuotian Cheng]

Signed-off-by: Guohan Lu <gulv@microsoft.com>
lguohan added a commit that referenced this pull request Sep 21, 2018
swss:

* 13df5a9 2018-09-19 | [cfgmgr]: Add vrfmgrd (#621) (HEAD, origin/master, origin/HEAD) [Marian Pritsak]
* 54a7c9a 2018-09-18 | [portsorch]: Remove m_ifindex from Port class (#624) [Shuotian Cheng]
* e765c12 2018-09-17 | [aclorch]: Remove error message when match not found (#618) [stepanblyschak]
* 07f4cd8 2018-09-14 | Enable vxlan test (#620) [pavel-shirshov]
* 9fda944 2018-09-14 | Warm reboot: Add support for orchagent pre-shutdown warm-restart state check (#562) [Jipan Yang]
* 41e61bd 2018-09-14 | Warm reboot: port state sync up (#557) [Jipan Yang]
* bf38bec 2018-09-14 | [vxlan tunnel]: Don't create encap mapper. Currently not supported (#613) [pavel-shirshov]
* 528295d 2018-09-14 | [mirrororch]: Remove the queue initialization for different platforms (#614) [Shuotian Cheng]
* 5af88ab 2018-09-14 | Temporarily disable two test cases to unblock others (#617) [Qi Luo]
* 60a9d61 2018-09-08 | Support warm-restart for neighsyncd (#599) [zhenggen-xu]
* 387eac6 2018-09-08 | [mirrororch]: Change Mellanox GRE type to 0x8949 (#610) [Shuotian Cheng]
* 7114352 2018-09-07 |  Store mirror session state in StateDB (#609) [Qi Luo]
* fa2b5d9 2018-09-06 | [test]: Mark VLAN related mirror test invalid in Debian Jessie (#608) [Shuotian Cheng]
* 6d40d85 2018-09-06 | [mirrororch]: Fix bug: return false when SAI API call fails (#607) [Shuotian Cheng]
* cbc5a05 2018-09-05 | [mirrororch]: Enable mirror session destination to point into VLAN (#595) [Shuotian Cheng]

swss-common:

* c6c9a9b 2018-09-19 | Add new macro STATE_FDB_TABLE_NAME (#233) (HEAD, origin/master, origin/HEAD) [Qi Luo]
* 41b6e18 2018-09-13 | NotificationProducer.send() returns the number of clients that received the message (#231) [Qi Luo]

sairedis:

* 5ef97ca 2018-09-11 | Fix findBridgeVlanForPortVlan for 1Q bridge (#345) (HEAD) [Qi Luo]
* e402ff6 2018-09-11 | update SAI header (#344) [lguohan]
* fd75e54 2018-09-11 | sairedis: add while loop to make syncd processEvent() handle as many entries as possible in one event call (#335) [Dong Zhang]
* 50e1915 2018-08-29 | [misc]: Fix typos (#342) [Shuotian Cheng]
* 2322375 2018-08-29 | Use syncd -u option (#341) [Qi Luo]
* 2c2a13c 2018-08-28 | Cleanup usage (#340) [Qi Luo]
* 7cd75c0 2018-08-26 | [saimeta]: Fix typo: > then -> >; don't exists -> doesn't exist (#339) [Shuotian Cheng]

Signed-off-by: Guohan Lu <gulv@microsoft.com>
lguohan added a commit to lguohan/sonic-buildimage that referenced this pull request Oct 14, 2018
* 6d00d14 2018-10-13 | pfcwd cmd check (sonic-net#342) (HEAD, origin/master, origin/HEAD) [Wenda Ni]
* eb92560 2018-10-12 | [show] Refactor show vlan brief to use configdb and update the output (sonic-net#340) [Deva Nandhagopal]
* 9a139ab 2018-10-10 | Remove explicit dependency on tabulate; Add comments (sonic-net#336) [Joe LeVeque]
* 7874b8f 2018-10-09 | Update restart_count to restore_count for warm restart (sonic-net#326) [Jipan Yang]
* 7a51a85 2018-10-08 | [acl_loader] fix show acl table  (sonic-net#329) [ironjosh]
* 54ebfc8 2018-10-05 | Add a "-l/--load-sysinfo" option for "config reload" to merge the system info on device (sonic-net#324) [zhenggen-xu]
* 34810df 2018-10-05 | [show] Eliminate need for writing template files for 'show platform summary' and 'show version' (sonic-net#335) [Joe LeVeque]
* 4258287 2018-10-05 | Added argument forwarder for platform reboot. (sonic-net#333) [Nazarii Hnydyn]
* e2b4bd5 2018-10-03 | Warm reboot: Add support for docker upgrade (sonic-net#292) [Jipan Yang]
* f1236aa 2018-10-01 | Root priviliege for ecn configuration set commands (sonic-net#332) [Wenda Ni]
* 3098b8a 2018-10-01 | require root privilege for all pfcwd configuration commands (sonic-net#330) [lguohan]
* 7627d08 2018-09-27 | [config]: Add portchannel related commands (sonic-net#328) [Shuotian Cheng]
* b8a62d7 2018-09-27 | Add 'alias mode' support for show commands (sonic-net#298) [paavaanan]
* 4383300 2018-09-26 | [aclshow]: Fix the KeyError issue in aclshow (sonic-net#325) [Shuotian Cheng]

Signed-off-by: Guohan Lu <gulv@microsoft.com>
lguohan added a commit that referenced this pull request Oct 14, 2018
* 6d00d14 2018-10-13 | pfcwd cmd check (#342) (HEAD, origin/master, origin/HEAD) [Wenda Ni]
* eb92560 2018-10-12 | [show] Refactor show vlan brief to use configdb and update the output (#340) [Deva Nandhagopal]
* 9a139ab 2018-10-10 | Remove explicit dependency on tabulate; Add comments (#336) [Joe LeVeque]
* 7874b8f 2018-10-09 | Update restart_count to restore_count for warm restart (#326) [Jipan Yang]
* 7a51a85 2018-10-08 | [acl_loader] fix show acl table  (#329) [ironjosh]
* 54ebfc8 2018-10-05 | Add a "-l/--load-sysinfo" option for "config reload" to merge the system info on device (#324) [zhenggen-xu]
* 34810df 2018-10-05 | [show] Eliminate need for writing template files for 'show platform summary' and 'show version' (#335) [Joe LeVeque]
* 4258287 2018-10-05 | Added argument forwarder for platform reboot. (#333) [Nazarii Hnydyn]
* e2b4bd5 2018-10-03 | Warm reboot: Add support for docker upgrade (#292) [Jipan Yang]
* f1236aa 2018-10-01 | Root priviliege for ecn configuration set commands (#332) [Wenda Ni]
* 3098b8a 2018-10-01 | require root privilege for all pfcwd configuration commands (#330) [lguohan]
* 7627d08 2018-09-27 | [config]: Add portchannel related commands (#328) [Shuotian Cheng]
* b8a62d7 2018-09-27 | Add 'alias mode' support for show commands (#298) [paavaanan]
* 4383300 2018-09-26 | [aclshow]: Fix the KeyError issue in aclshow (#325) [Shuotian Cheng]

Signed-off-by: Guohan Lu <gulv@microsoft.com>
Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this pull request Sep 12, 2019
…ummary' and 'show version' (sonic-net#335)

- Eliminate the need to write template files to disk in both "show platform summary" and "show version"
- Now catching exception if we cannot retrieve HwSKU from ConfigDB and display "Unknown" as result
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
Software PFC WD does not implement polling anymore
It registers .lua plugins in syncd and subscribes to
notifications from plugins

Signed-off-by: marian-pritsak <marianp@mellanox.com>
abdosi added a commit that referenced this pull request Apr 20, 2020
[DBConnector] Add methods to set/get Redis client name (#335)
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020
[DBConnector] Add methods to set/get Redis client name (sonic-net#335)
dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020
…entries as possible in one event call (sonic-net#335)

* sairedis: add while loop to make syncd processEvent() handle as many entries as possible in one event call
* add while() loop to handle entries when buffer is Not empty
* this change has dependency on the added empty() function in ConsumerTableBase class in swss-common which is submitted in other request
* with the changes in swss-common, route performance improved about ~200 routes/sec
*   sairedis: update SWSS_LOG_INFO to SWSS_LOG_DEBUG
  * update SWSS_LOG_INFO to SWSS_LOG_DEBUG
sg893052 pushed a commit to sg893052/sonic-buildimage that referenced this pull request Apr 25, 2022
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Apr 10, 2023
Update sonic-platform-daemons submodule pointer to include the following:
* d1203ef Update xcvrd to use new STATE_DB FAST_REBOOT entry ([sonic-net#335](sonic-net/sonic-platform-daemons#335))

Signed-off-by: dprital <drorp@nvidia.com>
liat-grozovik pushed a commit that referenced this pull request Apr 13, 2023
Update sonic-platform-daemons submodule pointer to include the following:
* d1203ef Update xcvrd to use new STATE_DB FAST_REBOOT entry ([#335](sonic-net/sonic-platform-daemons#335))

Signed-off-by: dprital <drorp@nvidia.com>
mlok-nokia pushed a commit to mlok-nokia/sonic-buildimage that referenced this pull request Jun 5, 2024
Add dependency for tsa_enabled flag before populating peer config and…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants