Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DELL] S6100, Z9100 Last Reboot Reason Watchdog, Thermal Support #3479

Closed
wants to merge 2 commits into from
Closed

[DELL] S6100, Z9100 Last Reboot Reason Watchdog, Thermal Support #3479

wants to merge 2 commits into from

Conversation

sridhar-ravindran
Copy link
Contributor

- What I did
Added support for Watchdog & Thermal events in Last Reboot Reason "show reboot-cause" command
- How I did it
Changes to be committed:
(use "git reset HEAD ..." to unstage)

modified:   files/image_config/platform/rc.local
modified:   platform/broadcom/sonic-platform-modules-dell/debian/platform-modules-s6100.install
modified:   platform/broadcom/sonic-platform-modules-dell/debian/platform-modules-z9100.install
new file:   platform/broadcom/sonic-platform-modules-dell/s6100/scripts/platform_plugin
modified:   platform/broadcom/sonic-platform-modules-dell/s6100/scripts/platform_reboot_override
modified:   platform/broadcom/sonic-platform-modules-dell/s6100/scripts/s6100_platform.sh
new file:   platform/broadcom/sonic-platform-modules-dell/s6100/scripts/track_reboot_reason.sh
modified:   platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/chassis.py
new file:   platform/broadcom/sonic-platform-modules-dell/z9100/scripts/platform_plugin
modified:   platform/broadcom/sonic-platform-modules-dell/z9100/scripts/platform_reboot_override
new file:   platform/broadcom/sonic-platform-modules-dell/z9100/scripts/track_reboot_reason.sh
modified:   platform/broadcom/sonic-platform-modules-dell/z9100/scripts/z9100_platform.sh
modified:   platform/broadcom/sonic-platform-modules-dell/z9100/sonic_platform/chassis.py

Added support to track watchdog events and thermal overload of ASIC & CPU
- How to verify it
Added the Unit Test Results for all reboot reasons
- Description for the changelog

[DELL] S6100, Z9100 Last Reboot Reason Watchdog, Thermal Support

- A picture of a cute animal (not mandatory but encouraged)

@sridhar-ravindran
Copy link
Contributor Author

LRR_UnitTesting_S6100.txt
LRR_UnitTesting_Z9100.txt

@sujinmkang sujinmkang self-assigned this Sep 24, 2019
@sujinmkang
Copy link
Collaborator

@sridhar-ravindran I checked reboot-cause with the build here but software reboot reason seems not working even I tried several time. Can you please double check all other reboot reason is working along with watchdog and hw reboot reason?

@sujinmkang
Copy link
Collaborator

'''
Oct 4 22:45:18.611062 str-z9100-acs-2 INFO systemd[1]: Starting LSB: Execute the kexec -e command to reboot system...
Oct 4 22:45:18.650619 str-z9100-acs-2 INFO systemd[1]: Started LSB: Execute the kexec -e command to reboot system.
Oct 4 22:45:21.305600 str-z9100-acs-2 INFO process-reboot-cause[927]: Traceback (most recent call last):
Oct 4 22:45:21.305835 str-z9100-acs-2 INFO process-reboot-cause[927]: File "/usr/bin/process-reboot-cause", line 136, in
Oct 4 22:45:21.306062 str-z9100-acs-2 INFO process-reboot-cause[927]: main()
Oct 4 22:45:21.306279 str-z9100-acs-2 INFO process-reboot-cause[927]: File "/usr/bin/process-reboot-cause", line 77, in main
Oct 4 22:45:21.306494 str-z9100-acs-2 INFO process-reboot-cause[927]: platform = sonic_platform.platform.Platform()
Oct 4 22:45:21.306714 str-z9100-acs-2 INFO process-reboot-cause[927]: File "/usr/local/lib/python2.7/dist-packages/sonic_platform/platform.py", line 25, in init
Oct 4 22:45:21.306929 str-z9100-acs-2 INFO process-reboot-cause[927]: self._chassis = Chassis()
Oct 4 22:45:21.307143 str-z9100-acs-2 INFO process-reboot-cause[927]: File "/usr/local/lib/python2.7/dist-packages/sonic_platform/chassis.py", line 119, in init
Oct 4 22:45:21.307371 str-z9100-acs-2 INFO process-reboot-cause[927]: self._component_name_list.append(COMPONENT_BIOS)
Oct 4 22:45:21.307585 str-z9100-acs-2 INFO process-reboot-cause[927]: AttributeError: 'Chassis' object has no attribute '_component_name_list'
Oct 4 22:45:22.064487 str-z9100-acs-2 INFO process-reboot-cause: Starting up...
Oct 4 22:45:22.064786 str-z9100-acs-2 NOTICE systemd[1]: process-reboot-cause.service: Main process exited, code=exited, status=1/FAILURE
Oct 4 22:45:22.065380 str-z9100-acs-2 NOTICE systemd[1]: process-reboot-cause.service: Unit entered failed state.
Oct 4 22:45:22.065997 str-z9100-acs-2 WARNING systemd[1]: process-reboot-cause.service: Failed with result 'exit-code'.
'''

@sujinmkang
Copy link
Collaborator

@sridhar-ravindran can we have this PR updated based on PR3698 ?

@sridhar-ravindran
Copy link
Contributor Author

Hi,
We have raised #3767 with updated code changes to support this feature in master. Request you to review the same.

mssonicbld added a commit that referenced this pull request Sep 4, 2024
@mssonicbld
[submodule] Update submodule sonic-utilities to the latest HEAD autom…
7cb7e79 
…atically (#20122)

#### Why I did it
src/sonic-utilities
```
* d29b8241 - (HEAD -> master, origin/master, origin/HEAD) Revert "[wol] Implement wol command line utility" (#3515) (3 hours ago) [Wenda Chu]
* 9357c45f - [chassis][cli] Fix config chassis module startup/shutdown command for fabric module (#3483) (9 hours ago) [Marty Y. Lok]
* 4c7e54a9 - [qos reload] Fix "config qos reload" overriding entire CONFIG_DB (#3479) (18 hours ago) [Stepan Blyshchak]
* 544584ea - Add back the option f to the reboot script (#3492) (18 hours ago) [DavidZagury]
* dc955e80 - [Mellanox] Add CMIS Host Management Files to 'show techsupport' Dumps (#3501) (18 hours ago) [Tomer Shalvi]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Sep 7, 2024
@mssonicbld
[submodule] Update submodule sonic-utilities to the latest HEAD autom…
0e0006f 
…atically (#20188)

#### Why I did it
src/sonic-utilities
```
* 3a0575c2 - (HEAD -> 202405, origin/202405) Add back the option f to the reboot script (#3492) (4 hours ago) [DavidZagury]
* 60c14df8 - Enable show interfacess counters on chassis supervisor (#3488) (4 hours ago) [Changrong Wu]
* cbbfe7b7 - [chassis][cli] Fix config chassis module startup/shutdown command for fabric module (#3483) (4 hours ago) [Marty Y. Lok]
* b6cbe6ed - Remove redundant mmuconfig file (#3446) (4 hours ago) [HP]
* fb6dd589 - [qos reload] Fix "config qos reload" overriding entire CONFIG_DB (#3479) (4 hours ago) [Stepan Blyshchak]
* 9da5db58 - Skip default lanes dup check (#3489) (4 hours ago) [Xincun Li]
* edde02ce - [Mellanox] Add CMIS Host Management Files to 'show techsupport' Dumps (#3501) (4 hours ago) [Tomer Shalvi]
```
#### How I did it
#### How to verify it
#### Description for the changelog
vvolam pushed a commit to vvolam/sonic-buildimage that referenced this pull request Sep 12, 2024
@mssonicbld @vvolam
[submodule] Update submodule sonic-utilities to the latest HEAD autom…
20810e8 
…atically (sonic-net#20122)

#### Why I did it
src/sonic-utilities
```
* d29b8241 - (HEAD -> master, origin/master, origin/HEAD) Revert "[wol] Implement wol command line utility" (sonic-net#3515) (3 hours ago) [Wenda Chu]
* 9357c45f - [chassis][cli] Fix config chassis module startup/shutdown command for fabric module (sonic-net#3483) (9 hours ago) [Marty Y. Lok]
* 4c7e54a9 - [qos reload] Fix "config qos reload" overriding entire CONFIG_DB (sonic-net#3479) (18 hours ago) [Stepan Blyshchak]
* 544584ea - Add back the option f to the reboot script (sonic-net#3492) (18 hours ago) [DavidZagury]
* dc955e80 - [Mellanox] Add CMIS Host Management Files to 'show techsupport' Dumps (sonic-net#3501) (18 hours ago) [Tomer Shalvi]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sujinmkang sujinmkang

Labels
Enhancement ➕ Platform: DellEMC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sridhar-ravindran @sujinmkang @jleveque