Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DellEMC] S6100 Last Reboot Reason Thermal Support #3767

Merged
merged 8 commits into from
Feb 18, 2020

Conversation

santhosh-kt
Copy link
Contributor

@santhosh-kt santhosh-kt commented Nov 15, 2019

- What I did

  • Added support for Thermal event in Last Reboot Reason "show reboot-cause" command.
    Updated:
  • Handled dependency based changes(Between process-reboot-cause and s6100_platform.sh).
  • Handled newer bios based changes(holding previous reset register values and retrieve them in case of secondary bios boot).

- How I did it
On branch sonic-s6100-lrr
Changes to be committed:
(use "git reset HEAD ..." to unstage)

    modified:   files/image_config/platform/rc.local
    new file:   platform/broadcom/sonic-platform-modules-dell/common/nvram_rd_wr.py
    modified:   platform/broadcom/sonic-platform-modules-dell/debian/platform-modules-s6100.install
    new file:   platform/broadcom/sonic-platform-modules-dell/s6100/scripts/fast-reboot_plugin
    modified:   platform/broadcom/sonic-platform-modules-dell/s6100/scripts/platform_reboot_override
    modified:   platform/broadcom/sonic-platform-modules-dell/s6100/scripts/s6100_platform.sh
    new file:   platform/broadcom/sonic-platform-modules-dell/s6100/scripts/track_reboot_reason.sh
    new file:   platform/broadcom/sonic-platform-modules-dell/s6100/scripts/warm-reboot_plugin
    modified:   platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/chassis.py
    modified:   platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/eeprom.py
    new file:   platform/broadcom/sonic-platform-modules-dell/s6100/systemd/s6100-reboot-cause.service

- How to verify it
Added the Unit Test Results.

All Test case result.txt - Updated
Secondary bios boot - test results.txt
Unit test - Last Reboot Reason - S6100.txt - Updated
environment.txt

- Description for the changelog

[DellEMC] S6100 Last Reboot Reason Thermal Support and Dependency based changes

Depends on Azure/sonic-utilities#740
DO NOT MERGE UNTIL ABOVE PR IS MERGED
Update: sonic-net/sonic-utilities#740 is merged.

- A picture of a cute animal (not mandatory but encouraged)

@santhosh-kt
Copy link
Contributor Author

sonic-net/sonic-utilities#740 PR is merged. Please review the above changes.

@sujinmkang
Copy link
Collaborator

retest this please

@santhosh-kt
Copy link
Contributor Author

Internal discussion is being taken place, please hold the review till further changes applied to this PR.

@santhosh-kt
Copy link
Contributor Author

retest vsimage please

1 similar comment
@santhosh-kt
Copy link
Contributor Author

retest vsimage please

@santhosh-kt
Copy link
Contributor Author

Added all the changes. Please continue to review the changes.

@santhosh-kt
Copy link
Contributor Author

retest this please

@santhosh-kt
Copy link
Contributor Author

retest broadcom please

@sujinmkang
Copy link
Collaborator

retest this please

@sujinmkang
Copy link
Collaborator

retest vsimage please

Copy link
Collaborator

@sujinmkang sujinmkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please double check the software reboot reason case?
It seems it's not consistently working.
Jan 25 01:01:56.749931 str-s6100-acs-5 INFO process-reboot-cause: /proc/cmdline indicates reboot type: warm-reboot
Jan 25 01:01:56.750580 str-s6100-acs-5 INFO process-reboot-cause: Previous reboot cause: Unknown software reboot

@santhosh-kt
Copy link
Contributor Author

It looks like, sonic-net/sonic-utilities#740 PR is not synced to master branch. s6100-reboot-cause.service requires this PR, that will handle warm-reboot, fast-reboot and reboot cases in 2.0 API.

Attached logs regarding the plugin - warm-reboot.txt

This sonic-net/sonic-utilities#740 PR is already picked in 201911 but not in master yet.

@jleveque
Copy link
Contributor

@santhosh-kt: FYI, sonic-net/sonic-utilities#740 made it into the master branch today with this sonic-utilities submodule update: #4080

files/image_config/platform/rc.local Outdated Show resolved Hide resolved
Updated comments for reboot-cause platform directory
@jleveque
Copy link
Contributor

jleveque commented Feb 4, 2020

Retest vsimage please

sujinmkang
sujinmkang previously approved these changes Feb 5, 2020
@sujinmkang
Copy link
Collaborator

Retest vsimage please

@santhosh-kt santhosh-kt requested a review from jleveque February 7, 2020 10:28
files/image_config/platform/rc.local Outdated Show resolved Hide resolved
@sujinmkang
Copy link
Collaborator

retest vsimage please

@sujinmkang sujinmkang requested a review from jleveque February 18, 2020 01:14
@jleveque jleveque merged commit 2626565 into sonic-net:master Feb 18, 2020
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request Feb 26, 2020
@santhosh-kt
Copy link
Contributor Author

These changes are not ported to 201911 yet. Needed to be ported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants