-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DellEMC] S6100 Last Reboot Reason Thermal Support #3767
Conversation
sonic-net/sonic-utilities#740 PR is merged. Please review the above changes. |
retest this please |
Internal discussion is being taken place, please hold the review till further changes applied to this PR. |
retest vsimage please |
1 similar comment
retest vsimage please |
Added all the changes. Please continue to review the changes. |
retest this please |
retest broadcom please |
retest this please |
retest vsimage please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please double check the software reboot reason case?
It seems it's not consistently working.
Jan 25 01:01:56.749931 str-s6100-acs-5 INFO process-reboot-cause: /proc/cmdline indicates reboot type: warm-reboot
Jan 25 01:01:56.750580 str-s6100-acs-5 INFO process-reboot-cause: Previous reboot cause: Unknown software reboot
platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/eeprom.py
Show resolved
Hide resolved
platform/broadcom/sonic-platform-modules-dell/s6100/scripts/track_reboot_reason.sh
Outdated
Show resolved
Hide resolved
It looks like, sonic-net/sonic-utilities#740 PR is not synced to master branch. s6100-reboot-cause.service requires this PR, that will handle warm-reboot, fast-reboot and reboot cases in 2.0 API. Attached logs regarding the plugin - warm-reboot.txt This sonic-net/sonic-utilities#740 PR is already picked in 201911 but not in master yet. |
@santhosh-kt: FYI, sonic-net/sonic-utilities#740 made it into the master branch today with this sonic-utilities submodule update: #4080 |
platform/broadcom/sonic-platform-modules-dell/s6100/sonic_platform/eeprom.py
Show resolved
Hide resolved
Updated comments for reboot-cause platform directory
Retest vsimage please |
Retest vsimage please |
retest vsimage please |
These changes are not ported to 201911 yet. Needed to be ported. |
- What I did
Updated:
- How I did it
On branch sonic-s6100-lrr
Changes to be committed:
(use "git reset HEAD ..." to unstage)
- How to verify it
Added the Unit Test Results.
All Test case result.txt - Updated
Secondary bios boot - test results.txt
Unit test - Last Reboot Reason - S6100.txt - Updated
environment.txt
- Description for the changelog
[DellEMC] S6100 Last Reboot Reason Thermal Support and Dependency based changes
Depends on Azure/sonic-utilities#740
DO NOT MERGE UNTIL ABOVE PR IS MERGED
Update: sonic-net/sonic-utilities#740 is merged.
- A picture of a cute animal (not mandatory but encouraged)