Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rules] remove leftover --net=host docker run options #4119

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

mykolaf
Copy link
Collaborator

@mykolaf mykolaf commented Feb 6, 2020

Signed-off-by: Mykola Faryma mykolaf@mellanox.com

Fixes #4118
- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
@mykolaf
Copy link
Collaborator Author

mykolaf commented Feb 6, 2020

Needed in 201911 as well

@abdosi abdosi self-requested a review February 6, 2020 23:36
@lguohan lguohan merged commit f8e5305 into sonic-net:master Feb 7, 2020
rlhui pushed a commit that referenced this pull request Feb 9, 2020
Fixes #4118

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
@mykolaf mykolaf deleted the net_host branch February 18, 2020 13:15
pphuchar pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Mar 9, 2020
Fixes sonic-net#4118

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020
Fixes sonic-net#4118

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service reload failure due to multiple "--net" args in 'docker create'
5 participants