Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service reload failure due to multiple "--net" args in 'docker create' #4118

Closed
mykolaf opened this issue Feb 6, 2020 · 4 comments · Fixed by #4119
Closed

Service reload failure due to multiple "--net" args in 'docker create' #4118

mykolaf opened this issue Feb 6, 2020 · 4 comments · Fixed by #4119

Comments

@mykolaf
Copy link
Collaborator

mykolaf commented Feb 6, 2020

Description
A few recent changes introduced an issue with restarting services like nat and mgmt-framework.

The reason is diff decided to specify --net separately, while few services still have this

This causes config reload failure.

Steps to reproduce the issue:

  1. Run image with 3856
  2. Do config reload
  3. Observe Job for nat.service failed because the control process exited with error code

Describe the results you received:

Service restart failure
Log:

Feb  6 14:21:31.314088 mtbc-sonic-01-2410 INFO nat.sh[27859]: Creating new nat container with HWSKU ACS-MSN2410
Feb  6 14:21:31.483881 mtbc-sonic-01-2410 INFO nat.sh[27859]: docker: network "host" is specified multiple times.

Describe the results you expected:

Everything running smooth

Additional information you deem important (e.g. issue happens only occasionally):

Originally observed on 201911 release, should also be in master.
Output of show version:

```

SONiC Software Version: SONiC.HEAD.28-d192e0c9
Distribution: Debian 9.11
Kernel: 4.9.0-9-2-amd64
Build commit: d192e0c
Build date: Wed Feb 5 04:39:37 UTC 2020
Built by: johnar@jenkins-worker-8

```

**Attach debug file `sudo generate_dump`:**

```
(paste your output here)
```
@mykolaf
Copy link
Collaborator Author

mykolaf commented Feb 6, 2020

@lguohan This one blocks our regression testing. Could you please take a look at fix I provided? #4119
The fix is needed in 201911 as well.

@abdosi
Copy link
Contributor

abdosi commented Feb 6, 2020

@mykolaf Changes are fine in PR.

lguohan pushed a commit that referenced this issue Feb 7, 2020
Fixes #4118

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
rlhui pushed a commit that referenced this issue Feb 9, 2020
Fixes #4118

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
pphuchar pushed a commit to SONIC-DEV/sonic-buildimage that referenced this issue Mar 9, 2020
Fixes sonic-net#4118

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this issue Apr 24, 2020
Fixes sonic-net#4118

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
@flyover-26
Copy link

Has this problem solved?
I got the same problem.
docker:network "host" is specified multiple times

1 similar comment
@flyover-26
Copy link

Has this problem solved?
I got the same problem.
docker:network "host" is specified multiple times

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants