[mellanox]: Align platform API: change CPLD version representation #4221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Retest vsimage please |
|
LGTM. @sujinmkang to review, also. |
stephenxs
reviewed
Mar 6, 2020
platform/mellanox/mlnx-platform-api/sonic_platform/component.py
Outdated
Show resolved
Hide resolved
stephenxs
reviewed
Mar 6, 2020
platform/mellanox/mlnx-platform-api/sonic_platform/component.py
Outdated
Show resolved
Hide resolved
stephenxs
previously approved these changes
Mar 12, 2020
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
…resentation. Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
nazariig
force-pushed
the
master-cpld-api
branch
from
97eb31f
to
4a633b1
Compare
|
retest vsimage please |
|
Retest vsimage please |
jleveque
approved these changes
Mar 23, 2020
abdosi
pushed a commit
that referenced
this pull request
Mar 24, 2020
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new CPLD version representation for Mellanox platforms:
CPLD<part_number>_REV<major_version><minor_version>
part_number - six digits
major_version - two digits
minor_version - two digits
Example:
CPLD000000_REV0500Note: if Part Number or Minor Version is missing, zeros will be printed
- What I did
- How I did it
- How to verify it
- Description for the changelog
- Previous fwutil output
root@sonic:/home/admin# fwutil show status Chassis Module Component Version Description ---------------------- -------- ----------- ----------------------- --------------------------------------- x86_64-mlnx_msn3800-r0 N/A BIOS 0ACLH004_02.02.003_9600 BIOS - Basic Input/Output System CPLD 5.3.3.1 CPLD - includes all CPLDs in the switch- New fwutil output
root@sonic:/home/admin# fwutil show status Chassis Module Component Version Description ---------------------- -------- ----------- ------------------------ --------------------------------------- x86_64-mlnx_msn3800-r0 N/A BIOS 0ACLH004_02.02.003_9600 BIOS - Basic Input/Output System CPLD1 CPLD000000_REV0500 CPLD - Complex Programmable Logic Device CPLD2 CPLD000000_REV0300 CPLD - Complex Programmable Logic Device CPLD3 CPLD000000_REV0300 CPLD - Complex Programmable Logic Device CPLD4 CPLD000000_REV0100 CPLD - Complex Programmable Logic Device- A picture of a cute animal (not mandatory but encouraged)
.---. .----------- / \ __ / ------ / / \( )/ ----- ////// ' \/ ` --- //// / // : : --- // / / /` '-- // //..\\ ====UU====UU==== '//||\\` ''``