-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fwutil]: Fix component table layout #831
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
previously approved these changes
Mar 4, 2020
liat-grozovik
previously approved these changes
Mar 4, 2020
Retest this please |
retest this please |
2 similar comments
retest this please |
retest this please |
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
nazariig
force-pushed
the
master-fwutil-lib-bugfix
branch
from
March 23, 2020 11:32
7e4253d
to
455b731
Compare
retest this please |
@jleveque please review & merge |
liat-grozovik
approved these changes
Mar 24, 2020
jleveque
approved these changes
Mar 24, 2020
abdosi
pushed a commit
that referenced
this pull request
Mar 24, 2020
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
abdosi
pushed a commit
to abdosi/sonic-utilities
that referenced
this pull request
Aug 4, 2020
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nazarii Hnydyn nazariig@mellanox.com
This PR contains a fix for component table layout
in case chassis/module has more than one component
- What I did
- How I did it
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)