Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fwutil]: Fix component table layout #831

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

nazariig
Copy link
Collaborator

@nazariig nazariig commented Mar 4, 2020

Signed-off-by: Nazarii Hnydyn nazariig@mellanox.com

This PR contains a fix for component table layout
in case chassis/module has more than one component

- What I did

  • Fixed component table layout

- How I did it

  • N/A

- How to verify it

  1. Show platform component status
show platform firmware
  1. Run platform component automatic update
config platform firmware update

- Previous command output (if the output of a command-line utility has changed)

root@sonic:/home/admin# fwutil update
Error: ''. Aborting...
Aborted!

- New command output (if the output of a command-line utility has changed)

root@sonic:/home/admin# fwutil show status
Chassis                 Module    Component    Version                  Description
----------------------  --------  -----------  -----------------------  ----------------------------------------
x86_64-mlnx_msn3800-r0  N/A       BIOS         0ACLH004_02.02.007_9600  BIOS - Basic Input/Output System
                                  CPLD1        CPLD000000_REV0500       CPLD - Complex Programmable Logic Device
                                  CPLD2        CPLD000000_REV0300       CPLD - Complex Programmable Logic Device
                                  CPLD3        CPLD000000_REV0300       CPLD - Complex Programmable Logic Device
                                  CPLD4        CPLD000000_REV0100       CPLD - Complex Programmable Logic Device

jleveque
jleveque previously approved these changes Mar 4, 2020
liat-grozovik
liat-grozovik previously approved these changes Mar 4, 2020
@jleveque
Copy link
Contributor

jleveque commented Mar 5, 2020

Retest this please

@liat-grozovik
Copy link
Collaborator

retest this please

2 similar comments
@nazariig
Copy link
Collaborator Author

retest this please

@liat-grozovik
Copy link
Collaborator

retest this please

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
@nazariig
Copy link
Collaborator Author

retest this please

@nazariig
Copy link
Collaborator Author

@jleveque please review & merge

@jleveque jleveque merged commit 30adcbd into sonic-net:master Mar 24, 2020
abdosi pushed a commit that referenced this pull request Mar 24, 2020
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
abdosi pushed a commit to abdosi/sonic-utilities that referenced this pull request Aug 4, 2020
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants