[redis]: Disable snapshotting completely #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To address issue sonic-net/SONiC#59 |
lguohan
reviewed
Mar 31, 2017
| RUN sed -ri 's/^daemonize yes$/daemonize no/; \ | ||
| RUN sed -ri 's/^save 900 1$/# save 900 1/; \ | ||
| s/^save 300 10$/# save 300 10/; \ | ||
| s/^save 60 10000$/# save 60 10000/; \ |
There was a problem hiding this comment.
sed 's/^\(save .*$\)/#\1/g'
There was a problem hiding this comment.
ok. with -r no need to have '\' before brackets
lguohan
requested changes
Mar 31, 2017
Signed-off-by: Shuotian Cheng <shuche@microsoft.com>
|
@lguohan updated |
lguohan
approved these changes
Mar 31, 2017
stcheng
pushed a commit
to stcheng/sonic-buildimage
that referenced
this pull request
Jun 13, 2019
sonic-swss: [vnet]: Extend Bitmap VNET test with "remove" flows (sonic-net#900) [vxlanorch] Ambiguous return code for removeNextHopTunnel (sonic-net#880) Address review comment: remove data member m_entriesCreated, which is introduced for dependancy resolution purpose. (sonic-net#839) Set LAG mtu value based on kernel netlink msg (sonic-net#922) [orchagent]: Remove try/catch for correct coredump file (sonic-net#790) [aclorch] unittest by gtest (sonic-net#924) [orchagent]: Added support of PFC WD for BFN platform (sonic-net#823) [vnetorch]: Fix tunnel route removal flow for bitmap VNET (sonic-net#912) pkill -9 zebra for frr warm restart VS test fix (sonic-net#927) swss-orchagent: add new orch for vnet routes/tunnel routes tables in CONFIG_DB (sonic-net#907) [debian]: Do not build test when building with real SAI (sonic-net#932) sonic-swss-common: Add schema for dot1p to tc mapping config table (sonic-net#274) Fix MIRROR_SESSION table macro name (sonic-net#264) [schema] Add VNET Route tables in config_db (sonic-net#279) [debian] increment debian compatibility to 10 to enable parallel package build (sonic-net#280) White-list clear_stats op from orchagent to syncd (sonic-net#281) Correct comment (sonic-net#282) sonic-sairedis: [debian]: Change build order in target binary (sonic-net#452) [debian] increment debian compatibility to 10 to enable parallel package build (sonic-net#461) Full sleep wait flex counter polling thread when POLL_COUNTER_STATUS is disable (sonic-net#462) add support for SAI_ATTR_VALUE_TYPE_ACL_CAPABILITY (sonic-net#460) Check if port VID exists in db on flex counter query (sonic-net#464) Full sleep wait change for PFC watchdog (sonic-net#465) Add synchronous clear_stats operation path (sonic-net#463) Modify sai_create_port to breakout a port for virtual switch (sonic-net#454) Fix typo (sonic-net#467) Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
stcheng
pushed a commit
that referenced
this pull request
Jun 14, 2019
sonic-swss: [vnet]: Extend Bitmap VNET test with "remove" flows (#900) [vxlanorch] Ambiguous return code for removeNextHopTunnel (#880) Address review comment: remove data member m_entriesCreated, which is introduced for dependancy resolution purpose. (#839) Set LAG mtu value based on kernel netlink msg (#922) [orchagent]: Remove try/catch for correct coredump file (#790) [aclorch] unittest by gtest (#924) [orchagent]: Added support of PFC WD for BFN platform (#823) [vnetorch]: Fix tunnel route removal flow for bitmap VNET (#912) pkill -9 zebra for frr warm restart VS test fix (#927) swss-orchagent: add new orch for vnet routes/tunnel routes tables in CONFIG_DB (#907) [debian]: Do not build test when building with real SAI (#932) sonic-swss-common: Add schema for dot1p to tc mapping config table (#274) Fix MIRROR_SESSION table macro name (#264) [schema] Add VNET Route tables in config_db (#279) [debian] increment debian compatibility to 10 to enable parallel package build (#280) White-list clear_stats op from orchagent to syncd (#281) Correct comment (#282) sonic-sairedis: [debian]: Change build order in target binary (#452) [debian] increment debian compatibility to 10 to enable parallel package build (#461) Full sleep wait flex counter polling thread when POLL_COUNTER_STATUS is disable (#462) add support for SAI_ATTR_VALUE_TYPE_ACL_CAPABILITY (#460) Check if port VID exists in db on flex counter query (#464) Full sleep wait change for PFC watchdog (#465) Add synchronous clear_stats operation path (#463) Modify sai_create_port to breakout a port for virtual switch (#454) Fix typo (#467) Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
seiferteric
pushed a commit
to project-arlo/sonic-buildimage
that referenced
this pull request
Oct 14, 2019
* Update src/sonic-sairedis from branch 'broadcom_sonic'
to 9de2a0cd3371723c925341091c3ee9bc6df88527
- Merge 201904 branch to broadcom_sonic branch on Mon Jul 1 13:57:56 PDT 2019
Change-Id: Ibc8bd38f6819bda73ba52fff6358b794f7366d46
- Fix typo (sonic-net#467)
* Rename to fix typo
Signed-off-by: Wenda Ni <wenni@microsoft.com>
* Correct shared_ptr creation parameters
Signed-off-by: Wenda Ni <wenni@microsoft.com>
- Modify sai_create_port to breakout a port for virtual switch (sonic-net#454)
For breakout a port, it needs to support create port and remove port.
When create a port, it needs to init some attributes.
Signed-off-by: chiourung_huang <chiourung_huang@edge-core.com>
- Add synchronous clear_stats operation path (sonic-net#463)
* Send clear_stats op from orchagent to syncd via Redis pipeline
Signed-off-by: Wenda Ni <wenni@microsoft.com>
* Handle clear_stats op in syncd
Signed-off-by: Wenda Ni <wenni@microsoft.com>
* Receive clear_stats op status response from sycnd in orchagent context
Signed-off-by: Wenda Ni <wenni@microsoft.com>
* Shift clear_stats to get synchronous response from ASIC
Signed-off-by: Wenda Ni <wenni@microsoft.com>
* Fix compilation error
Signed-off-by: Wenda Ni <wenni@microsoft.com>
* Fix log message output
Signed-off-by: Wenda Ni <wenni@microsoft.com>
* Remove debugging symbols
Signed-off-by: Wenda Ni <wenni@microsoft.com>
* Remove debugging symbols
Signed-off-by: Wenda Ni <wenni@microsoft.com>
* Change the validation order of KeyOpFieldsValuesTuple responded from
syncd
Signed-off-by: Wenda Ni <wenni@microsoft.com>
* Expand status log utility to include op type as argument
Signed-off-by: Wenda Ni <wenni@microsoft.com>
* Address comments: check if object id is present in local db
Signed-off-by: Wenda Ni <wenni@microsoft.com>
* Leverage newly merged infrastructure to check if object id is present in
the local db
Signed-off-by: Wenda Ni <wenni@microsoft.com>
* Fix compile error
Signed-off-by: Wenda Ni <wenni@microsoft.com>
- Full sleep wait change for PFC watchdog (sonic-net#465)
* Sleep wait change for pfc watchdog, which still has plugins in place so
isEmpty() always returns true.
When issuing 'pfcwd stop' cli to stop PFC watchdog, it only clears the counter id list for physical ports under the hood, leaving lua script plugins still installed and ieEmpty() returns false.
So even when PFC watchdog is stopped, the flex counter thread would wake up every 200 ms.
Jun 4 17:58:51.273413 str-a7050-acs-1 ERR syncd#syncd: :- flexCounterThread: End of flex counter thread FC PFC_WD, took 33 ms
Jun 4 17:58:51.471288 str-a7050-acs-1 ERR syncd#syncd: :- flexCounterThread: End of flex counter thread FC PFC_WD, took 30 ms
Jun 4 17:58:51.672930 str-a7050-acs-1 ERR syncd#syncd: :- flexCounterThread: End of flex counter thread FC PFC_WD, took 31 ms
Jun 4 17:58:51.882972 str-a7050-acs-1 ERR syncd#syncd: :- flexCounterThread: End of flex counter thread FC PFC_WD, took 40 ms
Jun 4 17:58:52.074862 str-a7050-acs-1 ERR syncd#syncd: :- flexCounterThread: End of flex counter thread FC PFC_WD, took 31 ms
This PR is to address the above observation:
Fine granularize the isEmpty() to two functions---isIdsEmpty() and isPluginsEmpty(), and use the emptiness check of the counter id list, isIdsEmpty(), as the criteria for full sleep wait. This approach is generally valid because current flex counter use cases would have the presence of non-empty counter id list to be meaningful, followed by an optional execution of the Lua script plugins if they are installed.
Signed-off-by: Wenda Ni <wenni@microsoft.com>
- Check if port VID exists in db on flex counter query (sonic-net#464)
- add support for SAI_ATTR_VALUE_TYPE_ACL_CAPABILITY (sonic-net#460)
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
- Full sleep wait flex counter polling thread when POLL_COUNTER_STATUS is disable (sonic-net#462)
Signed-off-by: Wenda Ni <wenni@microsoft.com>
- [debian] increment debian compatibility to 10 to enable parallel package build (sonic-net#461)
* fix parallel build
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
* [debian] increment debian compatibility to 10 to enable parallel package
build
From debhelper man pages:
"If neither option is specified, debhelper currently defaults to
--parallel in compat 10 (or later) and --no-parallel otherwise."
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
* make tests run serial
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
- [debian]: Change build order in target binary (sonic-net#452)
Make binary-syncd the last target, so the non-rpc requisites will be available after the first build
It will allow doing incremental builds later on for the main binary type
- Add buffer pool stat to flex counter architecture (sonic-net#451)
- Watermark: test SAI clear api if the stats mode is READ_AND_CLEAR (sonic-net#427)
* Test SAI clear api if the stats mode is READ_AND_CLEAR
Signed-off-by: Wenda <wenni@microsoft.com>
* Address compile error
dmytroxshevchuk
pushed a commit
to dmytroxshevchuk/sonic-buildimage
that referenced
this pull request
Aug 31, 2020
* Send clear_stats op from orchagent to syncd via Redis pipeline Signed-off-by: Wenda Ni <wenni@microsoft.com> * Handle clear_stats op in syncd Signed-off-by: Wenda Ni <wenni@microsoft.com> * Receive clear_stats op status response from sycnd in orchagent context Signed-off-by: Wenda Ni <wenni@microsoft.com> * Shift clear_stats to get synchronous response from ASIC Signed-off-by: Wenda Ni <wenni@microsoft.com> * Fix compilation error Signed-off-by: Wenda Ni <wenni@microsoft.com> * Fix log message output Signed-off-by: Wenda Ni <wenni@microsoft.com> * Remove debugging symbols Signed-off-by: Wenda Ni <wenni@microsoft.com> * Remove debugging symbols Signed-off-by: Wenda Ni <wenni@microsoft.com> * Change the validation order of KeyOpFieldsValuesTuple responded from syncd Signed-off-by: Wenda Ni <wenni@microsoft.com> * Expand status log utility to include op type as argument Signed-off-by: Wenda Ni <wenni@microsoft.com> * Address comments: check if object id is present in local db Signed-off-by: Wenda Ni <wenni@microsoft.com> * Leverage newly merged infrastructure to check if object id is present in the local db Signed-off-by: Wenda Ni <wenni@microsoft.com> * Fix compile error Signed-off-by: Wenda Ni <wenni@microsoft.com>
4 tasks
lguohan
pushed a commit
that referenced
this pull request
Apr 18, 2021
804c9f9 [sonic-swss-common] Add a string utilities function to join items in a container (#463) 1e924ac Fix: ConfigDBConnector call super init with proper parameter name (#470) 70e02c8 [azp] Purge swss before installing the newly built deb package (#472) 15c0f72 [swig] translate SonicV2Connector::keys return type from C++ vector to Python list (#468)
4 tasks
prsunny
pushed a commit
that referenced
this pull request
Apr 21, 2021
*804c9f9 [sonic-swss-common] Add a string utilities function to join items in a container (#463) *1e924ac Fix: ConfigDBConnector call super init with proper parameter name (#470) *70e02c8 [azp] Purge swss before installing the newly built deb package (#472) *15c0f72 [swig] translate SonicV2Connector::keys return type from C++ vector to Python list (#468)
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
May 10, 2021
* [sonic-utilities] managementVRF cli support(l3mdev)
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
804c9f9 [sonic-swss-common] Add a string utilities function to join items in a container (sonic-net#463) 1e924ac Fix: ConfigDBConnector call super init with proper parameter name (sonic-net#470) 70e02c8 [azp] Purge swss before installing the newly built deb package (sonic-net#472) 15c0f72 [swig] translate SonicV2Connector::keys return type from C++ vector to Python list (sonic-net#468)
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
804c9f9 [sonic-swss-common] Add a string utilities function to join items in a container (sonic-net#463) 1e924ac Fix: ConfigDBConnector call super init with proper parameter name (sonic-net#470) 70e02c8 [azp] Purge swss before installing the newly built deb package (sonic-net#472) 15c0f72 [swig] translate SonicV2Connector::keys return type from C++ vector to Python list (sonic-net#468)
mssonicbld
added a commit
that referenced
this pull request
Apr 11, 2024
…D automatically (#18653) #### Why I did it src/sonic-platform-daemons ``` * 8ee3009 - (HEAD -> 202305, origin/202305) [202305] Fix intermittent build failure for test_SfpStateUpdateTask_task_run_stop (#461) (#463) (3 hours ago) [mihirpat1] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shuotian Cheng shuche@microsoft.com