-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docker-teamd]: Clean /etc/teamd/ folder before adding new configurations #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that the folder is not emptied before adding other files. Thus issues occur when moving from one minigraph to another. |
taoyl-ms
reviewed
Mar 28, 2017
dockers/docker-teamd/config.sh
Outdated
@@ -1,6 +1,7 @@ | |||
#!/bin/bash | |||
|
|||
mkdir -p /etc/teamd | |||
rm /etc/teamd/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-f ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
…ions Signed-off-by: Shuotian Cheng <shuche@microsoft.com>
taoyl-ms
approved these changes
Mar 28, 2017
seiferteric
pushed a commit
to project-arlo/sonic-buildimage
that referenced
this pull request
Oct 14, 2019
* Update src/sonic-sairedis from branch 'broadcom_sonic' to 9de2a0cd3371723c925341091c3ee9bc6df88527 - Merge 201904 branch to broadcom_sonic branch on Mon Jul 1 13:57:56 PDT 2019 Change-Id: Ibc8bd38f6819bda73ba52fff6358b794f7366d46 - Fix typo (sonic-net#467) * Rename to fix typo Signed-off-by: Wenda Ni <wenni@microsoft.com> * Correct shared_ptr creation parameters Signed-off-by: Wenda Ni <wenni@microsoft.com> - Modify sai_create_port to breakout a port for virtual switch (sonic-net#454) For breakout a port, it needs to support create port and remove port. When create a port, it needs to init some attributes. Signed-off-by: chiourung_huang <chiourung_huang@edge-core.com> - Add synchronous clear_stats operation path (sonic-net#463) * Send clear_stats op from orchagent to syncd via Redis pipeline Signed-off-by: Wenda Ni <wenni@microsoft.com> * Handle clear_stats op in syncd Signed-off-by: Wenda Ni <wenni@microsoft.com> * Receive clear_stats op status response from sycnd in orchagent context Signed-off-by: Wenda Ni <wenni@microsoft.com> * Shift clear_stats to get synchronous response from ASIC Signed-off-by: Wenda Ni <wenni@microsoft.com> * Fix compilation error Signed-off-by: Wenda Ni <wenni@microsoft.com> * Fix log message output Signed-off-by: Wenda Ni <wenni@microsoft.com> * Remove debugging symbols Signed-off-by: Wenda Ni <wenni@microsoft.com> * Remove debugging symbols Signed-off-by: Wenda Ni <wenni@microsoft.com> * Change the validation order of KeyOpFieldsValuesTuple responded from syncd Signed-off-by: Wenda Ni <wenni@microsoft.com> * Expand status log utility to include op type as argument Signed-off-by: Wenda Ni <wenni@microsoft.com> * Address comments: check if object id is present in local db Signed-off-by: Wenda Ni <wenni@microsoft.com> * Leverage newly merged infrastructure to check if object id is present in the local db Signed-off-by: Wenda Ni <wenni@microsoft.com> * Fix compile error Signed-off-by: Wenda Ni <wenni@microsoft.com> - Full sleep wait change for PFC watchdog (sonic-net#465) * Sleep wait change for pfc watchdog, which still has plugins in place so isEmpty() always returns true. When issuing 'pfcwd stop' cli to stop PFC watchdog, it only clears the counter id list for physical ports under the hood, leaving lua script plugins still installed and ieEmpty() returns false. So even when PFC watchdog is stopped, the flex counter thread would wake up every 200 ms. Jun 4 17:58:51.273413 str-a7050-acs-1 ERR syncd#syncd: :- flexCounterThread: End of flex counter thread FC PFC_WD, took 33 ms Jun 4 17:58:51.471288 str-a7050-acs-1 ERR syncd#syncd: :- flexCounterThread: End of flex counter thread FC PFC_WD, took 30 ms Jun 4 17:58:51.672930 str-a7050-acs-1 ERR syncd#syncd: :- flexCounterThread: End of flex counter thread FC PFC_WD, took 31 ms Jun 4 17:58:51.882972 str-a7050-acs-1 ERR syncd#syncd: :- flexCounterThread: End of flex counter thread FC PFC_WD, took 40 ms Jun 4 17:58:52.074862 str-a7050-acs-1 ERR syncd#syncd: :- flexCounterThread: End of flex counter thread FC PFC_WD, took 31 ms This PR is to address the above observation: Fine granularize the isEmpty() to two functions---isIdsEmpty() and isPluginsEmpty(), and use the emptiness check of the counter id list, isIdsEmpty(), as the criteria for full sleep wait. This approach is generally valid because current flex counter use cases would have the presence of non-empty counter id list to be meaningful, followed by an optional execution of the Lua script plugins if they are installed. Signed-off-by: Wenda Ni <wenni@microsoft.com> - Check if port VID exists in db on flex counter query (sonic-net#464) - add support for SAI_ATTR_VALUE_TYPE_ACL_CAPABILITY (sonic-net#460) Signed-off-by: Stepan Blyschak <stepanb@mellanox.com> - Full sleep wait flex counter polling thread when POLL_COUNTER_STATUS is disable (sonic-net#462) Signed-off-by: Wenda Ni <wenni@microsoft.com> - [debian] increment debian compatibility to 10 to enable parallel package build (sonic-net#461) * fix parallel build Signed-off-by: Stepan Blyschak <stepanb@mellanox.com> * [debian] increment debian compatibility to 10 to enable parallel package build From debhelper man pages: "If neither option is specified, debhelper currently defaults to --parallel in compat 10 (or later) and --no-parallel otherwise." Signed-off-by: Stepan Blyschak <stepanb@mellanox.com> * make tests run serial Signed-off-by: Stepan Blyschak <stepanb@mellanox.com> - [debian]: Change build order in target binary (sonic-net#452) Make binary-syncd the last target, so the non-rpc requisites will be available after the first build It will allow doing incremental builds later on for the main binary type - Add buffer pool stat to flex counter architecture (sonic-net#451) - Watermark: test SAI clear api if the stats mode is READ_AND_CLEAR (sonic-net#427) * Test SAI clear api if the stats mode is READ_AND_CLEAR Signed-off-by: Wenda <wenni@microsoft.com> * Address compile error
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
dmytroxshevchuk
pushed a commit
to dmytroxshevchuk/sonic-buildimage
that referenced
this pull request
Aug 31, 2020
4 tasks
mssonicbld
added a commit
that referenced
this pull request
Mar 22, 2024
…D automatically (#18435) #### Why I did it src/sonic-platform-daemons ``` * fa46abb - (HEAD -> 202311, origin/202311) [ycabled] Fix insert delete events for ycabled OIR by subscribing to TRANSCEIVER_INFO instead of TRANSCEIVER_STATUS table (#442) (4 hours ago) [vdahiya12] * 8c15adb - Disable periodic polling of port in DomInfoUpdateTask thread during CMIS init (#449) (#451) (11 hours ago) [mihirpat1] ``` #### How I did it #### How to verify it #### Description for the changelog
mssonicbld
added a commit
that referenced
this pull request
Apr 26, 2024
… automatically (#18780) #### Why I did it src/sonic-platform-common ``` * 4163365 - (HEAD -> master, origin/master, origin/HEAD) Fetch firmware versions for Cmis Target FW upgrade supported cables (#455) (10 hours ago) [mihirpat1] * df6b6c6 - parse the output from the beginning of the line (#451) (2 days ago) [Kebo Liu] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shuotian Cheng shuche@microsoft.com