[sonic-swss] Advance submodule #6789

nazariig · 2021-02-16T11:12:54Z

Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com

Why I did it

To fix SWSS crash due to invalid CRM operations
To add new cli for SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS
To increase SAI REDIS response timeout to support FW upgrade on Mellanox platforms

How I did it

N/A

How to verify it

Deploy image
Run regression

Which release branch to backport (provide reason below if selected)

201811
201911
202006
202012

Description for the changelog

sonic-swss:

Commits on Feb 04, 2021
Reduce noise during frequent route update (#1624) 5384ace
[cfgmgr]: Integrate MACsecMGR with sonic-buildimage (#1627) c7f27c8

Commits on Feb 05, 2021
[Mux] Route handling based on mux status, kernel tunnel support (#1615) 0b0d24c

Commits on Feb 06, 2021
Fix the compiling errors in gcc9 (#1621) 1438a70

Commits on Feb 07, 2021
Support shared headroom pool on top of dynamic buffer calculation (#1581 5fa2329
[buffermgr] Support maximum port headroom checking (#1607) 189a964

Commits on Feb 08, 2021
[tests] Remove legacy saiattributelist.h dependency (#1608) 6554b5d

Commits on Feb 09, 2021
Migrate serdes programming to port serdes object (#1611) b8193d1

Commits on Feb 10, 2021
Log level change from ERR to INFO for fetch systemports issue (#1632) aaa7bf2
[ci]: use build template (#1633) 8739791

Commits on Feb 11, 2021
[Mux] Neighbor handling based on FDB entry (#1631) 3f11a50

Commits on Feb 12, 2021
[test_virtual_chassis]: use wait_for function to improve test robustness 0dea91c
[ci]: run vstest f9d5959

Commits on Feb 13, 2021
[bufferorch] Handle NOT IMPLEMENTED status returned during set attr o… 32bc1b6

Commits on Feb 14, 2021
spell check fixes (#1630) f2854f8

Commits on Feb 15, 2021
[test_virtual_chassis]: use wait_for to make test more robust (#1640) 1238076
fixed unsupported resource issue (#1641) de03dd7

Commits on Feb 17, 2021
Add SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS counter, create n… 710df0c
Remove useless header in macsecorch (#1628) 459848f
[vstest/subintf] Update vs tests to validate physical port host inter… c49668e
[vstest]: add dvs_route fixture d407bc8
[vstest/nhg]: use dvs_route fixture to make test_nhg more robust 20ee836

Commits on Feb 22, 2021
[orchagent] Increase SAI REDIS response timeout to support FW upgrade… 16cd6c2

Commits on Feb 23, 2021
Updated PFCWD to use single ACL table for PFCWD and MUX (#1620) 97b3913
[acl] Enable VLAN ID qualifier for ACL rules (#1648) 99cfd58 

Commits on Feb 25, 2021
[synchronous mode] Add failure notification for SAI failures in synch… 1d33881

A picture of a cute animal (not mandatory but encouraged)

      .---.        .-----------
     /     \  __  /    ------
    / /     \(  )/    -----
   //////   ' \/ `   ---
  //// / // :    : ---
 // /   /  /`    '--
//          //..\\
       ====UU====UU====
           '//||\\`
             ''``

liat-grozovik · 2021-02-16T15:21:19Z

/AzurePipelines run

azure-pipelines · 2021-02-16T15:21:34Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2021-02-17T17:39:01Z

/AuzrePipelines run

nazariig · 2021-02-18T14:39:39Z

@liat-grozovik the failures are:

kvmtest-t0

    "stderr_lines": [
        "WARNING: No route found for IPv6 destination :: (no default route?)", 
        "  from cryptography.hazmat.backends import default_backend", 
        "advanced-reboot.ReloadTest ... FAIL", 
        "", 
        "======================================================================", 
        "FAIL: advanced-reboot.ReloadTest", 
        "----------------------------------------------------------------------", 
        "Traceback (most recent call last):", 
        "  File \"ptftests/advanced-reboot.py\", line 1079, in runTest", 
        "    self.handle_post_reboot_test_reports()", 
        "  File \"ptftests/advanced-reboot.py\", line 1048, in handle_post_reboot_test_reports", 
        "    self.assertTrue(is_good, errors)", 
        "AssertionError: ", 
        "", 
        "Something went wrong. Please check output below:", 
        "", 
        "FAILED:dut:SSH threads haven't finished for 300 seconds", 
        "", 
        "", 
        "----------------------------------------------------------------------", 
        "Ran 1 test in 551.457s", 
        "", 
        "FAILED (failures=1)"
    ], 
    "stdout": "", 
    "stdout_lines": []
}

2021-02-18T12:46:27.5906291Z =========================== short test summary info ============================
2021-02-18T12:46:27.5907406Z SKIPPED [1] /data/sonic-mgmt/tests/common/fixtures/advanced_reboot.py:47: Testcase not supported for kvm
2021-02-18T12:46:27.5908466Z FAILED platform_tests/test_advanced_reboot.py::test_warm_reboot - RunAnsibleM...
2021-02-18T12:46:27.5909299Z ==================== 1 failed, 1 skipped in 619.02 seconds =====================

kvmtest-t1-lag

Feb 18 12:50:07.128835 vlab-03 ERR monit[466]: \'routeCheck\' status failed (1)
Traceback (most recent call last):
  File "/usr/local/bin/route_check.py", line 463, in <module>
    sys.exit(main()[0])
  File "/usr/local/bin/route_check.py", line 451, in main
    ret, res= check_routes()
  File "/usr/local/bin/route_check.py", line 392, in check_routes
    rt_appl_miss = filter_out_local_interfaces(rt_appl_miss)
  File "/usr/local/bin/route_check.py", line 332, in filter_out_local_interfaces
    e = dict(tbl.get(k.split("/"))[1])
  File "/usr/lib/python3/dist-packages/swsscommon/swsscommon.py", line 2272, in get
    return _swsscommon.Table_get(self, key)
TypeError: in method \'Table_get\', argument 2 of type \'std::string const &\'

2021-02-18T12:51:11.3684340Z =========================== short test summary info ============================
2021-02-18T12:51:11.3685258Z ERROR bgp/test_bgp_allow_list.py::TestBGPAllowListBase::test_allow_list[permit]
2021-02-18T12:51:11.3686067Z ===================== 2 passed, 1 error in 202.56 seconds ======================

liat-grozovik · 2021-02-18T14:53:04Z

Thanks @lguohan can you please notify the failures to feature owners? Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Nazarii Hnydyn <notifications@github.com> Sent: Thursday, February 18, 2021 4:39:56 PM To: Azure/sonic-buildimage <sonic-buildimage@noreply.github.com> Cc: Liat Grozovik <liatg@nvidia.com>; Mention <mention@noreply.github.com> Subject: Re: [Azure/sonic-buildimage] [submodule] Advance swss submodule (#6789) @liat-grozovik<https://github.com/liat-grozovik> the failures are: 1. kvmtest-t0 "stderr_lines": [ "WARNING: No route found for IPv6 destination :: (no default route?)", " from cryptography.hazmat.backends import default_backend", "advanced-reboot.ReloadTest ... FAIL", "", "======================================================================", "FAIL: advanced-reboot.ReloadTest", "----------------------------------------------------------------------", "Traceback (most recent call last):", " File \"ptftests/advanced-reboot.py\", line 1079, in runTest", " self.handle_post_reboot_test_reports()", " File \"ptftests/advanced-reboot.py\", line 1048, in handle_post_reboot_test_reports", " self.assertTrue(is_good, errors)", "AssertionError: ", "", "Something went wrong. Please check output below:", "", "FAILED:dut:SSH threads haven't finished for 300 seconds", "", "", "----------------------------------------------------------------------", "Ran 1 test in 551.457s", "", "FAILED (failures=1)" ], "stdout": "", "stdout_lines": [] } 2021-02-18T12:46:27.5906291Z =========================== short test summary info ============================ 2021-02-18T12:46:27.5907406Z SKIPPED [1] /data/sonic-mgmt/tests/common/fixtures/advanced_reboot.py:47: Testcase not supported for kvm 2021-02-18T12:46:27.5908466Z FAILED platform_tests/test_advanced_reboot.py::test_warm_reboot - RunAnsibleM... 2021-02-18T12:46:27.5909299Z ==================== 1 failed, 1 skipped in 619.02 seconds ===================== 1. kvmtest-t1-lag Feb 18 12:50:07.128835 vlab-03 ERR monit[466]: \'routeCheck\' status failed (1) Traceback (most recent call last): File "/usr/local/bin/route_check.py", line 463, in <module> sys.exit(main()[0]) File "/usr/local/bin/route_check.py", line 451, in main ret, res= check_routes() File "/usr/local/bin/route_check.py", line 392, in check_routes rt_appl_miss = filter_out_local_interfaces(rt_appl_miss) File "/usr/local/bin/route_check.py", line 332, in filter_out_local_interfaces e = dict(tbl.get(k.split("/"))[1]) File "/usr/lib/python3/dist-packages/swsscommon/swsscommon.py", line 2272, in get return _swsscommon.Table_get(self, key) TypeError: in method \'Table_get\', argument 2 of type \'std::string const &\' 2021-02-18T12:51:11.3684340Z =========================== short test summary info ============================ 2021-02-18T12:51:11.3685258Z ERROR bgp/test_bgp_allow_list.py::TestBGPAllowListBase::test_allow_list[permit] 2021-02-18T12:51:11.3686067Z ===================== 2 passed, 1 error in 202.56 seconds ====================== — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#6789 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKTABA55XMG24N557YHSU6DS7URDZANCNFSM4XWIKS7Q>.

liat-grozovik · 2021-02-22T15:11:39Z

/AzurePipelines run

azure-pipelines · 2021-02-22T15:11:53Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2021-02-23T07:39:47Z

@lguohan this submodule update is must because of a critical fix of sonic-net/sonic-swss#1641
as mentioned above there are failures which requires owners. Would you help to assign/name the owner?

liat-grozovik · 2021-02-23T07:42:35Z

/AzurePipelines run

azure-pipelines · 2021-02-23T07:42:50Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2021-02-23T07:43:43Z

Please note that even when stating the pipelines test the kvmtest are not restarted ... Could the Azure build team be notified?

nazariig · 2021-02-23T15:41:31Z

#6843

nazariig · 2021-02-24T08:38:26Z

/AzurePipelines run

azure-pipelines · 2021-02-24T08:38:31Z

Commenter does not have sufficient privileges for PR 6789 in repo Azure/sonic-buildimage

liat-grozovik · 2021-02-24T08:42:40Z

/AzurePipelines run

azure-pipelines · 2021-02-24T08:42:53Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2021-02-25T18:14:34Z

the last fail i can see is related to
breakout/test_breakout_cli.py::TestBreakoutCli::test_breakout_modes FAILED [ 85%]

@jleveque was this seen on another PR recently?

jleveque · 2021-02-25T18:43:31Z

the last fail i can see is related to
breakout/test_breakout_cli.py::TestBreakoutCli::test_breakout_modes FAILED [ 85%]

@jleveque was this seen on another PR recently?

Yes. I did not see this PR and opened another PR to update sonic-utilities here, and it is failing on the same test.

This PR is supposed to fix it: #6831

jleveque · 2021-02-25T18:45:27Z

@nazariig: Shall I keep my PR open to update sonic-utilities and you relegate this PR to swss only, or would you rather update sonic-utilities to the current head in this PR and I close mine?

Also, can you please add a list of the commits included in the submodule updates in your PR description?

nazariig · 2021-02-25T18:56:07Z

@nazariig: Shall I keep my PR open to update sonic-utilities and you relegate this PR to swss only, or would you rather update sonic-utilities to the current head in this PR and I close mine?

Also, can you please add a list of the commits included in the submodule updates in your PR description?

@jleveque done

nazariig · 2021-02-25T18:56:49Z

#6874

jleveque · 2021-02-25T19:26:44Z

Thanks, @nazariig. Can you please add a list of commits include in the swss submodule in the PR description? We will include them in the final commit message.

nazariig · 2021-02-25T20:01:07Z

Thanks, @nazariig. Can you please add a list of commits include in the swss submodule in the PR description? We will include them in the final commit message.

@jleveque you're welcome. It is already there. Please refer to Description for the changelog

jleveque · 2021-02-25T20:04:23Z

@jleveque you're welcome. It is already there. Please refer to Description for the changelog

Ah, yes. Thanks. It's just a bit more verbose than I'm used to, so I missed it. Normally I just copy/paste the info from git status

lguohan · 2021-02-26T08:23:10Z

/azp run

azure-pipelines · 2021-02-26T08:23:21Z

Azure Pipelines successfully started running 1 pipeline(s).

nazariig · 2021-02-28T19:40:16Z

The last t1-lag run:

Feb 28 14:03:53.906606 vlab-03 ERR monit[443]: routeCheck status failed (255) -- Failure results:
    "missed_ROUTE_TABLE_routes": [
        "100.1.0.17/32",
        "100.1.0.18/32",
        "100.1.0.19/32",
        "100.1.0.20/32",
        "100.1.0.21/32",
        "100.1.0.22/32",
        "100.1.0.23/32",
        "100.1.0.24/32",
        "100.1.0.25/32",
        "100.1.0.26/32",
        "100.1.0.27/32",
        "100.1.0.28/32",
        "100.1.0.29/32",
        "100.1.0.30/32",
        "100.1.0.31/32",
        "100.1.0.32/32",
        "172.16.10.0/24",
        "172.16.30.0/24",
        "172.16.50.0/24",
        "192.168.0.0/25",
        "192.168.0.128/25",
        "192.168.104.0/25",
        "192.168.104.128/25",
        "192.168.112.0/25",
        "192.168.112.128/25",
        "192.168.120.0/25",
        "192.168.120.128/25",
    ]

liat-grozovik · 2021-03-01T17:07:39Z

@prsunny could you please check the above failure?

prsunny · 2021-03-01T23:43:35Z

/azp run

azure-pipelines · 2021-03-01T23:43:47Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2021-03-02T08:27:31Z

/AzurePipelines run

azure-pipelines · 2021-03-02T08:27:42Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>

liat-grozovik · 2021-03-10T20:32:50Z

@prsunny I believe this PR should be closed as you are working on having the swss submodule update in stages, right?

prsunny · 2021-03-11T02:42:55Z

@prsunny I believe this PR should be closed as you are working on having the swss submodule update in stages, right?

ok.

nazariig requested a review from lguohan as a code owner February 16, 2021 11:12

nazariig added Bug 🐛 Submodule Update ⏫ and removed Bug 🐛 labels Feb 16, 2021

nazariig requested review from liat-grozovik and volodymyrsamotiy February 16, 2021 11:13

liat-grozovik changed the title ~~[submodule]: Advance swss submodule~~ [submodule] Advance swss submodule Feb 16, 2021

liat-grozovik mentioned this pull request Feb 16, 2021

[submodule] update sonic-swss and sonic-utilities pointers #6743

Closed

4 tasks

liat-grozovik previously approved these changes Feb 16, 2021

View reviewed changes

nazariig dismissed liat-grozovik’s stale review via 835cc3b February 18, 2021 10:13

nazariig force-pushed the master-swss branch from 42c16ce to 835cc3b Compare February 18, 2021 10:13

qiluo-msft previously approved these changes Feb 23, 2021

View reviewed changes

nazariig dismissed qiluo-msft’s stale review via fe43710 February 23, 2021 10:49

nazariig force-pushed the master-swss branch from 835cc3b to fe43710 Compare February 23, 2021 10:49

nazariig changed the title ~~[submodule] Advance swss submodule~~ [submodule] Advance swss/utilities submodule Feb 23, 2021

lguohan force-pushed the master-swss branch from fe43710 to 89bf359 Compare February 23, 2021 21:34

nazariig force-pushed the master-swss branch from c24d4a1 to a11aaf4 Compare February 25, 2021 09:09

nazariig force-pushed the master-swss branch from a11aaf4 to ef6f04a Compare February 25, 2021 18:52

nazariig changed the title ~~[submodule] Advance swss/utilities submodule~~ [submodule] Advance swss submodule Feb 25, 2021

jleveque changed the title ~~[submodule] Advance swss submodule~~ [sonic-swss] Advance submodule Feb 25, 2021

nazariig force-pushed the master-swss branch from ef6f04a to de30846 Compare February 28, 2021 11:05

[submodule]: Advance swss submodule.

ecc9bbf

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>

nazariig force-pushed the master-swss branch from de30846 to ecc9bbf Compare March 9, 2021 16:51

prsunny closed this Mar 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[sonic-swss] Advance submodule #6789

[sonic-swss] Advance submodule #6789

nazariig commented Feb 16, 2021 •

edited

Loading

liat-grozovik commented Feb 16, 2021

azure-pipelines bot commented Feb 16, 2021

liat-grozovik commented Feb 17, 2021

nazariig commented Feb 18, 2021

liat-grozovik commented Feb 18, 2021 via email

liat-grozovik commented Feb 22, 2021

azure-pipelines bot commented Feb 22, 2021

liat-grozovik commented Feb 23, 2021

liat-grozovik commented Feb 23, 2021

azure-pipelines bot commented Feb 23, 2021

liat-grozovik commented Feb 23, 2021

nazariig commented Feb 23, 2021

nazariig commented Feb 24, 2021

azure-pipelines bot commented Feb 24, 2021

liat-grozovik commented Feb 24, 2021

azure-pipelines bot commented Feb 24, 2021

liat-grozovik commented Feb 25, 2021

jleveque commented Feb 25, 2021

jleveque commented Feb 25, 2021

nazariig commented Feb 25, 2021

nazariig commented Feb 25, 2021

jleveque commented Feb 25, 2021

nazariig commented Feb 25, 2021 •

edited

Loading

jleveque commented Feb 25, 2021

lguohan commented Feb 26, 2021

azure-pipelines bot commented Feb 26, 2021

nazariig commented Feb 28, 2021

liat-grozovik commented Mar 1, 2021

prsunny commented Mar 1, 2021

azure-pipelines bot commented Mar 1, 2021

liat-grozovik commented Mar 2, 2021

azure-pipelines bot commented Mar 2, 2021

liat-grozovik commented Mar 10, 2021

prsunny commented Mar 11, 2021

[sonic-swss] Advance submodule #6789

[sonic-swss] Advance submodule #6789

Conversation

nazariig commented Feb 16, 2021 • edited Loading

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

liat-grozovik commented Feb 16, 2021

azure-pipelines bot commented Feb 16, 2021

liat-grozovik commented Feb 17, 2021

nazariig commented Feb 18, 2021

liat-grozovik commented Feb 18, 2021 via email

liat-grozovik commented Feb 22, 2021

azure-pipelines bot commented Feb 22, 2021

liat-grozovik commented Feb 23, 2021

liat-grozovik commented Feb 23, 2021

azure-pipelines bot commented Feb 23, 2021

liat-grozovik commented Feb 23, 2021

nazariig commented Feb 23, 2021

nazariig commented Feb 24, 2021

azure-pipelines bot commented Feb 24, 2021

liat-grozovik commented Feb 24, 2021

azure-pipelines bot commented Feb 24, 2021

liat-grozovik commented Feb 25, 2021

jleveque commented Feb 25, 2021

jleveque commented Feb 25, 2021

nazariig commented Feb 25, 2021

nazariig commented Feb 25, 2021

jleveque commented Feb 25, 2021

nazariig commented Feb 25, 2021 • edited Loading

jleveque commented Feb 25, 2021

lguohan commented Feb 26, 2021

azure-pipelines bot commented Feb 26, 2021

nazariig commented Feb 28, 2021

liat-grozovik commented Mar 1, 2021

prsunny commented Mar 1, 2021

azure-pipelines bot commented Mar 1, 2021

liat-grozovik commented Mar 2, 2021

azure-pipelines bot commented Mar 2, 2021

liat-grozovik commented Mar 10, 2021

prsunny commented Mar 11, 2021

nazariig commented Feb 16, 2021 •

edited

Loading

nazariig commented Feb 25, 2021 •

edited

Loading