Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-utilities] Update submodule #6874

Closed
wants to merge 1 commit into from
Closed

[sonic-utilities] Update submodule #6874

wants to merge 1 commit into from

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented Feb 24, 2021

@jleveque
Copy link
Contributor Author

@samaity, @praveen-li: The test_breakout_modes test is failing on this submodule update. Can you please look into this?

@praveen-li
Copy link
Collaborator

@jleveque sure let me have a look

@praveen-li
Copy link
Collaborator

praveen-li commented Feb 24, 2021

@samaity: can u list the PR here about VS platform.json
@jleveque: I think after platform.json PR <>, it should fix it.

@samaity
Copy link
Collaborator

samaity commented Feb 25, 2021

@samaity can u list the PR here about VS platform.json

yes @praveen-li, You are right. #6831 has the latest changes regarding vs related platform.json changes which are needed to build vs successfully if we include [#1440PR]([dpb|config] Fix the validation logic of breakout mode (#1440)) in submodule update.

@jleveque
Copy link
Contributor Author

@samaity: #6831 is blocked by its own check build failures. sonic-net/sonic-utilities#1440 should have had a disclaimer that it should not be merged until #6831. What is the status of #6831?

@samaity
Copy link
Collaborator

samaity commented Feb 25, 2021

sonic-net/sonic-utilities#1440

@jleveque, sure. I just updated the sonic-utilities submodule as the sonic-utilities deb package was getting failed in #6831 PR. waiting for the result.

@jleveque jleveque mentioned this pull request Feb 25, 2021
4 tasks
@lguohan lguohan closed this Feb 26, 2021
@jleveque jleveque deleted the update_utils branch February 26, 2021 17:18
@liat-grozovik
Copy link
Collaborator

@lguohan and @jleveque why this one is closed? do we have another PR for updating the utilities submodule with all the above?

@jleveque
Copy link
Contributor Author

jleveque commented Mar 1, 2021

@liat-grozovik : PR #6831 updated the sonic-utilities submodule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants