-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sonic-platform-daemons] submodule update #7143
Conversation
this PR updates the following commits in sonic-platform-daemons 260cf2d [xcvrd] change firmware information fields name inside MUX_CABLE_INFO table for Y cable (sonic-net#165) cfa600f [thermalctld] Initialize fan led in thermalctld for the first run (sonic-net#167) 8509f43 [thermalctld] Refactor to allow for greater unit test coverage; Add more unit tests (sonic-net#157) 70f4e7b [syseepromd] Update warning message to be more informative (sonic-net#160) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
can you check the build failure? |
in one of the commit sonic-thermalctld now added a dependency of sonic-platform-common in setup.py. [ FLAGS FILE ] : [] |
@vdahiya12: That dependency was introduced by me when increasing unit test coverage. I have opened a PR to add the dependency in the makefile here: #7181 |
The following (167) link on the description contains wrong link: It should refer to the following PR: sonic-net/sonic-platform-daemons#167 |
Hi @dprital whenever we update the submodule pointer we always reference the commits with appropriate hash and PR # in the respective submodule repo. In this regard # 167 is actually correct, but you always have to go to the appropriate repo to get the correct link. |
This is how we've been approaching this thus far. It does technically cause GitHub to create links between unrelated PRs. Moving forward we could add the submodule prefix (e.g., Azure/sonic-platform-daemons) before each PR number in the description; it's just a bit time consuming. |
this PR updates the following commits in sonic-platform-daemons 260cf2d [xcvrd] change firmware information fields name inside MUX_CABLE_INFO table for Y cable (#165) cfa600f [thermalctld] Initialize fan led in thermalctld for the first run (#167) 8509f43 [thermalctld] Refactor to allow for greater unit test coverage; Add more unit tests (#157) 70f4e7b [syseepromd] Update warning message to be more informative (#160) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
this PR updates the following commits in sonic-platform-daemons 260cf2d [xcvrd] change firmware information fields name inside MUX_CABLE_INFO table for Y cable (sonic-net#165) cfa600f [thermalctld] Initialize fan led in thermalctld for the first run (sonic-net#167) 8509f43 [thermalctld] Refactor to allow for greater unit test coverage; Add more unit tests (sonic-net#157) 70f4e7b [syseepromd] Update warning message to be more informative (sonic-net#160) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
this PR updates the following commits in sonic-platform-daemons 260cf2d [xcvrd] change firmware information fields name inside MUX_CABLE_INFO table for Y cable (sonic-net#165) cfa600f [thermalctld] Initialize fan led in thermalctld for the first run (sonic-net#167) 8509f43 [thermalctld] Refactor to allow for greater unit test coverage; Add more unit tests (sonic-net#157) 70f4e7b [syseepromd] Update warning message to be more informative (sonic-net#160) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
This PR updates the following commits in sonic-platform-daemons
260cf2d [xcvrd] change firmware information fields name inside MUX_CABLE_INFO table for Y cable (#165)
cfa600f [thermalctld] Initialize fan led in thermalctld for the first run (#167)
8509f43 [thermalctld] Refactor to allow for greater unit test coverage; Add more unit tests (#157)
70f4e7b [syseepromd] Update warning message to be more informative (#160)
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)