-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[minigraph]: Ignore eth0 IPv6 addresses #841
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
reviewed
Jul 25, 2017
src/sonic-config-engine/minigraph.py
Outdated
@@ -188,6 +188,8 @@ def parse_dpg(dpg, hname): | |||
for mgmtintf in mgmtintfs.findall(str(QName(ns1, "ManagementIPInterface"))): | |||
ipprefix = mgmtintf.find(str(QName(ns1, "PrefixStr"))).text | |||
mgmtipn = ipaddress.IPNetwork(ipprefix) | |||
if mgmtipn.version == 6: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add TODO comment.
lguohan
reviewed
Jul 25, 2017
@@ -80,6 +81,7 @@ def test_everflow(self): | |||
|
|||
def tearDown(self): | |||
try: | |||
os.remove(self.output_file) | |||
pass | |||
# os.remove(self.output_file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why change this?
- IPv6 is not supported on management interface - Add unit test
lguohan
approved these changes
Jul 25, 2017
stcheng
pushed a commit
to stcheng/sonic-buildimage
that referenced
this pull request
May 9, 2019
[vnetorch]: Use metadata matching for tunnel (sonic-net#841) [aclorch]: Add ICMP type/code match for v4/v6 (sonic-net#868) [restore_neighbors] fix failure with scapy 2.4.2 (sonic-net#862) [intfsorch] Fix bug for VRF existence check (sonic-net#882) Return 0 for CRM counter instead of None if no match (sonic-net#879) Undo skipping Vnet tests, Vrf check before enslaving (sonic-net#857) [Makefile]: Remove header files from source files (sonic-net#883) Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
prsunny
pushed a commit
that referenced
this pull request
May 10, 2019
[vnetorch]: Use metadata matching for tunnel (#841) [aclorch]: Add ICMP type/code match for v4/v6 (#868) [restore_neighbors] fix failure with scapy 2.4.2 (#862) [intfsorch] Fix bug for VRF existence check (#882) Return 0 for CRM counter instead of None if no match (#879) Undo skipping Vnet tests, Vrf check before enslaving (#857) [Makefile]: Remove header files from source files (#883) Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
MichelMoriniaux
pushed a commit
to criteo-forks/sonic-buildimage
that referenced
this pull request
May 28, 2019
[vnetorch]: Use metadata matching for tunnel (sonic-net#841) [aclorch]: Add ICMP type/code match for v4/v6 (sonic-net#868) [restore_neighbors] fix failure with scapy 2.4.2 (sonic-net#862) [intfsorch] Fix bug for VRF existence check (sonic-net#882) Return 0 for CRM counter instead of None if no match (sonic-net#879) Undo skipping Vnet tests, Vrf check before enslaving (sonic-net#857) [Makefile]: Remove header files from source files (sonic-net#883) Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
lguohan
added a commit
to lguohan/sonic-buildimage
that referenced
this pull request
Mar 22, 2020
* d0f8091 2020-03-22 | Revert "add support for MCLAG (sonic-net#453)" (sonic-net#849) (HEAD -> master, origin/master, origin/HEAD) [lguohan] * 6f54e8c 2020-03-22 | Revert "return list for _get_optional_services() (sonic-net#822)" (sonic-net#848) [lguohan] * f1c79d5 2020-03-22 | return list for _get_optional_services() (sonic-net#822) (HEAD -> master, origin/master, origin/HEAD) [shine4chen] * 28ea21a 2020-03-21 | Fix kernel panic for irq after fast-reboot (sonic-net#823) [byu343] * 727b499 2020-03-22 | [decode-syseeprom] fix getattribute check for sime platforms (sonic-net#835) [Mykola F] * db78cb6 2020-03-21 | Update Command Reference with sFlow section (sonic-net#841) [padmanarayana] * 780673c 2020-03-21 | explicitly specify command with underscores (sonic-net#846) [lguohan] * 07dc201 2020-03-21 | [db_migrator]Do DB migration for buffer pool size change on Mellanox platform (sonic-net#833) [Kebo Liu] * 9a94955 2020-03-20 | [sonic_installer] Enable ARM64 arch (sonic-net#811) [arheneus@marvell.com] * 92b30c2 2020-03-18 | [config]: add syslog messages to config load_minigraph/reload (sonic-net#843) [lguohan] * 4389ffe 2020-03-17 | [intfutil] set speed to 0 when interface speed is not available (sonic-net#839) [Ying Xie] * 45c6c68 2020-03-17 | [Mellanox] add document for thermal control related cli (sonic-net#832) [Junchao-Mellanox] * 7105400 2020-03-12 | Add kdump support for Aboot platforms (sonic-net#824) [byu343] * c5c5ffc 2020-03-01 | [fwutil]: Set default socket timeout for FW download to 30 sec. (sonic-net#821) [Nazarii Hnydyn] * 81c5930 2020-03-01 | Update config/show to include PFC Watchdog commands (sonic-net#736) [Andriy Moroz] * 66e9dfb 2020-02-28 | [MultiDB] sonic-utilities - replace redis-cli/redis-dump with sonic-db-cli/sonic-db-dump (sonic-net#810) [Dong Zhang] * 8aea564 2020-02-24 | add support for MCLAG (sonic-net#453) [shine4chen] * 118620f 2020-02-23 | [reboot] make sure the reboot happens even if platform reboot failed (sonic-net#819) [Ying Xie] * 40eff82 2020-02-22 | Multi-Db changes for NAT feature. (sonic-net#818) [Akhilesh Samineni] * a4cb4dd 2020-02-21 | [Command-Reference.md] Unify Usage statments and Examples (including sample prompts) (sonic-net#816) [Joe LeVeque] Signed-off-by: Guohan Lu <lguohan@gmail.com>
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
* [vnetorch]: Use metadata matching for tunnel Signed-off-by: Marian Pritsak <marianp@mellanox.com> * Rename to meta tunnel table
lguohan
added a commit
that referenced
this pull request
Mar 23, 2020
* [submodule]: update sonic-utilities * d0f8091 2020-03-22 | Revert "add support for MCLAG (#453)" (#849) (HEAD -> master, origin/master, origin/HEAD) [lguohan] * 6f54e8c 2020-03-22 | Revert "return list for _get_optional_services() (#822)" (#848) [lguohan] * f1c79d5 2020-03-22 | return list for _get_optional_services() (#822) (HEAD -> master, origin/master, origin/HEAD) [shine4chen] * 28ea21a 2020-03-21 | Fix kernel panic for irq after fast-reboot (#823) [byu343] * 727b499 2020-03-22 | [decode-syseeprom] fix getattribute check for sime platforms (#835) [Mykola F] * db78cb6 2020-03-21 | Update Command Reference with sFlow section (#841) [padmanarayana] * 780673c 2020-03-21 | explicitly specify command with underscores (#846) [lguohan] * 07dc201 2020-03-21 | [db_migrator]Do DB migration for buffer pool size change on Mellanox platform (#833) [Kebo Liu] * 9a94955 2020-03-20 | [sonic_installer] Enable ARM64 arch (#811) [arheneus@marvell.com] * 92b30c2 2020-03-18 | [config]: add syslog messages to config load_minigraph/reload (#843) [lguohan] * 4389ffe 2020-03-17 | [intfutil] set speed to 0 when interface speed is not available (#839) [Ying Xie] * 45c6c68 2020-03-17 | [Mellanox] add document for thermal control related cli (#832) [Junchao-Mellanox] * 7105400 2020-03-12 | Add kdump support for Aboot platforms (#824) [byu343] * c5c5ffc 2020-03-01 | [fwutil]: Set default socket timeout for FW download to 30 sec. (#821) [Nazarii Hnydyn] * 81c5930 2020-03-01 | Update config/show to include PFC Watchdog commands (#736) [Andriy Moroz] * 66e9dfb 2020-02-28 | [MultiDB] sonic-utilities - replace redis-cli/redis-dump with sonic-db-cli/sonic-db-dump (#810) [Dong Zhang] * 8aea564 2020-02-24 | add support for MCLAG (#453) [shine4chen] * 118620f 2020-02-23 | [reboot] make sure the reboot happens even if platform reboot failed (#819) [Ying Xie] * 40eff82 2020-02-22 | Multi-Db changes for NAT feature. (#818) [Akhilesh Samineni] * a4cb4dd 2020-02-21 | [Command-Reference.md] Unify Usage statments and Examples (including sample prompts) (#816) [Joe LeVeque] Signed-off-by: Guohan Lu <lguohan@gmail.com>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
May 10, 2021
mssonicbld
added a commit
that referenced
this pull request
Jan 10, 2024
…omatically (#17410) #### Why I did it src/sonic-swss-common ``` * 16bc247 - (HEAD -> master, origin/master, origin/HEAD) [tests] fix binary_data_get unit test (#841) (72 minutes ago) [Yakiv Huryk] * b2480ad - Add SonicDBConfig::reset method (#843) (4 weeks ago) [ganglv] * ab3ce86 - [Azp]: Fix azp dash dependency (#842) (5 weeks ago) [Ze Gan] * 5d1fe2d - add support for binary data read for Table::get() (#836) (5 weeks ago) [Yakiv Huryk] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.