[Broadcom]: Update the docker-syncd-rpc Makefile and Dockerfile #843

stcheng · 2017-07-26T02:05:28Z

No description provided.

lguohan · 2017-07-26T05:23:45Z

platform/broadcom/docker-syncd-brcm-rpc.mk

@@ -2,7 +2,7 @@

 DOCKER_SYNCD_BRCM_RPC = docker-syncd-brcm-rpc.gz
 $(DOCKER_SYNCD_BRCM_RPC)_PATH = $(PLATFORM_PATH)/docker-syncd-brcm-rpc
-$(DOCKER_SYNCD_BRCM_RPC)_DEPENDS += $(SYNCD_RPC) $(LIBTHRIFT)
+$(DOCKER_SYNCD_BRCM_RPC)_DEPENDS += $(SYNCD) $(LIBTHRIFT)


is this a temp fix?

lguohan · 2017-07-26T17:40:39Z

platform/broadcom/docker-syncd-brcm-rpc/Dockerfile.j2

@@ -9,8 +9,6 @@ debs/{{ deb }}{{' '}}
 {%- endfor -%}
 debs/

-RUN dpkg -P syncd


+# FIXME: Swap SYNCD to SYNCD_RPC after libsaithrift is compatible with SAI v1.0

This is a temporary fix for unblocking COPP test. After libsaithrift is compatible with SAI v1.0, this change needs to be reverted.

pavel-shirshov

as commented

pavel-shirshov · 2017-07-26T19:23:11Z

platform/broadcom/docker-syncd-brcm-rpc/Dockerfile.j2

 RUN dpkg_apt() { [ -f $1 ] && { dpkg -i $1 || apt-get -y install -f; } || return 1; } ; \
 {% for deb in docker_syncd_brcm_rpc_debs.split(' ') -%}
 dpkg_apt debs/{{ deb }}{{'; '}}
 {%- endfor %}

+# FIXME: Uncomment this line after libsaithrift is compatible with SAI v1.0
+# RUN dpkg -P syncd
+


It's better to move this purge operation on previous place. We should remove old syncd before we install new one

stcheng · 2017-09-28T19:06:49Z

I will fix it in a separate pull request.

* d0f8091 2020-03-22 | Revert "add support for MCLAG (sonic-net#453)" (sonic-net#849) (HEAD -> master, origin/master, origin/HEAD) [lguohan] * 6f54e8c 2020-03-22 | Revert "return list for _get_optional_services() (sonic-net#822)" (sonic-net#848) [lguohan] * f1c79d5 2020-03-22 | return list for _get_optional_services() (sonic-net#822) (HEAD -> master, origin/master, origin/HEAD) [shine4chen] * 28ea21a 2020-03-21 | Fix kernel panic for irq after fast-reboot (sonic-net#823) [byu343] * 727b499 2020-03-22 | [decode-syseeprom] fix getattribute check for sime platforms (sonic-net#835) [Mykola F] * db78cb6 2020-03-21 | Update Command Reference with sFlow section (sonic-net#841) [padmanarayana] * 780673c 2020-03-21 | explicitly specify command with underscores (sonic-net#846) [lguohan] * 07dc201 2020-03-21 | [db_migrator]Do DB migration for buffer pool size change on Mellanox platform (sonic-net#833) [Kebo Liu] * 9a94955 2020-03-20 | [sonic_installer] Enable ARM64 arch (sonic-net#811) [arheneus@marvell.com] * 92b30c2 2020-03-18 | [config]: add syslog messages to config load_minigraph/reload (sonic-net#843) [lguohan] * 4389ffe 2020-03-17 | [intfutil] set speed to 0 when interface speed is not available (sonic-net#839) [Ying Xie] * 45c6c68 2020-03-17 | [Mellanox] add document for thermal control related cli (sonic-net#832) [Junchao-Mellanox] * 7105400 2020-03-12 | Add kdump support for Aboot platforms (sonic-net#824) [byu343] * c5c5ffc 2020-03-01 | [fwutil]: Set default socket timeout for FW download to 30 sec. (sonic-net#821) [Nazarii Hnydyn] * 81c5930 2020-03-01 | Update config/show to include PFC Watchdog commands (sonic-net#736) [Andriy Moroz] * 66e9dfb 2020-02-28 | [MultiDB] sonic-utilities - replace redis-cli/redis-dump with sonic-db-cli/sonic-db-dump (sonic-net#810) [Dong Zhang] * 8aea564 2020-02-24 | add support for MCLAG (sonic-net#453) [shine4chen] * 118620f 2020-02-23 | [reboot] make sure the reboot happens even if platform reboot failed (sonic-net#819) [Ying Xie] * 40eff82 2020-02-22 | Multi-Db changes for NAT feature. (sonic-net#818) [Akhilesh Samineni] * a4cb4dd 2020-02-21 | [Command-Reference.md] Unify Usage statments and Examples (including sample prompts) (sonic-net#816) [Joe LeVeque] Signed-off-by: Guohan Lu <lguohan@gmail.com>

* [submodule]: update sonic-utilities * d0f8091 2020-03-22 | Revert "add support for MCLAG (#453)" (#849) (HEAD -> master, origin/master, origin/HEAD) [lguohan] * 6f54e8c 2020-03-22 | Revert "return list for _get_optional_services() (#822)" (#848) [lguohan] * f1c79d5 2020-03-22 | return list for _get_optional_services() (#822) (HEAD -> master, origin/master, origin/HEAD) [shine4chen] * 28ea21a 2020-03-21 | Fix kernel panic for irq after fast-reboot (#823) [byu343] * 727b499 2020-03-22 | [decode-syseeprom] fix getattribute check for sime platforms (#835) [Mykola F] * db78cb6 2020-03-21 | Update Command Reference with sFlow section (#841) [padmanarayana] * 780673c 2020-03-21 | explicitly specify command with underscores (#846) [lguohan] * 07dc201 2020-03-21 | [db_migrator]Do DB migration for buffer pool size change on Mellanox platform (#833) [Kebo Liu] * 9a94955 2020-03-20 | [sonic_installer] Enable ARM64 arch (#811) [arheneus@marvell.com] * 92b30c2 2020-03-18 | [config]: add syslog messages to config load_minigraph/reload (#843) [lguohan] * 4389ffe 2020-03-17 | [intfutil] set speed to 0 when interface speed is not available (#839) [Ying Xie] * 45c6c68 2020-03-17 | [Mellanox] add document for thermal control related cli (#832) [Junchao-Mellanox] * 7105400 2020-03-12 | Add kdump support for Aboot platforms (#824) [byu343] * c5c5ffc 2020-03-01 | [fwutil]: Set default socket timeout for FW download to 30 sec. (#821) [Nazarii Hnydyn] * 81c5930 2020-03-01 | Update config/show to include PFC Watchdog commands (#736) [Andriy Moroz] * 66e9dfb 2020-02-28 | [MultiDB] sonic-utilities - replace redis-cli/redis-dump with sonic-db-cli/sonic-db-dump (#810) [Dong Zhang] * 8aea564 2020-02-24 | add support for MCLAG (#453) [shine4chen] * 118620f 2020-02-23 | [reboot] make sure the reboot happens even if platform reboot failed (#819) [Ying Xie] * 40eff82 2020-02-22 | Multi-Db changes for NAT feature. (#818) [Akhilesh Samineni] * a4cb4dd 2020-02-21 | [Command-Reference.md] Unify Usage statments and Examples (including sample prompts) (#816) [Joe LeVeque] Signed-off-by: Guohan Lu <lguohan@gmail.com>

…net#843) add stoping/restarting services messages in syslog Signed-off-by: Guohan Lu <lguohan@gmail.com>

Changes: ``` 3c485e5 [recorder] Fix incorrect attribute enum value capability query (sonic-net#843) 677ebca [sairedis] Client/Server support zmq configuration file (sonic-net#845) 7c70e34 [sairedis] Add support for bulk api in client/server (sonic-net#844) 76d28a6 [pyext] Use SAI autogenerated saiswig.i (sonic-net#837) 9949c48 [vslib] implement query for SAI_DEBUG_COUNTER_TYPE enum values (sonic-net#842) e385212 [MPLS] Minor tweaks to VS for MPLS support for CRM polling of MPLS In-segments and NHs. d819f97 [meta] Add support for ignored attributes names (sonic-net#836) c163238 Add cisco-8000 checks to syncd_init_common (sonic-net#839) 9aed2ff [sairedis] Add support for client server architecture (sonic-net#838) ``` Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

Changes: 3c485e5 [recorder] Fix incorrect attribute enum value capability query (#843) 677ebca [sairedis] Client/Server support zmq configuration file (#845) 7c70e34 [sairedis] Add support for bulk api in client/server (#844) 76d28a6 [pyext] Use SAI autogenerated saiswig.i (#837) 9949c48 [vslib] implement query for SAI_DEBUG_COUNTER_TYPE enum values (#842) e385212 [MPLS] Minor tweaks to VS for MPLS support for CRM polling of MPLS In-segments and NHs. d819f97 [meta] Add support for ignored attributes names (#836) c163238 Add cisco-8000 checks to syncd_init_common (#839) 9aed2ff [sairedis] Add support for client server architecture (#838) Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

sairedis: *[recorder] Fix incorrect attribute enum value capability query (#843) d86b051 *[syncd] Fix fdb flood queue size limit check (#863) 3a2af76 *[vslib] implement query for SAI_DEBUG_COUNTER_TYPE enum values (#842) 575dcb4 swss: *[portsorch] fix errors when moving port from one lag to anoth… a67d8af *[debugcounterorch] check if counter type is supported before querying… ( 04105a4 *Td2: Reclaim buffer from unused ports (#1830) ac7f5cf *[Dynamic Buffer Calc][202012]Bug fix: Don't create lossless buffer pr… f54b7d0 Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>

Changes: 3c485e5 [recorder] Fix incorrect attribute enum value capability query (sonic-net#843) 677ebca [sairedis] Client/Server support zmq configuration file (sonic-net#845) 7c70e34 [sairedis] Add support for bulk api in client/server (sonic-net#844) 76d28a6 [pyext] Use SAI autogenerated saiswig.i (sonic-net#837) 9949c48 [vslib] implement query for SAI_DEBUG_COUNTER_TYPE enum values (sonic-net#842) e385212 [MPLS] Minor tweaks to VS for MPLS support for CRM polling of MPLS In-segments and NHs. d819f97 [meta] Add support for ignored attributes names (sonic-net#836) c163238 Add cisco-8000 checks to syncd_init_common (sonic-net#839) 9aed2ff [sairedis] Add support for client server architecture (sonic-net#838) Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>

…-net#843) Recorder was assuming that enum value capability query is executed for an attribute that has a value type of a s32 list. When querying SAI_DEBUG_COUNTER_ATTR_TYPE using sai_query_attribute_enum_values_capability a warning is printed in syslog: "enum value 4 not found in enum sai_debug_counter_type". This happens because SAI_DEBUG_COUNTER_ATTR_TYPE attrvaluetype is int32 (enum value) and sai_s32_list_t structure was casted to int32. Since we initialize sai_s32_list with .count = 4 (the number of values in sai_debug_counter_type_t enum) value 4 is printed in the syslog.

…omatically (#17410) #### Why I did it src/sonic-swss-common ``` * 16bc247 - (HEAD -> master, origin/master, origin/HEAD) [tests] fix binary_data_get unit test (#841) (72 minutes ago) [Yakiv Huryk] * b2480ad - Add SonicDBConfig::reset method (#843) (4 weeks ago) [ganglv] * ab3ce86 - [Azp]: Fix azp dash dependency (#842) (5 weeks ago) [Ze Gan] * 5d1fe2d - add support for binary data read for Table::get() (#836) (5 weeks ago) [Yakiv Huryk] ``` #### How I did it #### How to verify it #### Description for the changelog

msftclas added the cla-not-required label Jul 26, 2017

stcheng requested a review from pavel-shirshov July 26, 2017 02:05

stcheng added the Bug 🐛 label Jul 26, 2017

lguohan reviewed Jul 26, 2017

View reviewed changes

[Broadcom]: Update the docker-syncd-rpc Makefile and Dockerfile

f1b9cca

This is a temporary fix for unblocking COPP test. After libsaithrift is compatible with SAI v1.0, this change needs to be reverted.

lguohan approved these changes Jul 26, 2017

View reviewed changes

pavel-shirshov suggested changes Jul 26, 2017

View reviewed changes

msftgits removed the cla-not-required label Sep 26, 2017

stcheng closed this Sep 28, 2017

lguohan mentioned this pull request Mar 22, 2020

[submodule]: update sonic-utilities #4308

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Broadcom]: Update the docker-syncd-rpc Makefile and Dockerfile #843

[Broadcom]: Update the docker-syncd-rpc Makefile and Dockerfile #843

stcheng commented Jul 26, 2017

lguohan Jul 26, 2017

lguohan Jul 26, 2017

pavel-shirshov left a comment

pavel-shirshov Jul 26, 2017

stcheng commented Sep 28, 2017

[Broadcom]: Update the docker-syncd-rpc Makefile and Dockerfile #843

[Broadcom]: Update the docker-syncd-rpc Makefile and Dockerfile #843

Conversation

stcheng commented Jul 26, 2017

lguohan Jul 26, 2017

Choose a reason for hiding this comment

lguohan Jul 26, 2017

Choose a reason for hiding this comment

pavel-shirshov left a comment

Choose a reason for hiding this comment

pavel-shirshov Jul 26, 2017

Choose a reason for hiding this comment

stcheng commented Sep 28, 2017