[sfp-refactoring] Initial support for CMIS application initialization #9157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
lguohan
previously approved these changes
Nov 3, 2021
|
which sfp refactor framework are you referring to? is it arista one or broadcom one? |
It's Broadcom, but the new sfp-refactoring is still in-progress, and should be ready by this Friday |
|
This pull request introduces 1 alert when merging ec1fddf25298a761272f89a939d511661c9f3766 into a61ffcd - view on LGTM.com new alerts:
|
ds952811
changed the title
This was referenced Nov 8, 2021
ds952811
force-pushed
the
sfp-refactoring-ix9
branch
from
dad90ab
to
6c9d950
Compare
| Returns: | ||
| A string, the port/cage type of this SFP | ||
| """ | ||
| return self.SFP_PORT_TYPE_QSFPDD |
There was a problem hiding this comment.
Shouldn't this (at least ideally) be based on byte 00 from the plugged in module?
There was a problem hiding this comment.
This is the cage type of the port, not the media type fetched from the EEPROM of the attached transceiver.
ds952811
force-pushed
the
sfp-refactoring-ix9
branch
2 times, most recently
from
1b033fc
to
2df4e38
Compare
ds952811
force-pushed
the
sfp-refactoring-ix9
branch
from
2df4e38
to
7fe760c
Compare
|
/azpw run |
|
/AzurePipelines run |
|
Pull request contains merge conflicts. |
…ework Migrate the Quanta IX9 to the new sfp-refactoring framework Signed-off-by: Dante Su <dante.su@broadcom.com>
ds952811
force-pushed
the
sfp-refactoring-ix9
branch
from
7fe760c
to
62d57b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[sfp-refactoring] Quanta IX9: migrate to the new sfp-refactoring framework
Migrate the Quanta IX9 to the new sfp-refactoring framework
Signed-off-by: Dante Su dante.su@broadcom.com
Why I did it
Migrate the Quanta IX9 to the new sfp-refactoring framework
How I did it
Update the sfp.py of Quanta IX9 to use the new sfp-refactoring framework
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)