Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sfp-refactoring] Initial support for CMIS application initialization #1855

Closed
wants to merge 4 commits into from
Closed

[sfp-refactoring] Initial support for CMIS application initialization #1855

wants to merge 4 commits into from

Conversation

ds952811
Copy link
Contributor

@ds952811 ds952811 commented Oct 4, 2021 •
edited
Loading

Signed-off-by: Dante Su dante.su@broadcom.com

Why I did it

Add initial support for CMIS application initialization

How I did it

Update sfputil and sfpshow to support CMIS application advertisement and error detection

How to verify it

  1. Issue 'show logging xcvrd' to check if the application initialization succeeded
  2. Issue 'show interfaces transceiver eeprom --dom' to verify both the static and DOM information parsers
  3. Issue 'sudo sfputil show eeprom --dom' to verify both the static and DOM information parsers

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

Repo PR title State
SONiC [sfp-refactoring] Initial support for CMIS application initialization
sonic-platform-common [sfp-refactoring] Initial support for CMIS application initialization
sonic-platform-daemon [sfp-refactoring] Initial support for CMIS application initialization
sonic-utilities [sfp-refactoring] Initial support for CMIS application initialization
  • Previous command output (if the output of a command-line utility has changed)
admin@sonic:~$ show interfaces transceiver eeprom Ethernet0
Ethernet0: SFP EEPROM detected
        Application Advertisement: {1: {'ap_sel_code_id': 1, 'host_electrical_interface_id': '400GAUI-8 C2M (Annex 120E)', 'module_media_interface_id': '400GBASE-DR4 (Cl 124)', 'host_lane_count': 8, 'media_lane_count': 4, 'host_lane_assignment_options': 1, 'media_lane_assignment_options': None}, 2: {'ap_sel_code_id': 2, 'host_electrical_interface_id': '100GAUI-2 C2M (Annex 135G)', 'module_media_interface_id': '100G-FR/100GBASE-FR1 (Cl 140)', 'host_lane_count': 2, 'media_lane_count': 1, 'host_lane_assignment_options': 85, 'media_lane_assignment_options': None}}
        Connector: SN optical connector
        Encoding: N/A
        Extended Identifier: Power Class 6 (12.0W Max)
        Extended RateSelect Compliance: N/A
        Identifier: QSFP-DD Double Density 8X Pluggable Transceiver
        Length cable Assembly(m): 0.0
        Nominal Bit Rate(100Mbs): 0
        Specification compliance: sm_media_interface
        Vendor Date Code(YYYY-MM-DD Lot): 2020-10-07
        Vendor Name: AVAGO
        Vendor OUI: 00-17-6a
        Vendor PN: AFCT-93DRPHZ-AZ2
        Vendor Rev: 01
        Vendor SN: FD2038FG0FY

admin@sonic:~$ sudo sfputil show eeprom -p Ethernet0
Ethernet0: SFP EEPROM detected
        Application Advertisement: {1: {'ap_sel_code_id': 1, 'host_electrical_interface_id': '400GAUI-8 C2M (Annex 120E)', 'module_media_interface_id': '400GBASE-DR4 (Cl 124)', 'host_lane_count': 8, 'media_lane_count': 4, 'host_lane_assignment_options': 1, 'media_lane_assignment_options': None}, 2: {'ap_sel_code_id': 2, 'host_electrical_interface_id': '100GAUI-2 C2M (Annex 135G)', 'module_media_interface_id': '100G-FR/100GBASE-FR1 (Cl 140)', 'host_lane_count': 2, 'media_lane_count': 1, 'host_lane_assignment_options': 85, 'media_lane_assignment_options': None}}
        Connector: SN optical connector
        Encoding: N/A
        Extended Identifier: Power Class 6 (12.0W Max)
        Extended RateSelect Compliance: N/A
        Identifier: QSFP-DD Double Density 8X Pluggable Transceiver
        Length cable Assembly(m): 0.0
        Nominal Bit Rate(100Mbs): 0
        Specification compliance: sm_media_interface
        Vendor Date Code(YYYY-MM-DD Lot): 2020-10-07
        Vendor Name: AVAGO
        Vendor OUI: 00-17-6a
        Vendor PN: AFCT-93DRPHZ-AZ2
        Vendor Rev: 01
        Vendor SN: FD2038FG0FY
  • New command output (if the output of a command-line utility has changed)
admin@sonic:~$ show interfaces transceiver eeprom Ethernet0
Ethernet0: SFP EEPROM detected
        Application Advertisement:
                1: 400GAUI-8 C2M (Annex 120E) | 400GBASE-DR4 (Cl 124)
                2: 100GAUI-2 C2M (Annex 135G) | 100G-FR/100GBASE-FR1 (Cl 140)
        Connector: SN optical connector
        Encoding: N/A
        Extended Identifier: Power Class 6 (12.0W Max)
        Extended RateSelect Compliance: N/A
        Identifier: QSFP-DD Double Density 8X Pluggable Transceiver
        Length cable Assembly(m): 0.0
        Nominal Bit Rate(100Mbs): 0
        Specification compliance: sm_media_interface
        Vendor Date Code(YYYY-MM-DD Lot): 2020-10-07
        Vendor Name: AVAGO
        Vendor OUI: 00-17-6a
        Vendor PN: AFCT-93DRPHZ-AZ2
        Vendor Rev: 01
        Vendor SN: FD2038FG0FY

admin@sonic:~$ sudo sfputil show eeprom -p Ethernet0
Ethernet0: SFP EEPROM detected
        Application Advertisement:
                1: 400GAUI-8 C2M (Annex 120E) | 400GBASE-DR4 (Cl 124)
                2: 100GAUI-2 C2M (Annex 135G) | 100G-FR/100GBASE-FR1 (Cl 140)
        Connector: SN optical connector
        Encoding: N/A
        Extended Identifier: Power Class 6 (12.0W Max)
        Extended RateSelect Compliance: N/A
        Identifier: QSFP-DD Double Density 8X Pluggable Transceiver
        Length cable Assembly(m): 0.0
        Nominal Bit Rate(100Mbs): 0
        Specification compliance: sm_media_interface
        Vendor Date Code(YYYY-MM-DD Lot): 2020-10-07
        Vendor Name: AVAGO
        Vendor OUI: 00-17-6a
        Vendor PN: AFCT-93DRPHZ-AZ2
        Vendor Rev: 01
        Vendor SN: FD2038FG0FY

A picture of a cute animal (not mandatory but encouraged)

This was referenced Oct 4, 2021
Closed
Merged
Merged
Merged
@lgtm-com
Copy link

lgtm-com bot commented Oct 4, 2021

This pull request introduces 2 alerts when merging f79569c06b232ab67516fec789a3ccc03f7d32a0 into 5bdf270 - view on LGTM.com

new alerts:

  • 2 for Except block handles 'BaseException'

keboliu
keboliu reviewed Oct 6, 2021
View reviewed changes
sfputil/main.py Show resolved Hide resolved
sfputil/main.py Outdated Show resolved Hide resolved
sfputil/main.py Outdated Show resolved Hide resolved
@ds952811 ds952811 changed the title sfp: add initial support for CMIS [sfp-refactoring] sfputil/sfpshow: add initial support for CMIS application initialization Nov 3, 2021
@lgtm-com
Copy link

lgtm-com bot commented Nov 5, 2021

This pull request introduces 1 alert when merging 660ec6f4a45d29753f79da47827ae8e1dbd2b0f1 into efbe1f4 - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'

@lgtm-com
Copy link

lgtm-com bot commented Nov 8, 2021

This pull request introduces 2 alerts when merging 9448a45550c3fbe4403353a0287d5177b48efd2b into 563c416 - view on LGTM.com

new alerts:

  • 2 for Except block handles 'BaseException'

@lgtm-com
Copy link

lgtm-com bot commented Nov 8, 2021

This pull request introduces 2 alerts when merging 2397fc3bb1c10a41c8befb69f4dfa8b4e9668cdf into 563c416 - view on LGTM.com

new alerts:

  • 2 for Except block handles 'BaseException'

@ds952811 ds952811 mentioned this pull request Nov 8, 2021
Closed
5 tasks
@ds952811 ds952811 changed the title [sfp-refactoring] sfputil/sfpshow: add initial support for CMIS application initialization [sfp-refactoring] Initial support for CMIS application initialization Nov 8, 2021
@ds952811 ds952811 force-pushed the sfp-cmis branch 2 times, most recently from 5903628 to dbe51b1 Compare December 13, 2021 05:52
@lgtm-com
Copy link

lgtm-com bot commented Dec 13, 2021

This pull request introduces 2 alerts when merging dbe51b1e50f870c00c698971fe1b54ed2bd1725b into 96143ee - view on LGTM.com

new alerts:

  • 2 for Except block handles 'BaseException'

@ds952811
[sfp-refactoring] initial support for CMIS application initialization
3dfeed3 
Signed-off-by: Dante Su <dante.su@broadcom.com>
@ds952811
add missing changes to sfpshow and sfputil_test.py
f589e05 
Signed-off-by: Dante Su <dante.su@broadcom.com>
@ds952811
add missing sanity test for sfp_test.py
735f8bd 
Signed-off-by: Dante Su <dante.su@broadcom.com>
@ds952811
fix unittest failures
501e2b2 
Signed-off-by: Dante Su <dante.su@broadcom.com>
@prgeor
Copy link
Contributor

prgeor commented Jan 3, 2022

@ds952811 could you run sonic-mgmt tests

@prgeor prgeor self-assigned this Jan 3, 2022
@prgeor
Copy link
Contributor

prgeor commented Jan 3, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prgeor
Copy link
Contributor

prgeor commented Jan 12, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 18, 2022
@volodymyrsamotiy
[submodule] [202012] Update sonic-swss pointer (#8676)
ab07ba2 
* d240291 Update port_rates & rif_rates lua scripts to convert poll_interval to MS (sonic-net#1855)
* a71a5d3 [acl mirror action] Mirror session ref count fix at acl rule attachment (sonic-net#1761)
* 197f427 Fix vs test failure in test_buffer_traditional (sonic-net#1881)
* 8471f42 Revert "[debugcounterorch] check if counter type is supported before querying… (sonic-net#1789)" (sonic-net#1884)

Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
@ds952811 ds952811 closed this Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keboliu keboliu keboliu left review comments

@Junchao-Mellanox Junchao-Mellanox Junchao-Mellanox left review comments

Assignees

@prgeor prgeor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ds952811 @prgeor @keboliu @Junchao-Mellanox