-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add belgite support #9511
Add belgite support #9511
Conversation
This pull request introduces 16 alerts when merging a188cc0 into 4803847 - view on LGTM.com new alerts:
|
@@ -0,0 +1,57 @@ | |||
# name lanes alias index speed autoneg | |||
Ethernet0 26 Ethernet1/0/1 1 1000 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually use etp1
to etpN
for alias
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply, Blueve. Got it, I will check it will SDK guy and update it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blueve,
We did the change as you said .
- Change the alias to etp1 to etpN
- Change the AN from 1/0 to on/off
Here is the log. Please review. I'll update later. Thanks.
show-interface.log
@@ -0,0 +1,57 @@ | |||
# name lanes alias index speed autoneg | |||
Ethernet0 26 Ethernet1/0/1 1 1000 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use on
or off
in autoneg column?
@@ -0,0 +1,4 @@ | |||
CONSOLE_PORT=0x3f8 | |||
CONSOLE_DEV=0 | |||
CONSOLE_SPEED=115200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lguohan do we need 9600
for better compatibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Blueve, seems our Banyan usually use the 9600 Baud Rate, also, I will update it later. Thanks Again.
This pull request introduces 16 alerts when merging 7a21eca into 8a07af9 - view on LGTM.com new alerts:
|
@jerseyang can you address comment? |
@jerseyang can you comments? |
@@ -0,0 +1,4 @@ | |||
{ | |||
"skip_ledd": true, | |||
"skip_pcied": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any specific reason that you need to skip the pcied for this platform?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jinkang, Please ignore this first, I am doing the verification in my local. also I will update it later.
By the way, seems I have encountered some issue in the validation.
seems the latest code in master branch using the python 3.9 as the following shows:
root@sonic:/# find -name psu.py
./host/image-Add_Belgite_support.0-dirty-20220209.082924/rw/usr/local/lib/python 3.9/dist-packages/sonic_platform/psu.py
./host/image-Add_Belgite_support.0-dirty-20220209.082924/docker/overlay2/ff5ee5f 19a80d36a902574999c1324886c537568bd9e079402545b39a5af5e33/diff/usr/local/lib/pyt hon3.7/dist-packages/sonic_platform/psu.py
find: ‘./proc/18961/task/18961/net’: Invalid argument
find: ‘./proc/18961/net’: Invalid argument
find: ‘./proc/18962/task/18962/net’: Invalid argument
find: ‘./proc/18962/net’: Invalid argument
./usr/local/lib/python3.9/dist-packages/sonic_platform/psu.py
but our thermalctld still import the python3.7 's module, which as the syslog shows, do we update the python version
in SONiC codebase? seems the platform API verification is ok in branch 202106.
Jul 25 03:16:30.677708 sonic INFO systemd[1]: Condition check resulted in gbsyncd service being skipped.
Jul 25 03:16:30.708447 sonic INFO teamd.sh[6747]: Creating new teamd container with HWSKU CELESTICA-BELGITE
Jul 25 03:16:30.732821 sonic INFO pmon#/supervisord: psud Traceback (most recent call last):
Jul 25 03:16:30.736414 sonic INFO pmon#/supervisord: psud File "/usr/local/lib/python3.7/dist-packages/sonic_platform/platform.py", line 10, in
Jul 25 03:16:30.736414 sonic INFO pmon#/supervisord: psud from sonic_platform_pddf_base.pddfparse import PddfParse
Jul 25 03:16:30.736414 sonic INFO pmon#/supervisord: psud ModuleNotFoundError: No module named 'sonic_platform_pddf_base.pddfparse'
Jul 25 03:16:30.736414 sonic INFO pmon#/supervisord: psud
Jul 25 03:16:30.736414 sonic INFO pmon#/supervisord: psud During handling of the above exception, another exception occurred:
Jul 25 03:16:30.736414 sonic INFO pmon#/supervisord: psud
Jul 25 03:16:30.736414 sonic INFO pmon#/supervisord: psud Traceback (most recent call last):
Jul 25 03:16:30.736455 sonic INFO pmon#/supervisord: psud File "/usr/local/bin/psud", line 17, in
Jul 25 03:16:30.736455 sonic INFO pmon#/supervisord: psud from sonic_platform.psu import Psu
Jul 25 03:16:30.736455 sonic INFO pmon#/supervisord: psud File "/usr/local/lib/python3.7/dist-packages/sonic_platform/init.py", line 3, in
Jul 25 03:16:30.736479 sonic INFO pmon#/supervisord: psud from sonic_platform import *
Jul 25 03:16:30.736479 sonic INFO pmon#/supervisord: psud File "/usr/local/lib/python3.7/dist-packages/sonic_platform/platform.py", line 14, in
Jul 25 03:16:30.736505 sonic INFO pmon#/supervisord: psud raise ImportError(str(e) + "- required module not found")
Jul 25 03:16:30.736505 sonic INFO pmon#/supervisord: psud ImportError: No module named 'sonic_platform_pddf_base.pddfparse'- required module not found
Jul 25 03:16:30.736505 sonic INFO pmon#supervisord 2021-07-25 03:16:30,731 INFO exited: psud (exit status 1; not expected)
Jul 25 03:16:30.770896 sonic DEBUG bgp#bgpcfgd: execute command '['vtysh', '-c', 'show bgp vrf default neighbors json']'.
Jul 25 03:16:30.788016 sonic INFO pmon#/supervisord: thermalctld Traceback (most recent call last):
@jerseyang could you address comment? |
This pull request introduces 16 alerts when merging 7c3a57d into b7ae4f2 - view on LGTM.com new alerts:
|
…the baud rate to 9600 2. optimize the alert in Azure community
This pull request introduces 11 alerts when merging a20602a into d540492 - view on LGTM.com new alerts:
|
…DF compliance with branch 202106
This pull request introduces 12 alerts when merging 77bfe8c into cc938e7 - view on LGTM.com new alerts:
|
@sujinmkang, I note my PR compiling failed in the Azure pipline, but in my local, it does not like this, it could be built successfully. |
my PR commit : 273d24a jersey@cthgd047:~/work/jersey/SONiC/PR/Master_WS/sonic-buildimage$ git log
commit 5cd6bc4 (origin/master, origin/HEAD, master) and my runtime SONiC image: root@sonic:/home/admin# show version SONiC Software Version: SONiC.Add_Belgite_support.0-273d24a2a |
…ode to be compatiable BRCM PDDF update
This pull request introduces 15 alerts when merging 318e5ea into 3fc3259 - view on LGTM.com new alerts:
|
… initialize sequence
This pull request introduces 17 alerts when merging 6f31f8b into bc30528 - view on LGTM.com new alerts:
|
…watchdog API issue
This pull request introduces 17 alerts when merging c5ebd2f into 0e30ffe - view on LGTM.com new alerts:
|
This pull request introduces 16 alerts when merging b725940 into f579f61 - view on LGTM.com new alerts:
|
@prgeor can you help to check my PR? it has been blocked for long time. Thanks! |
/azp list |
verification: root@belgite-r0:/home/admin# show platform fan Fantray1 green Fantray1_1 40% EXHAUST Present OK 2022051 1 10:11:28 Fantray1 green Fantray1_1 40% EXHAUST Present OK 20220511 10:11:28 PSU 1 FSP550-20FM S1131000293 N/A 12.29 1.98 25.50 OK green Product Name 0x21 5 E1070 (checksum valid) Ethernet0 Not present Ethernet1: SFP EEPROM not detected Ethernet2: SFP EEPROM not detected Ethernet3: SFP EEPROM not detected Ethernet4: SFP EEPROM not detected Ethernet5: SFP EEPROM not detected Ethernet6: SFP EEPROM not detected Ethernet7: SFP EEPROM not detected Ethernet8: SFP EEPROM not detected Ethernet9: SFP EEPROM not detected Ethernet10: SFP EEPROM not detected Ethernet11: SFP EEPROM not detected Ethernet12: SFP EEPROM not detected Ethernet13: SFP EEPROM not detected Ethernet14: SFP EEPROM not detected Ethernet15: SFP EEPROM not detected Ethernet16: SFP EEPROM not detected Ethernet17: SFP EEPROM not detected Ethernet18: SFP EEPROM not detected Ethernet19: SFP EEPROM not detected Ethernet20: SFP EEPROM not detected Ethernet21: SFP EEPROM not detected Ethernet22: SFP EEPROM not detected Ethernet23: SFP EEPROM not detected Ethernet24: SFP EEPROM not detected Ethernet25: SFP EEPROM not detected Ethernet26: SFP EEPROM not detected Ethernet27: SFP EEPROM not detected Ethernet28: SFP EEPROM not detected Ethernet29: SFP EEPROM not detected Ethernet30: SFP EEPROM not detected Ethernet31: SFP EEPROM not detected Ethernet32: SFP EEPROM not detected Ethernet33: SFP EEPROM not detected Ethernet34: SFP EEPROM not detected Ethernet35: SFP EEPROM not detected Ethernet36: SFP EEPROM not detected Ethernet37: SFP EEPROM not detected Ethernet38: SFP EEPROM not detected Ethernet39: SFP EEPROM not detected Ethernet40: SFP EEPROM not detected Ethernet41: SFP EEPROM not detected Ethernet42: SFP EEPROM not detected Ethernet43: SFP EEPROM not detected Ethernet44: SFP EEPROM not detected Ethernet45: SFP EEPROM not detected Ethernet46: SFP EEPROM not detected Ethernet47: SFP EEPROM not detected Ethernet48: SFP EEPROM detected Ethernet49: SFP EEPROM detected Ethernet50: SFP EEPROM detected Ethernet51: SFP EEPROM detected Ethernet52: SFP EEPROM detected Ethernet53: SFP EEPROM detected Ethernet54: SFP EEPROM detected Ethernet55: SFP EEPROM detected root@belgite-r0:/home/admin# show platform temperature LM75_U4 31 80.0 N/A 100 0.001 False 20220511 10:12:29 root@belgite-r0:/home/admin# show version SONiC Software Version: SONiC.Add_Belgite_support.0-65c02f41e Platform: x86_64-cel_belgite-r0 Docker images: root@belgite-r0:/home/admin# |
@Blueve Hi JinKan, please help to check, Thanks! |
Hi @sujinmkang , could you help review the PR again? Build and tests are both pass now |
@sujinmkang, Any update about this PR? Thanks! |
@Blueve, Do we merge this PR into master? Seems I have not seen my platform in the master branch? Thanks! |
@Blueve, Hi Jing, any problem about this PR? |
…anch Related work items: #52, #71, #73, #75, #77, sonic-net#1306, sonic-net#1588, sonic-net#1991, sonic-net#2031, sonic-net#2040, sonic-net#2053, sonic-net#2066, sonic-net#2069, sonic-net#2087, sonic-net#2107, sonic-net#2110, sonic-net#2112, sonic-net#2113, sonic-net#2117, sonic-net#2124, sonic-net#2125, sonic-net#2126, sonic-net#2128, sonic-net#2130, sonic-net#2131, sonic-net#2132, sonic-net#2133, sonic-net#2134, sonic-net#2135, sonic-net#2136, sonic-net#2137, sonic-net#2138, sonic-net#2139, sonic-net#2140, sonic-net#2143, sonic-net#2158, sonic-net#2161, sonic-net#2233, sonic-net#2243, sonic-net#2250, sonic-net#2254, sonic-net#2260, sonic-net#2261, sonic-net#2267, sonic-net#2278, sonic-net#2282, sonic-net#2285, sonic-net#2288, sonic-net#2289, sonic-net#2292, sonic-net#2294, sonic-net#8887, sonic-net#9279, sonic-net#9390, sonic-net#9511, sonic-net#9700, sonic-net#10025, sonic-net#10322, sonic-net#10479, sonic-net#10484, sonic-net#10493, sonic-net#10500, sonic-net#10580, sonic-net#10595, sonic-net#10628, sonic-net#10634, sonic-net#10635, sonic-net#10644, sonic-net#10670, sonic-net#10691, sonic-net#10716, sonic-net#10731, sonic-net#10750, sonic-net#10751, sonic-net#10752, sonic-net#10761, sonic-net#10769, sonic-net#10775, sonic-net#10776, sonic-net#10779, sonic-net#10786, sonic-net#10792, sonic-net#10793, sonic-net#10800, sonic-net#10806, sonic-net#10826, sonic-net#10839, sonic-net#10840, sonic-net#10842, sonic-net#10844, sonic-net#10847, sonic-net#10849, sonic-net#10852, sonic-net#10865, sonic-net#10872, sonic-net#10877, sonic-net#10886, sonic-net#10889, sonic-net#10903, sonic-net#10904, sonic-net#10905, sonic-net#10913, sonic-net#10914, sonic-net#10916, sonic-net#10919, sonic-net#10925, sonic-net#10926, sonic-net#10929, sonic-net#10933, sonic-net#10934, sonic-net#10937, sonic-net#10941, sonic-net#10947, sonic-net#10952, sonic-net#10953, sonic-net#10957, sonic-net#10959, sonic-net#10971, sonic-net#10972, sonic-net#10980
Why I did it
add celestica belgite platform
How I did it
add belgite platform in celestica
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)