[test_iface_namingmode] Adjusted the test according to the new buffer queue/pg counters optimization #6431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… queue/pg counters optimization Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
|
@vadymhlushko-mlnx should we merge this first or should we merge the swss fix first? please define the order |
You could merge, it will work without the |
neethajohn
approved these changes
Oct 10, 2022
wangxin
pushed a commit
that referenced
this pull request
Oct 21, 2022
… queue/pg counters optimization (#6431) Signed-off-by: Vadym Hlushko <vadymh@nvidia.com> What is the motivation for this PR? Because of the new implementation sonic-swss/pull/2432 from now on, there is a valid case if there are no multicast counters inside the COUNTERS_DB. In order for multicast counters to be presented in COUNTERS_DB the appropriate queues should be configured inside the CONFIG_DB (e.g "BUFFER_QUEUE|Ethernet14|7-8") How did you do it? Change the testcases - test_show_queue_counters, test_show_queue_persistent_watermark_multicast, test_show_queue_watermark_multicast
allen-xf
pushed a commit
to allen-xf/sonic-mgmt
that referenced
this pull request
Oct 28, 2022
… queue/pg counters optimization (sonic-net#6431) Signed-off-by: Vadym Hlushko <vadymh@nvidia.com> What is the motivation for this PR? Because of the new implementation sonic-swss/pull/2432 from now on, there is a valid case if there are no multicast counters inside the COUNTERS_DB. In order for multicast counters to be presented in COUNTERS_DB the appropriate queues should be configured inside the CONFIG_DB (e.g "BUFFER_QUEUE|Ethernet14|7-8") How did you do it? Change the testcases - test_show_queue_counters, test_show_queue_persistent_watermark_multicast, test_show_queue_watermark_multicast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Adjusted the test
test_iface_namingmode.pyaccording to the new buffer queue/pg counters optimizationFixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Because of the new implementation sonic-swss/pull/2432 from now on, there is a valid case if there are no multicast counters inside the COUNTERS_DB.
In order for multicast counters to be presented in
COUNTERS_DBthe appropriate queues should be configured inside theCONFIG_DB(e.g"BUFFER_QUEUE|Ethernet14|7-8")How did you do it?
Change the testcases -
test_show_queue_counters,test_show_queue_persistent_watermark_multicast,test_show_queue_watermark_multicastHow did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation