[counters] Improve performance by polling only configured ports buffer queue/pg counters #2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadymhlushko-mlnx
requested review from
neethajohn and
prsunny
as code owners
|
/azpw run |
|
/AzurePipelines run |
|
/azpw run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vadymhlushko-mlnx
force-pushed
the
master-buffer-queue-pg-counters
branch
from
b7990cd
to
a0af6aa
Compare
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vadymhlushko-mlnx
force-pushed
the
master-buffer-queue-pg-counters
branch
from
a0af6aa
to
916cd74
Compare
vadymhlushko-mlnx
force-pushed
the
master-buffer-queue-pg-counters
branch
from
916cd74
to
b59fd4f
Compare
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
…ured ports buffer queue/pg counters (sonic-net#2360)" (sonic-net#2458)" This reverts commit f0f1eb4.
vadymhlushko-mlnx
force-pushed
the
master-buffer-queue-pg-counters
branch
from
b59fd4f
to
80d7953
Compare
|
@liat-grozovik could you please approve? |
liat-grozovik
approved these changes
Oct 25, 2022
7 tasks
liat-grozovik
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Nov 10, 2022
Advance sonic-swss submodule to pick up new commits: dbdf31c [counters] Improve performance by polling only configured ports buffer queue/pg counters sonic-net/sonic-swss#2473 ab4f804 [portsorch] remove port OID from saiOidToAlias map on port deletion sonic-net/sonic-swss#2483 ab29920 [QoS] Support dynamic headroom calculation for Barefoot platforms sonic-net/sonic-swss#2412 15beee4 Add support for voq counters in portsorch. sonic-net/sonic-swss#2467 c8d4905 [vlanmgr] Disable arp_evict_nocarrier for vlan host intf sonic-net/sonic-swss#2469 31c9321 [chassis][voq]Collect counters for fabric links sonic-net/sonic-swss#1944 Signed-off-by: Kebo Liu <kebol@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f0f1eb47c4ae5359666a026f8b6d4b4d2d1838aa
Signed-off-by: Vadym Hlushko vadymh@nvidia.com
Propagating sonic-swss/pull/2143 with resolved merge conflicts
Depends on:
sonic-utilities/pull/2239
sonic-utilities/pull/2408
sonic-mgmt/pull/6431
What I did
Currently, in SONiC all ports queue and pg counters are created by default with the max possible amount of counters.
This feature changes this behavior to poll only configured counters provided by the config DB BUFFER_PG and BUFFER_QUEUE tables.
If no tables are present in the DB, no counters will be created for ports.
Filter the unwanted queues/pgs returned by SAI API calls and skip the creation of these queue/pg counters.
Also, allow creating/removing counters on runtime if buffer PG/Queue is configured or removed.
Why I did it
Improve performance by filtering unconfigured queue/pg counters on init.
How I verified it
Check after enabling the counters, if configured counters are created in Counters DB according to the configurations.
Add/Remove buffer PG/Queue configurations and observe the corresponding counters created/removed accordingly.
New UT was added to verify this flow.
Details if related