Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config_facts] Add port list member to PORTCHANNEL #7668

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

lolyu
Copy link
Contributor

@lolyu lolyu commented Mar 7, 2023

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

Fix KeyError when tests try to find member ports out of PORTCHANNEL in config_facts.
This is due to the removal of member array from PORTCHANNEL table:
sonic-net/sonic-buildimage#13660

How did you do it?

Add back the member ports array.

How did you verify/test it?

Run test_active_tor_shutdown_bgp_sessions_upstream over dualtor-mixed testbed.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@lolyu lolyu requested review from yxieca and bingwang-ms March 7, 2023 14:11
@wangxin
Copy link
Collaborator

wangxin commented Mar 7, 2023

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing ansible/library/config_facts.py

fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

ansible/library/config_facts.py:36:1: E302 expected 2 blank lines, found 1
ansible/library/config_facts.py:60:33: E225 missing whitespace around operator
ansible/library/config_facts.py:90:9: E303 too many blank lines (2)
ansible/library/config_facts.py:97:13: E265 block comment should start with '# '
ansible/library/config_facts.py:101:35: E201 whitespace after '{'
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@yxieca yxieca merged commit 08474da into sonic-net:master Mar 7, 2023
yxieca pushed a commit that referenced this pull request Mar 7, 2023
What is the motivation for this PR?
Fix KeyError when tests try to find member ports out of PORTCHANNEL in config_facts.
This is due to the removal of member array from PORTCHANNEL table:
sonic-net/sonic-buildimage#13660

How did you do it?
Add back the member ports array.

How did you verify/test it?
Run test_active_tor_shutdown_bgp_sessions_upstream over dualtor-mixed testbed.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants