Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[portchannel ]Fix bgp_gr_helper/iface_loopback action failure due to config_db change #7774

Closed
wants to merge 1 commit into from

Conversation

nhe-NV
Copy link
Contributor

@nhe-NV nhe-NV commented Mar 17, 2023

bgp_gr_* and iface_loopback_action* test failed due to "members" field removed by this PR: sonic-net/sonic-buildimage#13660

Description of PR

Summary: bgp_gr_* and iface_loopback_action* test failed due to "members" field removed by this PR: sonic-net/sonic-buildimage#13660
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

bgp_gr_* and iface_loopback_action* test failed due to "members" field removed by this PR: sonic-net/sonic-buildimage#13660

How did you do it?

How did you verify/test it?

Run the bgp_gr* test and the iface_loopback_action* cases, and they pass

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/bgp/test_bgp_gr_helper.py:107:5: F841 local variable 'portchannels' is assigned to but never used

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

…hange

The PR#13660 removed the 'members' key in "PORTCHANNEL" in config_db.json, need to align the test
@liat-grozovik
Copy link
Collaborator

@nhe-NV could you please help to resolve conflicts?

@ZhaohuiS
Copy link
Contributor

ZhaohuiS commented Mar 22, 2023

@nhe-NV , @wangxin @liat-grozovik I think this PR #7668 should fix the issue you mentioned.
It's a common fix for all related test cases which use member of portchannel.

@nhe-NV
Copy link
Contributor Author

nhe-NV commented Apr 10, 2023

@nhe-NV , @wangxin @liat-grozovik I think this PR #7668 should fix the issue you mentioned. It's a common fix for all related test cases which use member of portchannel.

Thanks @ZhaohuiS I will close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants