Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sonic_sfp] Extend sfpbase to get more info from SFP eeprom for xcvrd #22

Merged
merged 4 commits into from
Mar 25, 2019
Merged

[sonic_sfp] Extend sfpbase to get more info from SFP eeprom for xcvrd #22

merged 4 commits into from
Mar 25, 2019

Conversation

keboliu
Copy link
Collaborator

@keboliu keboliu commented Feb 14, 2019 •
edited
Loading 

sonic_sfp: Extend sfputilbase to support xcvrd get more fields from SFP eeprom.

* Extends sff8446 and sff8472 with more fields parsing functions.
* Extend sfputilbase to return more fields to xcvrd.
* Add handling for OSFP. 
  
  Signed-off-by: Kebo Liu kebol@mellanox.com

@jleveque
Copy link
Contributor

Please fix conflicts.

@keboliu
Copy link
Collaborator Author

keboliu commented Feb 22, 2019

@jleveque conflicts fixed and added special treatment for OSFP to avoid xcvrd fail. OSFP transceiver info memory map not fully defined in newly added inf8628.py, it's also lack of DOM memory map definition. Since I don't have a platform that supports OSFP, I would like to add the fully support for it later or someone can also add it.

This was referenced Feb 26, 2019
Merged
Merged
@keboliu
Copy link
Collaborator Author

keboliu commented Mar 1, 2019 •
edited
Loading

@lguohan joe requesting you for a review, would you please take a look?

@nazariig nazariig mentioned this pull request Mar 15, 2019
Merged
@liat-grozovik
Copy link
Collaborator

@lguohan can you please review?

@lguohan lguohan merged commit 4944a64 into sonic-net:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

@jleveque jleveque jleveque approved these changes

Assignees
No one assigned
Labels
Enhancement Transceiver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@keboliu @jleveque @liat-grozovik @lguohan