Fixed xcvrd shutdown flow #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
approved these changes
Feb 22, 2019
liat-grozovik
requested changes
Feb 24, 2019
keboliu
reviewed
Feb 25, 2019
sonic-xcvrd/scripts/xcvrd
Outdated
| # del sfp and dom info from db | ||
| def del_port_sfp_dom_info_to_db(logical_port_name, int_tbl, dom_tbl): | ||
| # update port dom/sfp info in db | ||
| def post_port_sfp_dom_info_to_db(): |
There was a problem hiding this comment.
rename to "del_port_sfp_dom_info_from_db"?
There was a problem hiding this comment.
@keboliu please have a look at line 328:
# delete port dom/sfp info from db
def del_port_sfp_dom_info_from_db(logical_port_name, int_tbl, dom_tbl):
keboliu
reviewed
Feb 25, 2019
keboliu
reviewed
Feb 25, 2019
sonic-xcvrd/scripts/xcvrd
Outdated
| dom_info_update = dom_info_update_task(dom_tbl) | ||
| dom_info_update.task_run() | ||
| while RUN: | ||
| time.sleep(TIMEOUT_SECS) |
There was a problem hiding this comment.
main task is idling, original design using the main task to listen to the sfp change event, can we reduce one thread here? have you compared the time consuming of xvrd before and after, any significant increase?
There was a problem hiding this comment.
@keboliu before changes on stop ~10 sec, after changes ~1 sec.
The idea is to use main daemon process to:
- Do init
- Handle signals
- Manage tasks
- Do deinit
This is a different architecture approach.
|
Please fix new conflicts. |
|
@jleveque will do. |
keboliu
approved these changes
Mar 8, 2019
nazariig
force-pushed
the
master-improve-xcvrd-shutdown
branch
from
fd1e078
to
aee8250
Compare
|
@jleveque done. |
jleveque
approved these changes
Mar 19, 2019
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
nazariig
force-pushed
the
master-improve-xcvrd-shutdown
branch
from
aee8250
to
13c1f22
Compare
|
@andriymoroz-mlnx please help to review and merge. |
liat-grozovik
approved these changes
Mar 24, 2019
andriymoroz-mlnx
approved these changes
Mar 26, 2019
mykolaf
approved these changes
Mar 26, 2019
vdahiya12
pushed a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nazarii Hnydyn nazariig@mellanox.com
xcvrd shutdown flow is broken due to a platform_sfputil.get_transceiver_change_event() blocking call which uses epoll_wait. This function affects process signal mask and signal handlers are not getting called.
- What I did
- How I did it
- How to verify it
- Description for the changelog