[chassisd] Monitor midplane status #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
suggested changes
Dec 2, 2020
|
Please fix conflicts |
Done. Thanks. |
|
@Staphylo: Please review, also. |
Staphylo
reviewed
Dec 16, 2020
Monitor the status of line-cards from supervisor Monitor the status of supervisor from line-cards
mprabhu-nokia
force-pushed
the
nokia-midplane-pr
branch
from
a1bd2de
to
c287b3a
Compare
Staphylo
approved these changes
Dec 16, 2020
jleveque
suggested changes
Dec 16, 2020
jleveque
approved these changes
Dec 16, 2020
jleveque
changed the title
sujinmkang
pushed a commit
to sujinmkang/sonic-platform-daemons
that referenced
this pull request
Jan 16, 2021
Enhance chassisd to monitor midplane status of the cards in modular chassis HLD: sonic-net/SONiC#646 -What I did Add monitoring of the midplane or internal ethernet network between supervisor and line-card modules. -How I did it Along with status monitoring, also monitor the midplane reachability between supervisor and modules. It updates the STATE_DB with the status information. 'show chassis-modules midplane-status' will read from the STATE_DB
vdahiya12
pushed a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
The `string` type has changed between Python 2 and 3. Therefore, the Python 3 version of this library is broken. This PR changes the data type of the raw EEPROM data to a `bytearray`, which is treated the same in both Python 2 and Python 3, and is technically a more appropriate data type for the raw bytes anyway. However, this PR could cause issues if any vendors are overriding the `read_eeprom_bytes()` or `read_eeprom()` functions and returning a `string`. Any vendors doing so will need to refactor their implementation to return a `bytearray` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance chassisd to monitor midplane status of the cards in modular chassis
HLD: sonic-net/SONiC#646
-What I did
Add monitoring of the midplane or internal ethernet network between supervisor and line-card modules.
-How I did it
Along with status monitoring, also monitor the midplane reachability between supervisor and modules.
It updates the STATE_DB with the status information. 'show chassis-modules midplane-status' will read from the STATE_DB
-How I verified it
With UT and platform specific validation
CLI output
sonic-net/sonic-utilities#1267
UT output