-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[voq/inbandif] Voq inbandif port #145
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vganesan-nokia
force-pushed
the
voq-inbandif-port
branch
from
January 26, 2021 03:04
0f3b236
to
8960ad8
Compare
ngoc-do
previously approved these changes
Feb 8, 2021
vganesan-nokia
force-pushed
the
voq-inbandif-port
branch
2 times, most recently
from
February 17, 2021 19:56
a3d1b8e
to
ccdd347
Compare
abdosi
previously approved these changes
Mar 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/Azurepipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
4 tasks
@ngoc-do - please re-approve |
ngoc-do
previously approved these changes
Mar 22, 2021
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com> Inband port is avaialable in PORT table. But regular port handlings are not applicable for Inband port. Changes in this PR are to avoid regular port handling on Inband port.
vganesan-nokia
force-pushed
the
voq-inbandif-port
branch
from
April 8, 2021 00:02
ccdd347
to
a04112f
Compare
abdosi
approved these changes
Apr 9, 2021
vdahiya12
pushed a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
Fix crash in `show version` CLI command: ``` admin@sonic:~$ show version SONiC Software Version: SONiC.master.39-dirty-20201116.030425 Distribution: Debian 10.6 Kernel: 4.19.0-9-2-amd64 Build commit: e526d88 Build date: Mon Nov 16 06:49:50 UTC 2020 Built by: johnar@jenkins-worker-4Platform: x86_64-accton_wedge100bf_32x-r0 HwSKU: montara ASIC: barefoot Traceback (most recent call last): File "/usr/local/bin/decode-syseeprom", line 171, in <module> exit(main()) File "/usr/local/bin/decode-syseeprom", line 47, in main t = class_('board', '','','') File "/usr/share/sonic/device/x86_64-accton_wedge100bf_32x-r0/plugins/eeprom.py", line 104, in __init__ if self.eeprom_init(): File "/usr/share/sonic/device/x86_64-accton_wedge100bf_32x-r0/plugins/eeprom.py", line 167, in eeprom_init new_e = eeprom_tlvinfo.TlvInfoDecoder.set_eeprom(self, "", [eeprom_params]) File "/usr/local/lib/python2.7/dist-packages/sonic_eeprom/eeprom_tlvinfo.py", line 173, in set_eeprom (tlv_found, index) = self.get_tlv_index(new_tlvs, k) File "/usr/local/lib/python2.7/dist-packages/sonic_eeprom/eeprom_tlvinfo.py", line 454, in get_tlv_index if not self.is_valid_tlv(e[tlv_index:]): File "/usr/local/lib/python2.7/dist-packages/sonic_eeprom/eeprom_tlvinfo.py", line 255, in is_valid_tlv return (len(e) >= 2 and (2 + e[1] <= len(e))) TypeError: unsupported operand type(s) for +: 'int' and 'str' Serial Number: ............ ``` Signed-off-by: Petro Bratash <petrox.bratash@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inband port is avaialable in PORT table. But regular port handlings are
not applicable for Inband port. Changes in this PR are to avoid regular
port handling on Inband port.
This PR depends on sonic-buildimage PR sonic-net/sonic-buildimage#6477