Fixed bug in chassisd causing incorrect number of ASICs in CHASSIS_STATE_DB #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you please add some UT for this? |
Done |
prgeor
approved these changes
Dec 1, 2024
arlakshm
approved these changes
Dec 1, 2024
rlhui
changed the title
mssonicbld
pushed a commit
to mssonicbld/sonic-platform-daemons
that referenced
this pull request
Dec 4, 2024
…ATE_DB (sonic-net#560) Fixed the bug in chassisd due to which incorrect number of ASICs were being pushed to CHASSIS_STATE_DB.
|
Cherry-pick PR to 202405: #569 |
mssonicbld
pushed a commit
that referenced
this pull request
Dec 5, 2024
…ATE_DB (#560) Fixed the bug in chassisd due to which incorrect number of ASICs were being pushed to CHASSIS_STATE_DB.
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
mlok-nokia
reviewed
Dec 5, 2024
| @@ -353,6 +357,7 @@ class ModuleUpdater(logger.Logger): | |||
|
|
|||
| # In line card push the hostname of the module and num_asics to the chassis state db. | |||
| # The hostname is used as key to access chassis app db entries | |||
| module_info_dict = self._get_module_info(my_index) | |||
There was a problem hiding this comment.
we should move line 360 after the line361. Only call it when it is not Supervisor
|
Hi @vivekverma-arista, this PR is causing an issue on Nokia 7250 chassis. See : sonic-net/sonic-buildimage#21131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the bug in chassisd due to which incorrect number of ASICs were being pushed to CHASSIS_STATE_DB.
Motivation and Context
Fixes: #559
How Has This Been Tested?
Checked on
Arista 7804R3-FMplatform withArista 7800R3A-36DM2-C36linecard inserted which has 2 ASICsAdded a unit test for forwarding ASICs to test the same.
Additional Information (Optional)