Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add queuestat changes for aggregate VOQ counters #3617

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vivekverma-arista
Copy link

@vivekverma-arista vivekverma-arista commented Nov 14, 2024

What I did

Add queuestat changes for aggregate VOQ counters.

How I did it

Existing CLI show queue counters --voq is being implemented for supervisor. This will access all the ASIC database instances on every linecard which are now exposed to midplane network by this PR20803 and sum up counters for each VOQ.

Also depends on #560

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@kenneth-arista
Copy link
Contributor

@arlakshm for awareness

@kenneth-arista
Copy link
Contributor

Tracking issue: sonic-net/SONiC#1543

@vmittal-msft
Copy link
Contributor

@vivekverma-arista

  1. Please share output from supervisor as well as line card using one port/voq as an example.
  2. Do we have separate PR for clear counter ?
  3. Did we check if queuestat still works for non chassis ?

@vmittal-msft vmittal-msft requested a review from arlakshm December 5, 2024 18:46
@vmittal-msft
Copy link
Contributor

Otherwise changes looks ok to me.

@vivekverma-arista
Copy link
Author

@vivekverma-arista

  1. Please share output from supervisor as well as line card using one port/voq as an example.
  2. Do we have separate PR for clear counter ?
  3. Did we check if queuestat still works for non chassis ?

Hi @vmittal-msft, I will answer/address these points. Meanwhile could you also take a look at another related PR sonic-net/sonic-buildimage#20803 and confirm that the approach is okay so that we can start making progress with unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants