Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zmq function failed with EINTR errno when log rotation happened #1106

Closed
mint570 opened this issue Aug 19, 2022 · 2 comments · Fixed by #1109
Closed

Zmq function failed with EINTR errno when log rotation happened #1106

mint570 opened this issue Aug 19, 2022 · 2 comments · Fixed by #1109

Comments

@mint570
Copy link
Contributor

mint570 commented Aug 19, 2022 •
edited
Loading

In orchagent, the SIGHUP handler is used for log rotation purpose. When signaling happens, zmq functions might fail with EINTR errno.
We should do retry in ZeroMQChannel.cpp if zmq functions fail with EINTR.
@mint570 mint570 mentioned this issue Aug 22, 2022
Merged
@kcudnik
Copy link
Collaborator

kcudnik commented Aug 22, 2022

when did you catched this ?

@mint570
Copy link
Contributor Author

mint570 commented Aug 22, 2022

when did you catched this ?

We recently enabled zmq in our device and found this issue.

@kcudnik kcudnik closed this as completed in e8a01a8 Sep 2, 2022
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this issue Nov 18, 2022
@mint570
Add retry on zmq functions if fail with EINTR. (sonic-net#1109)
9b2709f 
Fixed sonic-net#1106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add retry on zmq functions if fail with EINTR. mint570/sonic-sairedis
2 participants
@kcudnik @mint570