Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry on zmq functions if fail with EINTR. #1109

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Conversation

mint570
Copy link
Contributor

@mint570 mint570 commented Aug 22, 2022

Fixed #1106

@kcudnik
Copy link
Collaborator

kcudnik commented Aug 22, 2022

please fix build errors

@mint570
Copy link
Contributor Author

mint570 commented Aug 22, 2022

Build was fine but the vs test failed.
I didn't know that the sairedis repo also run the vs test.

The vs test failure is most likely sonic-net/sonic-swss#2330.
Recently we submitted sonic-net/sonic-swss#2237, which added a few more pytests. Without the fix, vs test will almost guarantee fail.

Also, about code coverage, I don't think zmq is enabled in vs test. So after we fix the vs test, this PR might still fail in code coverage.

@mint570
Copy link
Contributor Author

mint570 commented Aug 22, 2022

Correction.
sonic-net/sonic-swss#2330 shouldn't be the issue for sairedis because coverage is not enabled here.
Will re-run the test and see.
I don't think zmq is enabled in vs docker. So this change should have zero impact on the vs test.

@kcudnik
Copy link
Collaborator

kcudnik commented Aug 23, 2022

you dont need entire VS for testing, you can use unittests and test only zmqchannel class, check in sairedis/unitests/ directory

Change-Id: I9f2066b1cfc6f1431189c7f939fbb893d1bea8dd
Change-Id: I8cbe5e7bc036f64a9c1ea0006d2baf89f3cd1bd2
@mint570
Copy link
Contributor Author

mint570 commented Aug 29, 2022

@kcudnik
This PR is ready. Please take a look.

@mint570
Copy link
Contributor Author

mint570 commented Sep 2, 2022

@kcudnik can this PR be merged now?

@kcudnik kcudnik merged commit e8a01a8 into sonic-net:master Sep 2, 2022
mlorrillere added a commit to mlorrillere/sonic-buildimage that referenced this pull request Sep 8, 2022
* 660a920 [Chassis] Create fabric ports for switch_type fabric. (sonic-net/sonic-sairedis#1114)
* 8140c22 Fix issue: bulk counter feature cannot compile on platforms having no sai_bulk_object_get_stats/sai_bulk_object_clear_stats (sonic-net/sonic-sairedis#1105)
* 0aa60f5 [lgtm] Add uuid library (sonic-net/sonic-sairedis#1119)
* e8a01a8 Add retry on zmq functions if fail with EINTR. (sonic-net/sonic-sairedis#1109)
* 594b242 Add SAI_PORT_ATTR_OPER_SPEED support (sonic-net/sonic-sairedis#1107)
* 4c9e048 Add Xsight specific syncd start options (sonic-net/sonic-sairedis#1112)
* da26ace Run 20 vs tests at a time. (sonic-net/sonic-sairedis#1111)
* ffc4109 [asan] suppress the static variable leaks (sonic-net/sonic-sairedis#1085)
* bfd37e3 [sonic-sairedis] Support bulk counter (sonic-net/sonic-sairedis#1094)
* 90ba09a Transfer organization from Azure to sonic-net (sonic-net/sonic-sairedis#1095)
* 4853881 [BFN] Provide unified approach to select P4 profile based on chip family (sonic-net/sonic-sairedis#1089)
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zmq function failed with EINTR errno when log rotation happened
2 participants