-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retry on zmq functions if fail with EINTR. #1109
Conversation
please fix build errors |
Build was fine but the vs test failed. The vs test failure is most likely sonic-net/sonic-swss#2330. Also, about code coverage, I don't think zmq is enabled in vs test. So after we fix the vs test, this PR might still fail in code coverage. |
Correction. |
you dont need entire VS for testing, you can use unittests and test only zmqchannel class, check in sairedis/unitests/ directory |
a9469e8
to
4424daf
Compare
Change-Id: I9f2066b1cfc6f1431189c7f939fbb893d1bea8dd
Change-Id: I8cbe5e7bc036f64a9c1ea0006d2baf89f3cd1bd2
@kcudnik |
@kcudnik can this PR be merged now? |
* 660a920 [Chassis] Create fabric ports for switch_type fabric. (sonic-net/sonic-sairedis#1114) * 8140c22 Fix issue: bulk counter feature cannot compile on platforms having no sai_bulk_object_get_stats/sai_bulk_object_clear_stats (sonic-net/sonic-sairedis#1105) * 0aa60f5 [lgtm] Add uuid library (sonic-net/sonic-sairedis#1119) * e8a01a8 Add retry on zmq functions if fail with EINTR. (sonic-net/sonic-sairedis#1109) * 594b242 Add SAI_PORT_ATTR_OPER_SPEED support (sonic-net/sonic-sairedis#1107) * 4c9e048 Add Xsight specific syncd start options (sonic-net/sonic-sairedis#1112) * da26ace Run 20 vs tests at a time. (sonic-net/sonic-sairedis#1111) * ffc4109 [asan] suppress the static variable leaks (sonic-net/sonic-sairedis#1085) * bfd37e3 [sonic-sairedis] Support bulk counter (sonic-net/sonic-sairedis#1094) * 90ba09a Transfer organization from Azure to sonic-net (sonic-net/sonic-sairedis#1095) * 4853881 [BFN] Provide unified approach to select P4 profile based on chip family (sonic-net/sonic-sairedis#1089)
Fixed #1106