Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Xsight specific syncd start options #1112

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Add Xsight specific syncd start options #1112

merged 1 commit into from
Sep 1, 2022

Conversation

deran1980
Copy link
Contributor

Signed-off-by: Roman Zhurakivsky rzhurak@larch-networks.com

What I did
Added xsight platform specific options for syncd common

How I did it

Modify syncd_init_common.sh script. added a function to support xsight based platforms.

How to verify it
Verify on Accton platform (based on Xsight ASIC)

@z80x1
Add Xsight specific syncd start options
78b0ec5 
Signed-off-by: Roman Zhurakivsky <rzhurak@larch-networks.com>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 23, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@deran1980
Copy link
Contributor Author

Hi @kcudnik - is it going to be merged or we need to wait for sairedis master branch to pass all pipelines tests?

@kcudnik
Copy link
Collaborator

kcudnik commented Aug 25, 2022

can you fix tests failure?

@deran1980
Copy link
Contributor Author

Guess not...
I can try helping review the failures but it was not introduced as part of this PR.

@deran1980
Copy link
Contributor Author

/azpw run Azure.sonic-sairedis

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-sairedis

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@deran1980
Copy link
Contributor Author

/azpw run Azure.sonic-sairedis

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-sairedis

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@deran1980
Copy link
Contributor Author

/azpw run Azure.sonic-sairedis

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-sairedis

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@deran1980
Copy link
Contributor Author

Hi @kcudnik - I ran the jobs several times and it seems very unstable.
it always fails as you can see, but every time it fails on different test cases.
is there a general issue with the stability of the tests or this is a real issue in current master tests that needs to be fixed?
the reason I am asking is because I can see from time to time that there are PRs which are able to pass all tests.

@kcudnik
Copy link
Collaborator

kcudnik commented Aug 31, 2022

yes, those test could be very unstable, rest is good so i approve and you can merge

@deran1980
Copy link
Contributor Author

Hi @kcudnik thanks!
But I don't think I have permission to perform merge so I will appreciate if you can merge it.
Thanks.

@kcudnik kcudnik merged commit 4c9e048 into sonic-net:master Sep 1, 2022
@mlorrillere mlorrillere mentioned this pull request Sep 7, 2022
Closed
mlorrillere added a commit to mlorrillere/sonic-buildimage that referenced this pull request Sep 8, 2022
@mlorrillere
[submodule] update sonic-sairedis
d0bf948 
* 660a920 [Chassis] Create fabric ports for switch_type fabric. (sonic-net/sonic-sairedis#1114)
* 8140c22 Fix issue: bulk counter feature cannot compile on platforms having no sai_bulk_object_get_stats/sai_bulk_object_clear_stats (sonic-net/sonic-sairedis#1105)
* 0aa60f5 [lgtm] Add uuid library (sonic-net/sonic-sairedis#1119)
* e8a01a8 Add retry on zmq functions if fail with EINTR. (sonic-net/sonic-sairedis#1109)
* 594b242 Add SAI_PORT_ATTR_OPER_SPEED support (sonic-net/sonic-sairedis#1107)
* 4c9e048 Add Xsight specific syncd start options (sonic-net/sonic-sairedis#1112)
* da26ace Run 20 vs tests at a time. (sonic-net/sonic-sairedis#1111)
* ffc4109 [asan] suppress the static variable leaks (sonic-net/sonic-sairedis#1085)
* bfd37e3 [sonic-sairedis] Support bulk counter (sonic-net/sonic-sairedis#1094)
* 90ba09a Transfer organization from Azure to sonic-net (sonic-net/sonic-sairedis#1095)
* 4853881 [BFN] Provide unified approach to select P4 profile based on chip family (sonic-net/sonic-sairedis#1089)
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
@deran1980 @z80x1
Add Xsight specific syncd start options (sonic-net#1112)
ad148c6 
Signed-off-by: Roman Zhurakivsky <rzhurak@larch-networks.com>

Signed-off-by: Roman Zhurakivsky <rzhurak@larch-networks.com>
Co-authored-by: Roman Zhurakivskyy <rzhurak@larch-networks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcudnik kcudnik kcudnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deran1980 @kcudnik @mssonicbld @z80x1