[counter]: support enable/disable counter query #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sihui Han <sihan@microsoft.com>
|
Depends on sonic-net/sonic-swss-common#202 |
|
retest this please |
|
Is it possible to make the counters disabled by default? |
pavel-shirshov
suggested changes
Jun 8, 2018
syncd/syncd_flex_counter.h
Outdated
| @@ -119,6 +123,7 @@ class FlexCounter | |||
|
|
|||
| uint32_t m_pollInterval = 0; | |||
| std::string m_instanceId; | |||
| bool m_enable = true; | |||
There was a problem hiding this comment.
Hi Sihui,
Can you please make it disabled by default?
Signed-off-by: Sihui Han <sihan@microsoft.com>
pavel-shirshov
approved these changes
Jun 8, 2018
|
retest this please |
2 similar comments
|
retest this please |
|
retest this please |
|
retest this please |
lguohan
pushed a commit
that referenced
this pull request
Jun 25, 2018
* [counter]: support enable/disable counter query Signed-off-by: Sihui Han <sihan@microsoft.com> * Set counter polling by default disabled Signed-off-by: Sihui Han <sihan@microsoft.com>
volodymyrsamotiy
pushed a commit
to volodymyrsamotiy/sonic-sairedis
that referenced
this pull request
Jul 30, 2019
* [counter]: support enable/disable counter query Signed-off-by: Sihui Han <sihan@microsoft.com> * Set counter polling by default disabled Signed-off-by: Sihui Han <sihan@microsoft.com>
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
* [counter]: support enable/disable counter query Signed-off-by: Sihui Han <sihan@microsoft.com> * Set counter polling by default disabled Signed-off-by: Sihui Han <sihan@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sihui Han sihan@microsoft.com