[counter]: add support to enable/disable counter query #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sihui Han <sihan@microsoft.com>
|
depends on sonic-net/sonic-swss-common#202 and sonic-net/sonic-sairedis#322 |
|
retest this please |
lguohan
reviewed
May 25, 2018
| @@ -61,13 +62,22 @@ void FlexCounterOrch::doTask(Consumer &consumer) | |||
| const auto &field = fvField(valuePair); | |||
| const auto &value = fvValue(valuePair); | |||
|
|
|||
| if (field == POLL_INTERVAL_FIELD) | |||
| if (field == POLL_INTERVAL_FIELD) | |||
There was a problem hiding this comment.
I do not recall we need the FIELD suffix now, when did we introduce them?
There was a problem hiding this comment.
They were introduced before. I can have a separate PR to clean it up later if that is preferred
lguohan
pushed a commit
that referenced
this pull request
Jun 25, 2018
Signed-off-by: Sihui Han <sihan@microsoft.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
* In sync with our latest change, where we default failthrough to be False. Reference: Pull request sonic-net#2746 * Loading minigraph, flushes DB, which is not sent as updates to hostcfgd. So stop hostcfgd before load and restart after load, to be able to act in sync with updated CONFIG-DB.
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sihui Han sihan@microsoft.com
What I did
Add support to enable/disable counter query
Why I did it
Add the flexibility to enable or disable counter query.
How I verified it
Tested on DUT
Details if related