Move QoS configuration to config DB #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
This was referenced Nov 10, 2017
yxieca
requested changes
Nov 20, 2017
There was a problem hiding this comment.
Looks like you need to take 3 steps for this change:
- Adding new fields (CFG_) that you need. But keep the old APP_ for now, You can group them together and add a comment for future deprecation if you like to.
- Once this review is in, test for Removed DB specific get api's from Selectable class #378 could pass. Then we can merge that review.
- Then you can create another PR to remove the old APP_* entries.
Without doing this in small steps, i don't think PR #378 would pass test. Unless someone can ignore test result and merge it, we are stuck.
Regards,
Ying
yxieca
approved these changes
Nov 20, 2017
|
Discussed with Shuotian, this review doesn't have to be broken into 2. However, #1162 needs to include submodule updates to avoid build failure. |
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Moroz c_andriym@mellanox.com
See also:
sonic-net/sonic-buildimage#1162
sonic-net/sonic-swss#378