Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Mellanox QoS configuration to config DB #1162

Merged
merged 7 commits into from
Nov 20, 2017

Conversation

andriymoroz-mlnx
Copy link
Collaborator

Signed-off-by: Andriy Moroz c_andriym@mellanox.com

- What I did
Moved QoS config to config DB

FOR REVIEW AND DISCUSSION
PLEASE DO NOT MERGE
See also:
sonic-net/sonic-swss-common#158
sonic-net/sonic-swss#378

Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
@andriymoroz-mlnx
Copy link
Collaborator Author

The beginning is here: #1138

"red_max_threshold":"516096",
"red_min_threshold":"516096",
"yellow_max_threshold":"516096",
"yellow_min_threshold":"516096
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need one more comma

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and the closing quotes... thanks

Copy link
Contributor

@yxieca yxieca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you going to move other qos.json files in this review or in a different review?

Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
@andriymoroz-mlnx
Copy link
Collaborator Author

Added qos config for:

platform: x86_64-dell_s6000_s1220-r0, hwsku: Force10-S6000 and Force10-S6000-Q32
platform: x86_64-dell_s6100_c2538-r0, hwsku: Force10-S6100
platform: x86_64-arista_7050_qx32, hwsku: Arista-7050-QX32

that's all what is publicly available

@stcheng stcheng merged this pull request into sonic-net:master Nov 20, 2017
@stcheng
Copy link
Contributor

stcheng commented Nov 20, 2017

@andriymoroz-mlnx sorry i accidentally merged this commit. i've reverted it.
Please reopen a new pull request of this one along with the submodule changes including both swss and swss-common repository.
sorry for the inconvenience
thank you

@andriymoroz-mlnx
Copy link
Collaborator Author

ok, I will reopen it after sub-modules pointers update

lguohan added a commit to lguohan/sonic-buildimage that referenced this pull request Oct 13, 2020
* b6af9f4 2020-10-12 | Fix expected neighbor when multiple ports connect to same neighbor (sonic-net#1162) [lguohan]
* a71c72b 2020-10-12 | [show] Add 'show' CLI for system-health feature (sonic-net#971) [shlomibitton]
* 561d133 2020-10-10 | [README.md] Add instructions for setting up a build/test environment (sonic-net#1161) [Joe LeVeque]

Signed-off-by: Guohan Lu <lguohan@gmail.com>
@lguohan lguohan mentioned this pull request Oct 13, 2020
3 tasks
lguohan added a commit that referenced this pull request Oct 13, 2020
* b6af9f4 2020-10-12 | Fix expected neighbor when multiple ports connect to same neighbor (#1162) [lguohan]
* a71c72b 2020-10-12 | [show] Add 'show' CLI for system-health feature (#971) [shlomibitton]
* 561d133 2020-10-10 | [README.md] Add instructions for setting up a build/test environment (#1161) [Joe LeVeque]

Signed-off-by: Guohan Lu <lguohan@gmail.com>
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
* b6af9f4 2020-10-12 | Fix expected neighbor when multiple ports connect to same neighbor (sonic-net#1162) [lguohan]
* a71c72b 2020-10-12 | [show] Add 'show' CLI for system-health feature (sonic-net#971) [shlomibitton]
* 561d133 2020-10-10 | [README.md] Add instructions for setting up a build/test environment (sonic-net#1161) [Joe LeVeque]

Signed-off-by: Guohan Lu <lguohan@gmail.com>
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
…onic-net#1162)


Previous code only enumerate on distinct neighbors, thus only one
port is shown for a neighbor.

Signed-off-by: Guohan Lu <lguohan@gmail.com>
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
* using PRI instead of %l to support 32 bit arch
Yakiv-Huryk added a commit to Yakiv-Huryk/sonic-buildimage that referenced this pull request Jan 3, 2023
Update sonic-sairedis submodule pointer to include the following:

0994449 [asan] suppress the static variable leaks (sonic-net#1085) (sonic-net#1159)
6fc86a9 Switch to using stock gcovr 5.2 (sonic-net#1174) (sonic-net#1190)
e7ded51 Create fabric ports for switch_type fabric (sonic-net#1189)
f498261 * Add Voqs to Virtual Switch (sonic-net#1162)

Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
liat-grozovik pushed a commit that referenced this pull request Jan 3, 2023
Update sonic-sairedis submodule pointer to include the following:

0994449 [asan] suppress the static variable leaks (#1085) (#1159)
6fc86a9 Switch to using stock gcovr 5.2 (#1174) (#1190)
e7ded51 Create fabric ports for switch_type fabric (#1189)
f498261 * Add Voqs to Virtual Switch (#1162)

Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants