-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Mellanox QoS configuration to config DB #1162
Conversation
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
The beginning is here: #1138 |
"red_max_threshold":"516096", | ||
"red_min_threshold":"516096", | ||
"yellow_max_threshold":"516096", | ||
"yellow_min_threshold":"516096 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need one more comma
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and the closing quotes... thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you going to move other qos.json files in this review or in a different review?
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
Added qos config for:
that's all what is publicly available |
@andriymoroz-mlnx sorry i accidentally merged this commit. i've reverted it. |
ok, I will reopen it after sub-modules pointers update |
* b6af9f4 2020-10-12 | Fix expected neighbor when multiple ports connect to same neighbor (sonic-net#1162) [lguohan] * a71c72b 2020-10-12 | [show] Add 'show' CLI for system-health feature (sonic-net#971) [shlomibitton] * 561d133 2020-10-10 | [README.md] Add instructions for setting up a build/test environment (sonic-net#1161) [Joe LeVeque] Signed-off-by: Guohan Lu <lguohan@gmail.com>
* b6af9f4 2020-10-12 | Fix expected neighbor when multiple ports connect to same neighbor (#1162) [lguohan] * a71c72b 2020-10-12 | [show] Add 'show' CLI for system-health feature (#971) [shlomibitton] * 561d133 2020-10-10 | [README.md] Add instructions for setting up a build/test environment (#1161) [Joe LeVeque] Signed-off-by: Guohan Lu <lguohan@gmail.com>
* b6af9f4 2020-10-12 | Fix expected neighbor when multiple ports connect to same neighbor (sonic-net#1162) [lguohan] * a71c72b 2020-10-12 | [show] Add 'show' CLI for system-health feature (sonic-net#971) [shlomibitton] * 561d133 2020-10-10 | [README.md] Add instructions for setting up a build/test environment (sonic-net#1161) [Joe LeVeque] Signed-off-by: Guohan Lu <lguohan@gmail.com>
…onic-net#1162) Previous code only enumerate on distinct neighbors, thus only one port is shown for a neighbor. Signed-off-by: Guohan Lu <lguohan@gmail.com>
* using PRI instead of %l to support 32 bit arch
Update sonic-sairedis submodule pointer to include the following: 0994449 [asan] suppress the static variable leaks (sonic-net#1085) (sonic-net#1159) 6fc86a9 Switch to using stock gcovr 5.2 (sonic-net#1174) (sonic-net#1190) e7ded51 Create fabric ports for switch_type fabric (sonic-net#1189) f498261 * Add Voqs to Virtual Switch (sonic-net#1162) Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
Update sonic-sairedis submodule pointer to include the following: 0994449 [asan] suppress the static variable leaks (#1085) (#1159) 6fc86a9 Switch to using stock gcovr 5.2 (#1174) (#1190) e7ded51 Create fabric ports for switch_type fabric (#1189) f498261 * Add Voqs to Virtual Switch (#1162) Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
Signed-off-by: Andriy Moroz c_andriym@mellanox.com
- What I did
Moved QoS config to config DB
FOR REVIEW AND DISCUSSION
PLEASE DO NOT MERGE
See also:
sonic-net/sonic-swss-common#158
sonic-net/sonic-swss#378