[vstest] VS test failure fix after fabric port orch PR merge #1811

vganesan-nokia · 2021-06-29T04:19:44Z

What I did

In tests/conftest.py Set the FABRIC_NUM_PORTS to 16. This is required since addition of
fabric port orch adds 16 fabrics in asic db internally.
in tests/test_virtual_chassis.py added back the skipped tests

Why I did it

Fix for virtual chassis tests failure issue #1809

How I verified it

With sonic-buildimage PR sonic-net/sonic-buildimage#8008, run the vs test. All tests from test_virtual_chassis.py should pass consistently

Details if related

This PR is dependent on sonic-buildimage PR sonic-net/sonic-buildimage#8008

lgtm-com · 2021-06-29T04:25:19Z

This pull request introduces 1 alert when merging 7368697 into 6c88e47 - view on LGTM.com

new alerts:

1 for Unused import

vganesan-nokia · 2021-06-29T04:31:48Z

@ngoc-do, please review.

ngoc-do · 2021-06-29T05:30:26Z

@ngoc-do, please review.

Thanks for updating the port number. I was going to do that after sonic-net/sonic-buildimage#7629 merged, but you already made it. Thanks a lot.

ngoc-do · 2021-06-29T05:34:01Z

tests/test_virtual_chassis.py

@@ -136,7 +136,6 @@ def test_voq_switch(self, vct):
                spcfg = ast.literal_eval(value)
                assert spcfg['count'] == sp_count, "Number of systems ports configured is invalid"

-    @pytest.mark.skip(reason="This test is not stable enough")


Can I have the context for this?

@pytest.mark.skip(reason="This test is not stable enough")

Why was it added? Was it added after sonic-net/sonic-buildimage#7629 merged? Did sonic-net/sonic-buildimage#7629 cause test instability?

Those 3 tests consistently failed. So PR #1807 was raised to skip these tests.
These tests failed not because of sonic-net/sonic-buildimage#7629 but because of sonic-net/sonic-buildimage#7857. I noticed that once the problem created by sonic-net/sonic-buildimage#7857 is fixed, the port count mismatch problem occurred, which was due to sonic-net/sonic-buildimage#7629

Cool, thanks.

ngoc-do · 2021-06-29T05:38:18Z

tests/conftest.py

 # FIXME: Voq asics will have 16 fabric ports created (defined in Azure/sonic-buildimage#6185).
 # Right now, we set FABRIC_NUM_PORTS to 0, and change to 16 when PR#6185 merges. PR#6185 can't
 # be merged before this PR. Otherwise it will cause swss voq test failures.


Remove the comment.

prsunny · 2021-07-01T22:34:49Z

@vganesan-nokia , i still see the vs test failed. can you please check?

vganesan-nokia · 2021-07-01T22:37:34Z

@vganesan-nokia , i still see the vs test failed. can you please check?

This is expected. This PR is dependent on PR sonic-net/sonic-buildimage#8008. We need to merge sonic-net/sonic-buildimage#8008 first.

prsunny · 2021-11-05T21:12:04Z

/azp run

azure-pipelines · 2021-11-05T21:12:14Z

Azure Pipelines successfully started running 1 pipeline(s).

vganesan-nokia · 2021-11-30T18:00:55Z

@prsunny, would you please approve this PR and make arrangements to merge? Thanks

prsunny · 2021-11-30T18:31:11Z

/azp run

azure-pipelines · 2021-11-30T18:31:22Z

Azure Pipelines successfully started running 1 pipeline(s).

prsunny · 2021-11-30T18:43:38Z

can you please rebase to latest?

vganesan-nokia · 2021-12-04T21:43:17Z

@prsunny, I rebased to latest. There are 2 failures unrelated to virtual chasiss tests. Would you please restart the azp/vs tests? Thanks

prsunny · 2021-12-07T01:14:38Z

/azp run

azure-pipelines · 2021-12-07T01:14:48Z

Azure Pipelines successfully started running 1 pipeline(s).

Changes include: - Set the FABRIC_NUM_PORTS to 16. This is required since addition of fabric port orch adds 16 fabrics in asic db internally. - Added back the skipped tests Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>

Changes done to remove comments and LGTM warnings. Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>

This reverts commit facdef5. With the changes in platfrom/vs/docker-sonic-vs/start.sh done via sonic-buildimage PR sonic-net/sonic-buildimage#8008 all tests will pass. No need to skip the tests. So reverting this commit

691c37b [Route bulk] Fix bugs in case a SET operation follows a DEL operation in the same bulk (sonic-net/sonic-swss#2086) a4c80c3 patch for issue sonic-net/sonic-swss#1971 - enable Rx Drop handling for cisco-8000 (sonic-net/sonic-swss#2041) 71751d1 [macsec] Support setting IPG by gearbox_config.json (sonic-net/sonic-swss#2051) 5d5c169 [bulk mode] Fix bulk conflict when in case there are both remove and set operations (sonic-net/sonic-swss#2071) 8bbdbd2 Fix SRV6 NHOP CRM object type (sonic-net/sonic-swss#2072) ef5b35f [vstest] VS test failure fix after fabric port orch PR merge (sonic-net/sonic-swss#1811) 89ea538 Supply the missing ingress/egress port profile list in document (sonic-net/sonic-swss#2064) 8123437 [pfc_detect] fix RedisReply errors (sonic-net/sonic-swss#2040) b38f527 [swss][CRM][MPLS] MPLS CRM Nexthop - switch back to using SAI OBJECT rather than SWITCH OBJECT ae061e5 create debug_shell_enable config to enable debug shell (sonic-net/sonic-swss#2060) 45e446d [cbf] Fix max FC value (sonic-net/sonic-swss#2049) b1b5b29 Initial p4orch pytest code. (sonic-net/sonic-swss#2054) d352d5a Update default route status to state DB (sonic-net/sonic-swss#2009) 24a64d6 Orchagent: Integrate P4Orch (sonic-net/sonic-swss#2029) 15a3b6c Delete the IPv6 link-local Neighbor when ipv6 link-local mode is disabled (sonic-net/sonic-swss#1897) ed783e1 [orchagent] Add trap flow counter support (sonic-net/sonic-swss#1951) e9b05a3 [vnetorch] ECMP for vnet tunnel routes with endpoint health monitor (sonic-net/sonic-swss#1955) bcb7d61 P4Orch: inital add of source (sonic-net/sonic-swss#1997) f6f6f86 [mclaglink] fix acl out ports (sonic-net/sonic-swss#2026) fd887bf [Reclaim buffer] Reclaim unused buffer for dynamic buffer model (sonic-net/sonic-swss#1910) 9258978 [orchagent, cfgmgr] Add response publisher and state recording (sonic-net/sonic-swss#1992) 3d862a7 Fixing subport vs test script for subport under VNET (sonic-net/sonic-swss#2048) fb0a5fd Don't handle buffer pool watermark during warm reboot reconciling (sonic-net/sonic-swss#1987) 16d4bcd Routed subinterface enhancements (sonic-net/sonic-swss#1907) 9639db7 [vstest/subintf] Add vs test to validate sub interface ingress to a vnet (sonic-net/sonic-swss#1642) Signed-off-by: Stephen Sun stephens@nvidia.com

…et#1811) * [vstest] VS test failues fix after fabric port orch PR merge *This reverts commit facdef5.

vganesan-nokia requested a review from prsunny as a code owner June 29, 2021 04:19

This was referenced Jun 29, 2021

[vstest] Virtual chssis config rendering from default_config.json sonic-net/sonic-buildimage#8008

Merged

[VS test stability] Chassis test #1809

Open

ngoc-do reviewed Jun 29, 2021

View reviewed changes

ngoc-do previously approved these changes Jun 29, 2021

View reviewed changes

vganesan-nokia mentioned this pull request Aug 5, 2021

[SWSS] VOQ Nexthop for remote VOQ LC should be created on inband OIF. #1823

Merged

vganesan-nokia dismissed ngoc-do’s stale review via 3f74b8d October 27, 2021 16:13

vganesan-nokia force-pushed the vstest-failure-fix-1 branch 3 times, most recently from 09188ee to 6392d3b Compare November 2, 2021 15:34

rlhui added the chassis label Nov 3, 2021

vganesan-nokia force-pushed the vstest-failure-fix-1 branch from 6392d3b to f0ee680 Compare November 7, 2021 20:16

vganesan-nokia force-pushed the vstest-failure-fix-1 branch from f0ee680 to f8eec5e Compare December 3, 2021 21:56

vedganes added 2 commits December 7, 2021 01:03

[vstest] Code review comments fix - 1

bb42224

Changes done to remove comments and LGTM warnings. Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>

vganesan-nokia force-pushed the vstest-failure-fix-1 branch from f8eec5e to 460244f Compare December 7, 2021 06:06

prsunny approved these changes Dec 7, 2021

View reviewed changes

prsunny merged commit ef5b35f into sonic-net:master Dec 7, 2021

stephenxs mentioned this pull request Dec 14, 2021

[sonic-swss] Submodule update sonic-net/sonic-buildimage#9397

Merged

5 tasks

stephenxs mentioned this pull request Jan 6, 2022

[sonic-swss][202111] Submodule update (#9397) sonic-net/sonic-buildimage#9685

Merged

5 tasks

arlakshm added the Request for 202106 Branch label Jan 18, 2022

preetham-singh pushed a commit to preetham-singh/sonic-swss that referenced this pull request Aug 6, 2022

[vstest] VS test failure fix after fabric port orch PR merge (sonic-n…

d817b8e

…et#1811) * [vstest] VS test failues fix after fabric port orch PR merge *This reverts commit facdef5.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[vstest] VS test failure fix after fabric port orch PR merge #1811

[vstest] VS test failure fix after fabric port orch PR merge #1811

vganesan-nokia commented Jun 29, 2021

lgtm-com bot commented Jun 29, 2021

vganesan-nokia commented Jun 29, 2021

ngoc-do commented Jun 29, 2021

ngoc-do Jun 29, 2021

vganesan-nokia Jun 29, 2021

ngoc-do Jun 29, 2021

ngoc-do Jun 29, 2021

vganesan-nokia Jun 29, 2021

prsunny commented Jul 1, 2021

vganesan-nokia commented Jul 1, 2021 •

edited

Loading

prsunny commented Nov 5, 2021

azure-pipelines bot commented Nov 5, 2021

vganesan-nokia commented Nov 30, 2021

prsunny commented Nov 30, 2021

azure-pipelines bot commented Nov 30, 2021

prsunny commented Nov 30, 2021

vganesan-nokia commented Dec 4, 2021

prsunny commented Dec 7, 2021

azure-pipelines bot commented Dec 7, 2021

[vstest] VS test failure fix after fabric port orch PR merge #1811

[vstest] VS test failure fix after fabric port orch PR merge #1811

Conversation

vganesan-nokia commented Jun 29, 2021

lgtm-com bot commented Jun 29, 2021

vganesan-nokia commented Jun 29, 2021

ngoc-do commented Jun 29, 2021

ngoc-do Jun 29, 2021

Choose a reason for hiding this comment

vganesan-nokia Jun 29, 2021

Choose a reason for hiding this comment

ngoc-do Jun 29, 2021

Choose a reason for hiding this comment

ngoc-do Jun 29, 2021

Choose a reason for hiding this comment

vganesan-nokia Jun 29, 2021

Choose a reason for hiding this comment

prsunny commented Jul 1, 2021

vganesan-nokia commented Jul 1, 2021 • edited Loading

prsunny commented Nov 5, 2021

azure-pipelines bot commented Nov 5, 2021

vganesan-nokia commented Nov 30, 2021

prsunny commented Nov 30, 2021

azure-pipelines bot commented Nov 30, 2021

prsunny commented Nov 30, 2021

vganesan-nokia commented Dec 4, 2021

prsunny commented Dec 7, 2021

azure-pipelines bot commented Dec 7, 2021

vganesan-nokia commented Jul 1, 2021 •

edited

Loading