[SWSS] VOQ Nexthop for remote VOQ LC should be created on inband OIF. #1823
Conversation
|
would this issue could have covered by unit test ? If so can we add now |
|
@abdosi can you approve this one and merge?. @vganesan-nokia is adding UT in separate PR. |
|
can we add test case as part of this repo ? this can be common repo and we can collaborate. |
@abdosi, there will not be any new test case for this. The system neighbor test case in sonic-swss/tests/test_virtual_chassis.py will be enhaced to check for presence of the neighbor in the kernel on Ethernet-IB (inband) interface. This will be done in a separate PR after PR #1811 is merged. |
|
@abdosi, I just checked the sonic-swss/test_virtual_chassis.py for enhancing system neighbor test. The voq system neigh test already checks for presence of the neighbor in kernel on the inband interface. But this test is skipped by PR #1807. Since the PR #1686 was merged just after the PR #1807 was merged, virtual chassis tests did not catch the problem introduced by PR #1686. The problem that lead to skipping the virtual chassis tests has been fixed by PRs sonic-net/sonic-buildimage#8008 and PR #1811. The PR #1811 also enables the skipped tests. So just merging PR sonic-net/sonic-buildimage#8008 and PR #1811 will be enough. We do not need any enhancements in virtual chassis tests by another PR. Tagging Anshu and Suresh, for their info: @anshuv-mfst , @minionatwork |
VOQ nexthop for remote neighbors should be created on local inband port only for the kernel purpose. SAI should use actual RIF of the remote system port interface. #1686 seems to be break this condition and this change address it.
…c-net#1823) VOQ nexthop for remote neighbors should be created on local inband port only for the kernel purpose. SAI should use actual RIF of the remote system port interface. sonic-net#1686 seems to be break this condition and this change address it.
What I did
VOQ nexthop for remote neighbors should be created on local inband port only for the kernel purpose. SAI should use actual RIF of the remote system port interface. #1686 seems to be break this condition and this change address it.
Why I did it
VOQ nexthop for remote neighbors should be created on local inband port only for the kernel purpose. SAI should use actual RIF of the remote system port interface. #1686 seems to be break this condition and this change address it.
How I verified it
Test on VOQ chassis.
Details if related