-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VS Test] Skip flaky tests #1875
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
pushed a commit
that referenced
this pull request
Aug 19, 2021
* Skip flaky test, under investigation
This was referenced Aug 25, 2021
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Aug 26, 2021
In order to include the following commits: d29a49a 2021-08-25 [ACL] Match TCP protocol while matching TCP_FLAG (sonic-net/sonic-swss#1854) 2569ad9 2021-08-25 Fix sFlow sampling-rate and admin-state (sonic-net/sonic-swss#1728) 8908a8f 2021-08-19 Change rif_rates.lua and port_rates.lua scripts to calculate rates correct (sonic-net/sonic-swss#1848) b42c2fb 2021-08-19 [VS Test] Skip flaky tests (sonic-net/sonic-swss#1875)
neethajohn
pushed a commit
that referenced
this pull request
Aug 27, 2021
Ref: #1875 The test expects buffer PGs created for all ports. However, the vs image is deployed as cable length being 0m, which provides the buffer PGs to be created and fails the test. To fix the failure: - Config the cable length of port under test to 300m if it was 0m - Startup the port after cable length configured By doing that the buffer PG can be configured correctly - Collect the orig_profiles after port is started up Signed-off-by: Stephen Sun <stephens@nvidia.com>
qiluo-msft
pushed a commit
that referenced
this pull request
Aug 30, 2021
Ref: #1875 The test expects buffer PGs created for all ports. However, the vs image is deployed as cable length being 0m, which provides the buffer PGs to be created and fails the test. To fix the failure: - Config the cable length of port under test to 300m if it was 0m - Startup the port after cable length configured By doing that the buffer PG can be configured correctly - Collect the orig_profiles after port is started up Signed-off-by: Stephen Sun <stephens@nvidia.com>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
* Skip flaky test, under investigation
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
Ref: sonic-net#1875 The test expects buffer PGs created for all ports. However, the vs image is deployed as cable length being 0m, which provides the buffer PGs to be created and fails the test. To fix the failure: - Config the cable length of port under test to 300m if it was 0m - Startup the port after cable length configured By doing that the buffer PG can be configured correctly - Collect the orig_profiles after port is started up Signed-off-by: Stephen Sun <stephens@nvidia.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
What I did Added EXP to TC map to tables affected by clear_qos command How I did it Found references to DSCP to TC map, added EXP to TC map in same place How to verify it Run clear_qos with EXP to TC map present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Skip flaky tests for unblocking PRs, this is under investigation.
Why I did it
How I verified it
Details if related