Fix vs test failure in test_buffer_traditional #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenxs
requested review from
neethajohn and
prsunny
and removed request for
prsunny
|
Ref: #1875 |
Thanks. Will remove the "skip". |
The test expectes buffer PGs created for all ports. However, the vs image is deployed as cable length being 0m, which provides the buffer PGs to be created and fails the test. To fix the failure: - Config the cable length of port under test to 300m if it was 0m - Startup the port after cable length configured By doing that the buffer PG can be configured correctly - Collect the orig_profiles after port is started up Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
stephenxs
force-pushed
the
fix-buffer-traditional-test
branch
from
de477d0
to
b4373c9
Compare
|
@prsunny and @neethajohn kindly reminder for the review. |
neethajohn
approved these changes
Aug 27, 2021
qiluo-msft
pushed a commit
that referenced
this pull request
Aug 30, 2021
Ref: #1875 The test expects buffer PGs created for all ports. However, the vs image is deployed as cable length being 0m, which provides the buffer PGs to be created and fails the test. To fix the failure: - Config the cable length of port under test to 300m if it was 0m - Startup the port after cable length configured By doing that the buffer PG can be configured correctly - Collect the orig_profiles after port is started up Signed-off-by: Stephen Sun <stephens@nvidia.com>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
Ref: sonic-net#1875 The test expects buffer PGs created for all ports. However, the vs image is deployed as cable length being 0m, which provides the buffer PGs to be created and fails the test. To fix the failure: - Config the cable length of port under test to 300m if it was 0m - Startup the port after cable length configured By doing that the buffer PG can be configured correctly - Collect the orig_profiles after port is started up Signed-off-by: Stephen Sun <stephens@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
The test expects buffer PGs created for all ports.
However, the vs image is deployed as cable length being 0m,
which prevents the buffer PGs from being created and fails the test.
To fix the failure:
By doing that the buffer PG can be configured correctly
This is required to check whether the new profile has been created after cable length/speed is changed.
Signed-off-by: Stephen Sun stephens@nvidia.com
Why I did it
How I verified it
Details if related