Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][asan] add DVS tests run with ASAN #2363

Merged
merged 6 commits into from
Aug 24, 2022

Conversation

Yakiv-Huryk
Copy link
Contributor

@Yakiv-Huryk Yakiv-Huryk commented Jun 30, 2022

This adds 3 new stages:

  • BuildAsan: same as 'Build' but with ENABLE_ASAN=y
  • BuildDockerAsan: same as 'BuildDocker' but uses asan-enabled swss and
    adds swss-dbg package. It also uses asan-enabled docker-sonic-vs from
    the sonic-buildimage ci.
  • TestAsan: same as 'Test' but uses asan-enabled docker and publishes
    the asan reports if any.

What I did
Added new CI stages to run the DVS tests with ASAN and check the ASAN reports.

Why I did it
To utilize ASAN for catching memory usage issues on PR.

How I verified it
Run the CI on my fork

Details if related

This adds 3 new stages:

* BuildAsan: same as 'Build' but with ENABLE_ASAN=y
* BuildDockerAsan: same as 'BuildDocker' but uses asan-enabled swss and
adds swss-dbg package. It also uses asan-enabled docker-sonic-vs from
the sonic-buildimage ci.
* TestAsan: same as 'Test' but uses asan-enabled docker and publishes
the asan reports if any. It also fails if asan report dir is not empty
(which means that there is some memory usage issue in swss)

Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
@Yakiv-Huryk Yakiv-Huryk requested a review from prsunny as a code owner June 30, 2022 11:26
@Yakiv-Huryk
Copy link
Contributor Author

This requires the sonic-net/sonic-buildimage#11297

@oleksandrivantsiv oleksandrivantsiv requested a review from xumia June 30, 2022 11:30
@oleksandrivantsiv
Copy link
Collaborator

/azpw run Azure.sonic-swss

@oleksandrivantsiv
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 2363 in repo Azure/sonic-swss

@liat-grozovik
Copy link
Collaborator

@Yakiv-Huryk could you please handle the conflicts and verify checkers are passing?

@xumia xumia requested a review from liushilongbuaa July 25, 2022 01:45
@liat-grozovik
Copy link
Collaborator

@liushilongbuaa kindly reminder to review and approve

@liushilongbuaa
Copy link
Contributor

LGTM
@Yakiv-Huryk , please resolve conflicts.

@Yakiv-Huryk
Copy link
Contributor Author

LGTM @Yakiv-Huryk , please resolve conflicts.

It says 'This branch has no conflicts with the base branch' for me

@liat-grozovik liat-grozovik merged commit ca9edca into sonic-net:master Aug 24, 2022
prsunny added a commit that referenced this pull request Aug 29, 2022
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Aug 29, 2022
Update sonic-swss submodule pointer to include the following:
* Dynamic port configuration - add port buffer cfg to the port ref counter ([sonic-net#2194](sonic-net/sonic-swss#2194))
* tlm_teamd: Filter portchannel subinterface events from STATE_DB LAG_TABLE ([sonic-net#2408](sonic-net/sonic-swss#2408))
* [counters] Improve performance by polling only configured ports buffer queue/pg counters ([sonic-net#2360](sonic-net/sonic-swss#2360))
* added support for Xsight platform ([sonic-net#2426](sonic-net/sonic-swss#2426))
* [ci][asan] add DVS tests run with ASAN ([sonic-net#2363](sonic-net/sonic-swss#2363))
* Handle dual ToR neighbor miss scenario ([sonic-net#2151](sonic-net/sonic-swss#2151))
* Upstream new development on p4orch ([sonic-net#2237](sonic-net/sonic-swss#2237))
* [lgtm] Fix dependency ([sonic-net#2419](sonic-net/sonic-swss#2419))
* [muxorch] Returning true if nbr in skip_neighbor_ in isNeighborActive() ([sonic-net#2415](sonic-net/sonic-swss#2415))
* [macsec]: Set MTU for MACsec ([sonic-net#2398](sonic-net/sonic-swss#2398))
* Delete Invalid if condition in intfsorch.cpp ([sonic-net#2411](sonic-net/sonic-swss#2411))

Signed-off-by: dprital <drorp@nvidia.com>
prsunny added a commit that referenced this pull request Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants