Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream new development on p4orch #2237

Merged
merged 3 commits into from
Aug 18, 2022
Merged

Upstream new development on p4orch #2237

merged 3 commits into from
Aug 18, 2022

Conversation

mint570
Copy link
Contributor

@mint570 mint570 commented Apr 21, 2022

Upstream new development on p4orch:

  1. New actions in route manager: trap, set metadata.
  2. New match attribute in ACL manager: ROUTE_DST_USER_META.
  3. Bulk SAI call in route manager.
  4. Added l3 admin manager.
  5. Added GRE tunnel manager.
  6. P4orch state verification for internal cache and ASIC DB (place holder).
  7. Bug fixes and code enhancements.

Co-authored-by: Runming Wu runmingwu@google.com
Co-authored-by: Yilan Ji yilanji@google.com
Co-authored-by: Jaffar Abdul jabdulabdul@google.com

@mint570 mint570 requested a review from prsunny as a code owner April 21, 2022 23:42
@mint570
Copy link
Contributor Author

mint570 commented Apr 22, 2022

New definitions are merged in sonic-net/sonic-swss-common#604.
But the test still not picking up the new change.

@lgtm-com
Copy link

lgtm-com bot commented Apr 22, 2022

This pull request introduces 2 alerts when merging b2b25bb into 1fd1dbf - view on LGTM.com

new alerts:

  • 1 for Testing equality to None
  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Apr 23, 2022

This pull request introduces 2 alerts when merging ac996b1 into 1fd1dbf - view on LGTM.com

new alerts:

  • 1 for Testing equality to None
  • 1 for Unused local variable

@mint570
Copy link
Contributor Author

mint570 commented Apr 26, 2022

@prsunny
Can you please take a look?

@lgtm-com
Copy link

lgtm-com bot commented May 5, 2022

This pull request introduces 2 alerts when merging ada4968 into 4e53afc - view on LGTM.com

new alerts:

  • 1 for Testing equality to None
  • 1 for Unused local variable

@bocon13 bocon13 mentioned this pull request May 10, 2022
Open
@mint570
Copy link
Contributor Author

mint570 commented May 24, 2022

@prsunny
Can you please take a look at this pr?

We have an internal fix for sonic-net/sonic-buildimage#10410. Would like to upstream our fix after this pr.

@lgtm-com
Copy link

lgtm-com bot commented May 24, 2022

This pull request introduces 2 alerts when merging 6be7f71 into 40316f7 - view on LGTM.com

new alerts:

  • 1 for Testing equality to None
  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented May 25, 2022

This pull request introduces 2 alerts when merging dd89a3f into 40316f7 - view on LGTM.com

new alerts:

  • 1 for Testing equality to None
  • 1 for Unused local variable

@mint570
Copy link
Contributor Author

mint570 commented May 25, 2022 •
edited
Loading

The last few of the pytests failed. The number of failed tests are different each time. But they are at the end of the run.
I suspect there are some memory or disk space run out.
For now, I just disabled a few tests at the end.

@lgtm-com
Copy link

lgtm-com bot commented May 25, 2022

This pull request introduces 2 alerts and fixes 1 when merging 34496a0 into 7fc0f73 - view on LGTM.com

new alerts:

  • 1 for Testing equality to None
  • 1 for Unused local variable

fixed alerts:

  • 1 for Unused import

@mint570
Copy link
Contributor Author

mint570 commented May 25, 2022

All runs passed now except for the coverage.
I disabled a few pytest at the end due to the memory/disk (probabiliry) issue.
We plan to enable the p4orch unit test run in the future, which will provide good p4orch coverage.

@lgtm-com
Copy link

lgtm-com bot commented May 27, 2022

This pull request introduces 2 alerts and fixes 1 when merging 6a0a8be into 583236f - view on LGTM.com

new alerts:

  • 1 for Testing equality to None
  • 1 for Unused local variable

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented May 27, 2022

This pull request introduces 2 alerts and fixes 1 when merging d69327d into 4d6fa42 - view on LGTM.com

new alerts:

  • 1 for Testing equality to None
  • 1 for Unused local variable

fixed alerts:

  • 1 for Unused import

@mint570 mint570 mentioned this pull request Jun 14, 2022
Closed
@lgtm-com
Copy link

lgtm-com bot commented Jun 23, 2022

This pull request introduces 2 alerts and fixes 1 when merging aa98b4b into ec57bf1 - view on LGTM.com

new alerts:

  • 1 for Testing equality to None
  • 1 for Unused local variable

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jul 13, 2022

This pull request introduces 3 alerts when merging 63dfd78 into 47f6162 - view on LGTM.com

new alerts:

  • 1 for Testing equality to None
  • 1 for Unused local variable
  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jul 22, 2022

This pull request introduces 3 alerts when merging 225fff0 into e9984d8 - view on LGTM.com

new alerts:

  • 1 for Testing equality to None
  • 1 for Unused local variable
  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jul 23, 2022

This pull request introduces 3 alerts when merging ef32de0 into e9984d8 - view on LGTM.com

new alerts:

  • 1 for Testing equality to None
  • 1 for Unused local variable
  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jul 23, 2022

This pull request introduces 3 alerts when merging aea0b0f into 4a6f940 - view on LGTM.com

new alerts:

  • 1 for Testing equality to None
  • 1 for Unused local variable
  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jul 23, 2022

This pull request introduces 3 alerts when merging 5f3bbd5 into 4a6f940 - view on LGTM.com

new alerts:

  • 1 for Testing equality to None
  • 1 for Unused local variable
  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jul 24, 2022

This pull request introduces 3 alerts when merging d736430 into 4a6f940 - view on LGTM.com

new alerts:

  • 1 for Testing equality to None
  • 1 for Unused local variable
  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jul 27, 2022

This pull request introduces 3 alerts when merging 14da984 into 75fc965 - view on LGTM.com

new alerts:

  • 1 for Testing equality to None
  • 1 for Unused local variable
  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jul 27, 2022

This pull request introduces 3 alerts when merging b9d7e36 into 75fc965 - view on LGTM.com

new alerts:

  • 1 for Testing equality to None
  • 1 for Unused local variable
  • 1 for Unused import

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 4, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@lgtm-com
Copy link

lgtm-com bot commented Aug 4, 2022

This pull request introduces 3 alerts when merging 13b330c into dc477fb - view on LGTM.com

new alerts:

  • 1 for Testing equality to None
  • 1 for Unused local variable
  • 1 for Unused import

@mint570
Upstream new development on p4orch:
9448e57 
1. New actions in route manager: trap, set metadata.
2. New match attribute in ACL manager: ROUTE_DST_USER_META.
3. Bulk SAI call in route manager.
4. Added l3 admin manager.
5. Added GRE tunnel manager.
6. P4orch state verification for internal cache and ASIC DB (place holder).
7. Bug fixes and code enhancements.

Co-authored-by: Runming Wu [runmingwu@google.com](mailto:runmingwu@google.com)
Co-authored-by: Yilan Ji [yilanji@google.com](mailto:yilanji@google.com)
Co-authored-by: Jaffar Abdul [jabdulabdul@google.com](mailto:jabdulabdul@google.com)
@mint570
Disable l3 admit pytest.
ded42a4 
Change-Id: Ie198e4ddb66cc79506bfc159089be1e3f0bf7184
@mint570
Free up space in the coverage workflow.
f218f8b 
Change-Id: I9020905dc106a8c3b33da4ae6c7f479f5468bfb7
@lgtm-com
Copy link

lgtm-com bot commented Aug 5, 2022

This pull request introduces 3 alerts when merging f218f8b into 2489ad5 - view on LGTM.com

new alerts:

  • 1 for Testing equality to None
  • 1 for Unused local variable
  • 1 for Unused import

@mint570
Copy link
Contributor Author

mint570 commented Aug 8, 2022

@prsunny
With p4orch unit test enabled and code coverage enabled, this PR is fully ready now.
Please take a look.

prsunny
prsunny approved these changes Aug 16, 2022
View reviewed changes
Copy link
Collaborator

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switchorch changes lgtm

@prsunny
Copy link
Collaborator

prsunny commented Aug 16, 2022

@bhagatyj to signoff

@prsunny
Copy link
Collaborator

prsunny commented Aug 18, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bhagatyj
Copy link

lgtm.

@prsunny prsunny merged commit 9eb4422 into sonic-net:master Aug 18, 2022
@prsunny prsunny deleted the sonic_upstream_merged branch August 18, 2022 17:14
@mint570 mint570 mentioned this pull request Aug 22, 2022
Merged
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Aug 29, 2022
@dprital
[submodule] Advance sonic-swss pointer
f7766cf 
Update sonic-swss submodule pointer to include the following:
* Dynamic port configuration - add port buffer cfg to the port ref counter ([sonic-net#2194](sonic-net/sonic-swss#2194))
* tlm_teamd: Filter portchannel subinterface events from STATE_DB LAG_TABLE ([sonic-net#2408](sonic-net/sonic-swss#2408))
* [counters] Improve performance by polling only configured ports buffer queue/pg counters ([sonic-net#2360](sonic-net/sonic-swss#2360))
* added support for Xsight platform ([sonic-net#2426](sonic-net/sonic-swss#2426))
* [ci][asan] add DVS tests run with ASAN ([sonic-net#2363](sonic-net/sonic-swss#2363))
* Handle dual ToR neighbor miss scenario ([sonic-net#2151](sonic-net/sonic-swss#2151))
* Upstream new development on p4orch ([sonic-net#2237](sonic-net/sonic-swss#2237))
* [lgtm] Fix dependency ([sonic-net#2419](sonic-net/sonic-swss#2419))
* [muxorch] Returning true if nbr in skip_neighbor_ in isNeighborActive() ([sonic-net#2415](sonic-net/sonic-swss#2415))
* [macsec]: Set MTU for MACsec ([sonic-net#2398](sonic-net/sonic-swss#2398))
* Delete Invalid if condition in intfsorch.cpp ([sonic-net#2411](sonic-net/sonic-swss#2411))

Signed-off-by: dprital <drorp@nvidia.com>
@dprital dprital mentioned this pull request Aug 29, 2022
Closed
7 tasks
@DavidZagury DavidZagury mentioned this pull request Sep 14, 2022
Closed
7 tasks
@rhalstea rhalstea mentioned this pull request Nov 23, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prsunny prsunny prsunny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mint570 @prsunny @bhagatyj