[vlanmgrd]: Create a dummy interface and put into the Bridge #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is for 201803 branch |
zhenggen-xu
reviewed
Dec 13, 2018
cfgmgr/vlanmgr.cpp
Outdated
| // /sbin/bridge vlan del vid 1 dev Bridge self; | ||
| // /sbin/ip link del dummy 2>/dev/null; | ||
| // /sbin/ip link add dummy type dummy &&" | ||
| // /sbin/ip link set dummy master Bridge" |
There was a problem hiding this comment.
This should be "/sbin/ip link set dummy up master Bridge"
zhenggen-xu
reviewed
Dec 14, 2018
cfgmgr/vlanmgr.cpp
Outdated
| + BRIDGE_CMD + " vlan del vid " + DEFAULT_VLAN_ID + " dev " + DOT1Q_BRIDGE_NAME + " self; " | ||
| + IP_CMD + " link del dummy 2>/dev/null; " | ||
| + IP_CMD + " link add dummy type dummy && " | ||
| + IP_CMD + " link set dummy up master Bridge\""; |
There was a problem hiding this comment.
Change "Bridge" to "DOT1Q_BRIDGE_NAME" ?
In order to maintain the interface Bridge to be UP all the time, the dummy interface is needed to be the member of the Bridge. Refactored test_vlan.py so that each test is independent from each other and intermediate state will be cleaned up afterwards. Add test_MultipleVlan test to cover scenarios with VLAN and VLAN members change. Before the change of the vlanmgrd, this test would fail when all the VLAN members were removed out of the master. Interface Bridge would show NO-CARRIER and new VLAN cannot be created afterwards. After adding the dummy interface, this test will pass. Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
stcheng
force-pushed
the
dummy-201803
branch
from
44952c3
to
8654751
Compare
|
@zhenggen-xu updated |
|
@stcheng Thanks for the change, sorry some comments were not given before: I saw the commit message "Add test_MultipleVlan test to cover scenarios with VLAN and VLAN members change.", did you add that test cases somewhere? or should it be part of this PR? Also, let's define the "dummy" interface name as a macro, so code can refer to it. Thanks! |
|
Hi @stcheng and @zhenggen-xu |
|
addressed by @jipanyang |
|
Hi all |
|
@chenkelly #1001 please check this one |
lguohan
added a commit
that referenced
this pull request
Mar 4, 2020
The code is to add/del items in LAG_NAME_MAP_TABLE in COUNTERS_DB if a lag is added or removed. The code need the below pull request: #51 in Azure/sonic-py-swsssdk read portchannel name from LAG_NAME_MAP_TABLE in COUNTERS_DB #51 For use of LAG_NAME_MAP_TABLE in COUNTERS_DB just like fdbshow. I have create another pull request in Azure/sonic-utilities: Show mac learned on lag interface #730
abdosi
pushed a commit
that referenced
this pull request
Mar 4, 2020
The code is to add/del items in LAG_NAME_MAP_TABLE in COUNTERS_DB if a lag is added or removed. The code need the below pull request: #51 in Azure/sonic-py-swsssdk read portchannel name from LAG_NAME_MAP_TABLE in COUNTERS_DB #51 For use of LAG_NAME_MAP_TABLE in COUNTERS_DB just like fdbshow. I have create another pull request in Azure/sonic-utilities: Show mac learned on lag interface #730
yxieca
pushed a commit
that referenced
this pull request
Apr 3, 2020
The code is to add/del items in LAG_NAME_MAP_TABLE in COUNTERS_DB if a lag is added or removed. The code need the below pull request: #51 in Azure/sonic-py-swsssdk read portchannel name from LAG_NAME_MAP_TABLE in COUNTERS_DB #51 For use of LAG_NAME_MAP_TABLE in COUNTERS_DB just like fdbshow. I have create another pull request in Azure/sonic-utilities: Show mac learned on lag interface #730
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Updated installation steps Added missing required packages Signed-off-by: Alexandru Banu <Alexandru.Banu@metaswitch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to maintain the interface Bridge to be UP all the time,
the dummy interface is needed to be the member of the Bridge.
Refactored test_vlan.py so that each test is independent from
each other and intermediate state will be cleaned up afterwards.
Add test_MultipleVlan test to cover scenarios with VLAN and
VLAN members change. Before the change of the vlanmgrd, this
test would fail when all the VLAN members were removed out of
the master. Interface Bridge would show NO-CARRIER and new
VLAN cannot be created afterwards.
After adding the dummy interface, this test will pass.
Signed-off-by: Shu0T1an ChenG shuche@microsoft.com