Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[201911] Multi asic platform config interface portchannel, show transceiver #1087

Merged
merged 5 commits into from
Sep 19, 2020
Merged

[201911] Multi asic platform config interface portchannel, show transceiver #1087

merged 5 commits into from
Sep 19, 2020

Conversation

judyjoseph
Copy link
Contributor

@judyjoseph judyjoseph commented Sep 1, 2020 •
edited
Loading

- What I did
Merging the Multi asic platform changes into 201911 branch for

  1. interface, portchannel commands ( Multi asic platform changes for interface, portchannel commands #878)
  2. [multi-asic] show_transceiver changes [multi-asic] show_transceiver changes #1081

- How I did it

- How to verify it

- Previous command output (if the output of a command-line utility has changed)

- New command output (if the output of a command-line utility has changed)

@lgtm-com
Copy link

lgtm-com bot commented Sep 1, 2020

This pull request introduces 1 alert and fixes 1 when merging 6a0d9e5c8fa1ea895aaea4e32d31e4082177944f into ddf84d9 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Sep 1, 2020

This pull request fixes 1 alert when merging 4b89678e572d8ef6217c414ff83b573e8d410d89 into ddf84d9 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@judyjoseph judyjoseph closed this Sep 6, 2020
@judyjoseph judyjoseph reopened this Sep 6, 2020
@lgtm-com
Copy link

lgtm-com bot commented Sep 6, 2020

This pull request fixes 1 alert when merging f21e205ad6c7c00066e956bfbd11363a14e3ec7e into 1a949ca - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@judyjoseph judyjoseph changed the title [201911] Multi asic platform changes for interface, portchannel commands [201911] Multi asic platform config interface portchannel, show transceiver Sep 6, 2020
@judyjoseph judyjoseph marked this pull request as draft September 6, 2020 16:14
@judyjoseph judyjoseph mentioned this pull request Sep 6, 2020
Closed
@lgtm-com
Copy link

lgtm-com bot commented Sep 6, 2020

This pull request introduces 1 alert and fixes 4 when merging 21eb51cb498e00eb70210d1e2ee8f49b4f7afb16 into 1a949ca - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 3 for Unused import
  • 1 for First parameter of a method is not named 'self'

@judyjoseph judyjoseph marked this pull request as ready for review September 7, 2020 23:22
@lgtm-com
Copy link

lgtm-com bot commented Sep 7, 2020

This pull request introduces 1 alert and fixes 3 when merging c3c84a083012e70f74a874ac2ecafa6a2a719b24 into 1a949ca - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 2 for Unused import
  • 1 for First parameter of a method is not named 'self'

@lgtm-com
Copy link

lgtm-com bot commented Sep 7, 2020

This pull request fixes 3 alerts when merging 187afd5ba359577fcb87e29d728825f3229f24ba into 1a949ca - view on LGTM.com

fixed alerts:

  • 2 for Unused import
  • 1 for First parameter of a method is not named 'self'

@judyjoseph
Copy link
Contributor Author

retest this please

1 similar comment
@judyjoseph
Copy link
Contributor Author

retest this please

@lgtm-com
Copy link

lgtm-com bot commented Sep 14, 2020

This pull request fixes 3 alerts when merging 87e47c9 into b9de785 - view on LGTM.com

fixed alerts:

  • 2 for Unused import
  • 1 for First parameter of a method is not named 'self'

@judyjoseph
Copy link
Contributor Author

@abdosi please merge this PR into 201911

@abdosi abdosi merged commit 917872e into sonic-net:201911 Sep 19, 2020
@judyjoseph judyjoseph mentioned this pull request Sep 20, 2020
Merged
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
@abdosi
[Submodule update] sonic-utilities
bb41312 
Revert "Revert " [201911]show interface counters for multi ASIC devices
(sonic-net#1104)""
 Revert "Revert "Pfcstat (sonic-net#1097)""
  [show] Fix 'show int neighbor expected' (sonic-net#1106)
   Update argument for docker exec it->i (sonic-net#1118)
     Update to make config load/reload backward compatible. (sonic-net#1115)
     Handling deletion of Port Channel before deletion of its members
     (sonic-net#1062)
    Skip default route present in ASIC-DB but not in APP-DB. (sonic-net#1107)
     [CLI][PFCWD][Multi-ASIC] Added multi ASIC support to 'pfcwd' CLI
     (sonic-net#1102)
       [201911]  Multi asic platform config interface portchannel, show
       transceiver  (sonic-net#1087)
       [drop counters] Fix configuration for counters with lowercase
       names (sonic-net#1103)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdosi abdosi abdosi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@judyjoseph @abdosi