Fix issue: exception in is_rj45_port in multi ASIC env #2313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Sun <stephens@nvidia.com>
|
@prgeor @judyjoseph could you please review it? thanks. |
judyjoseph
reviewed
Aug 17, 2022
Signed-off-by: Stephen Sun <stephens@nvidia.com>
judyjoseph
approved these changes
Aug 18, 2022
yxieca
pushed a commit
that referenced
this pull request
Aug 19, 2022
* Fix issue: exception in is_rj45_port in multi ASIC env Signed-off-by: Stephen Sun <stephens@nvidia.com>
7 tasks
7 tasks
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Nov 21, 2022
* Fix issue: exception in is_rj45_port in multi ASIC env Signed-off-by: Stephen Sun <stephens@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix issue #2312. On some platforms,
logical_port_name_to_physical_port_listdoesn't return a valid port name list, which causes exception inis_rj45_port.Fix it by catching the exception and treating it as a non-RJ45 port.
Signed-off-by: Stephen Sun stephens@nvidia.com
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)