Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue: exception in is_rj45_port in multi ASIC env #2313

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Fix issue: exception in is_rj45_port in multi ASIC env #2313

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ab3d33
Fix issue: exception in is_rj45_port in multi ASIC env
stephenxs Aug 16, 2022
479d218
Fix typo: missing [0]
stephenxs Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions utilities_common/platform_sfputil_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,10 @@ def is_rj45_port(port_name):
if not platform_porttab_mapping_read:
platform_sfputil_read_porttab_mappings()

physical_port = logical_port_name_to_physical_port_list(port_name)[0]
try:
physical_port = logical_port_name_to_physical_port_list(port_name)
port_type = platform_chassis.get_port_or_cage_type(physical_port)
judyjoseph marked this conversation as resolved.
Show resolved Hide resolved
except NotImplementedError as e:
except Exception as e:
port_type = None

return port_type == platform_sfp_base.SFP_PORT_TYPE_BIT_RJ45
Expand Down