-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[202205] Use warm-boot infrastructure for fast-boot #2365
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 8, 2022
arfeigin
changed the title
Use warm-boot infrastructure for fast-boot
[202205] Use warm-boot infrastructure for fast-boot
Sep 11, 2022
arfeigin
force-pushed
the
frb_over_wrb_202205
branch
from
September 12, 2022 19:45
cdbe69c
to
ab61edb
Compare
vaibhavhd
approved these changes
Sep 12, 2022
dgsudharsan
added a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Sep 14, 2022
Update sonic-utilities submodule pointer to include the following: * b739efc [subinterface]Added additional checks in portchannel and subinterface commands (sonic-net#2345) ([sonic-net#2371](sonic-net/sonic-utilities#2371)) * d01153a Use warm-boot infrastructure for fast-boot ([sonic-net#2365](sonic-net/sonic-utilities#2365)) Signed-off-by: dgsudharsan <sudharsand@nvidia.com>
7 tasks
vaibhavhd
pushed a commit
to sonic-net/sonic-sairedis
that referenced
this pull request
Sep 14, 2022
This PR is similar to #1100 This PR should be merged together with sonic-utilities PR (sonic-net/sonic-utilities#2365) and sonic-buildimage PR (sonic-net/sonic-buildimage#12026). Fast-reboot is utilizing warm-reboot infrastructure to improve its performance, but it should ignore warm-boot logic when syncd starts in fast-boot. As well it shouldn't use temporary view between init and apply.
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Sep 14, 2022
Update sonic-utilities submodule pointer to include the following: * [subinterface]Added additional checks in portchannel and subinterface commands (sonic-net#2345) ([sonic-net#2371](sonic-net/sonic-utilities#2371)) * Use warm-boot infrastructure for fast-boot ([sonic-net#2365](sonic-net/sonic-utilities#2365)) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
prsunny
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Sep 15, 2022
Update sonic-utilities submodule pointer to include the following: * b739efc [subinterface]Added additional checks in portchannel and subinterface commands (#2345) ([#2371](sonic-net/sonic-utilities#2371)) * d01153a Use warm-boot infrastructure for fast-boot ([#2365](sonic-net/sonic-utilities#2365))
skbarista
pushed a commit
to skbarista/sonic-sairedis
that referenced
this pull request
Dec 2, 2022
This PR is similar to sonic-net#1100 This PR should be merged together with sonic-utilities PR (sonic-net/sonic-utilities#2365) and sonic-buildimage PR (sonic-net/sonic-buildimage#12026). Fast-reboot is utilizing warm-reboot infrastructure to improve its performance, but it should ignore warm-boot logic when syncd starts in fast-boot. As well it shouldn't use temporary view between init and apply.
This was referenced Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is similar to #2286 - it is being raised as a different PR following discussion with Ying Xie.
This PR should be merged together with the sonic-sairedis PR (sonic-net/sonic-sairedis#1121) and sonic-buildimage PR (sonic-net/sonic-buildimage#12026).
What I did
Improve fast-reboot flow.
How I did it
Using warm-reboot infrastructure.
Clear all routes except of default routes for faster reconciliation time.
How to verify it
Community fast-reboot test, manual testing.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)