[generate_dump] [BCM] Dump only the relevant BCM commands for fabric cards #2606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlakshm
reviewed
Feb 4, 2023
scripts/generate_dump
Outdated
| save_bcmcmd_all_ns "\"tm lag\"" "tm.lag.summary" | ||
| save_bcmcmd_all_ns "\"pp info fec\"" "pp.fec.summary" | ||
| save_bcmcmd_all_ns "\"nif sts\"" "nif.sts.summary" | ||
| switch_type=$(sonic-cfggen -d -v "DEVICE_METADATA['localhost']['switch_type']") |
There was a problem hiding this comment.
with this check if [ $switch_type != "fabric" ]if the supervisor has no configuration then 'show techsupport` will fail?
Instead of check for switch_type, Can we use the flag is_supervisor in the platfrom_env.conf in hwsku folder to check if the card is supervisor or linecard
There was a problem hiding this comment.
ok. Let me check and fix this
kenneth-arista
previously approved these changes
Feb 6, 2023
|
This change excludes running some commands when switchtype is fabric. and the code change looks good to me. |
…cards. Signed-off-by: Sakthivadivu Saravanaraj <sakthivadivu.saravanaraj@nokia.com>
…om platform_env.conf instead of switch_type in DEVICE_METADATA Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
|
@arlakshm , i addressed your review comment. Please take a look at it. |
arlakshm
approved these changes
Mar 16, 2023
arlakshm
approved these changes
Apr 10, 2023
yxieca
pushed a commit
that referenced
this pull request
Apr 19, 2023
…ds for fabric cards (#2606) Signed-off-by: Sakthivadivu Saravanaraj sakthivadivu.saravanaraj@nokia.com What I did When we run generate_dump script in SFM cards in a Broadcom chassis, the errors were printed in syslog for all the Broadcom commands which are not supported in fabric/Ramon cards. Added a check to dump all l2, l3, fp and tm commands only if the switch_type is non fabric card since these commands are not valid for fabric cards. How I did it Get the switch_type from DEVICE_METADATA and check the switch_type before dumping these BCM commands. How to verify it Ran generate_dump script in both voq and fabric cards, (1)verified that the fabric cards don't log the errors for the BCM commands (2) verified that the commands are dumped correctly in non-fabric dnx cards. Signed-off-by: Sakthivadivu Saravanaraj <sakthivadivu.saravanaraj@nokia.com> Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
StormLiangMS
pushed a commit
that referenced
this pull request
Apr 26, 2023
…ds for fabric cards (#2606) Signed-off-by: Sakthivadivu Saravanaraj sakthivadivu.saravanaraj@nokia.com What I did When we run generate_dump script in SFM cards in a Broadcom chassis, the errors were printed in syslog for all the Broadcom commands which are not supported in fabric/Ramon cards. Added a check to dump all l2, l3, fp and tm commands only if the switch_type is non fabric card since these commands are not valid for fabric cards. How I did it Get the switch_type from DEVICE_METADATA and check the switch_type before dumping these BCM commands. How to verify it Ran generate_dump script in both voq and fabric cards, (1)verified that the fabric cards don't log the errors for the BCM commands (2) verified that the commands are dumped correctly in non-fabric dnx cards. Signed-off-by: Sakthivadivu Saravanaraj <sakthivadivu.saravanaraj@nokia.com> Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
May 1, 2023
Update sonic-utilities submodule pointer to include the following: * 600377f7 [DPB]Fixing typo in config breakout output ([sonic-net#2802](sonic-net/sonic-utilities#2802)) * 8ae2424a [config]Support multi-asic Golden Config override ([sonic-net#2738](sonic-net/sonic-utilities#2738)) * 79003ab2 [chassis]: remote cli commands infra for sonic chassis ([sonic-net#2701](sonic-net/sonic-utilities#2701)) * cbc55eeb [voq][chassis][generate_dump] [BCM] Dump only the relevant BCM commands for fabric cards ([sonic-net#2606](sonic-net/sonic-utilities#2606)) * 39c94b7e [GCU] Prohibit removal of PFC_WD POLL_INTERVAL field ([sonic-net#2545](sonic-net/sonic-utilities#2545)) Signed-off-by: dprital <drorp@nvidia.com>
10 tasks
maxliu37
pushed a commit
to maxliu37/SONiC
that referenced
this pull request
May 3, 2024
Update sonic-utilities submodule pointer to include the following: * a1057b27 [config reload]Config Reload Enhancement ([#2693](sonic-net/sonic-utilities#2693)) * 04d0b34a [voq][chassis][generate_dump] [BCM] Dump only the relevant BCM commands for fabric cards ([#2606](sonic-net/sonic-utilities#2606)) Signed-off-by: dgsudharsan <sudharsand@nvidia.com>
maxliu37
pushed a commit
to maxliu37/SONiC
that referenced
this pull request
May 3, 2024
Update sonic-utilities submodule pointer to include the following: * a1057b27 [config reload]Config Reload Enhancement ([#2693](sonic-net/sonic-utilities#2693)) * 04d0b34a [voq][chassis][generate_dump] [BCM] Dump only the relevant BCM commands for fabric cards ([#2606](sonic-net/sonic-utilities#2606)) Signed-off-by: dgsudharsan <sudharsand@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sakthivadivu Saravanaraj sakthivadivu.saravanaraj@nokia.com
What I did
When we run generate_dump script in SFM cards in a Broadcom chassis, the errors were printed in syslog for all the Broadcom commands which are not supported in fabric/Ramon cards. Added a check to dump all l2, l3, fp and tm commands only if the switch_type is non fabric card since these commands are not valid for fabric cards.
How I did it
Get the switch_type from DEVICE_METADATA and check the switch_type before dumping these BCM commands.
How to verify it
Ran generate_dump script in both voq and fabric cards, (1)verified that the fabric cards don't log the errors for the BCM commands (2) verified that the commands are dumped correctly in non-fabric dnx cards.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)